diff mbox

ARM: dts: am335x-bone-common: Fix mmc0 Write Protect

Message ID 20180702202143.25343-1-robertcnelson@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Robert Nelson July 2, 2018, 8:21 p.m. UTC 
Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux
settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape
header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write
Protect.

Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
CC: Faiz Abbas <faiz_abbas@ti.com>
CC: Tony Lindgren <tony@atomide.com>
CC: Jason Kridner <jkridner@beagleboard.org>
CC: Drew Fustini <drew@beagleboard.org>
---
 arch/arm/boot/dts/am335x-bone-common.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Tony Lindgren July 3, 2018, 6:24 a.m. UTC | #1 
* Robert Nelson <robertcnelson@gmail.com> [180702 20:24]:
> Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux
> settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape
> header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write
> Protect.

Thanks applying into omap-for-v4.18/fixes. I'll also add a Fixes tag for
it.

Regards,

Tony
Faiz Abbas July 3, 2018, 6:31 a.m. UTC | #2 
Hi,

On Tuesday 03 July 2018 11:54 AM, Tony Lindgren wrote:
> * Robert Nelson <robertcnelson@gmail.com> [180702 20:24]:
>> Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux
>> settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape
>> header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write
>> Protect.
> 
> Thanks applying into omap-for-v4.18/fixes. I'll also add a Fixes tag for
> it.
> 

The evm sk sdwp needs to be removed as well. I guess I'll post a
separate patch as this is already applied.

Thanks,
Faiz
Robert Nelson July 3, 2018, 10:23 a.m. UTC | #3 
On Tue, Jul 3, 2018 at 1:31 AM, Faiz Abbas <faiz_abbas@ti.com> wrote:
> Hi,
>
> On Tuesday 03 July 2018 11:54 AM, Tony Lindgren wrote:
>> * Robert Nelson <robertcnelson@gmail.com> [180702 20:24]:
>>> Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux
>>> settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape
>>> header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write
>>> Protect.
>>
>> Thanks applying into omap-for-v4.18/fixes. I'll also add a Fixes tag for
>> it.
>>
>
> The evm sk sdwp needs to be removed as well. I guess I'll post a
> separate patch as this is already applied.

Yeah, i don't have an evm sk, while i found found one schematic that
made it look okay, wasn't 100% sure on all the revisions..

Regards,
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi
index f9e8667f5886..73b514dddf65 100644
--- a/arch/arm/boot/dts/am335x-bone-common.dtsi
+++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
@@ -168,7 +168,6 @@ 
 			AM33XX_IOPAD(0x8f0, PIN_INPUT_PULLUP | MUX_MODE0)	/* mmc0_dat3.mmc0_dat3 */
 			AM33XX_IOPAD(0x904, PIN_INPUT_PULLUP | MUX_MODE0)	/* mmc0_cmd.mmc0_cmd */
 			AM33XX_IOPAD(0x900, PIN_INPUT_PULLUP | MUX_MODE0)	/* mmc0_clk.mmc0_clk */
-			AM33XX_IOPAD(0x9a0, PIN_INPUT | MUX_MODE4)		/* mcasp0_aclkr.mmc0_sdwp */
 		>;
 	};