diff mbox

media: stm32: dcmi: replace "%p" with "%pK"

Message ID 20180706130355.22100-1-benjamin.gaignard@st.com (mailing list archive)
State New, archived
Headers show

Commit Message

Benjamin Gaignard July 6, 2018, 1:03 p.m. UTC 
The format specifier "%p" can leak kernel addresses.
Use "%pK" instead.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
 drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hans Verkuil July 6, 2018, 1:51 p.m. UTC | #1 
On 06/07/18 15:03, Benjamin Gaignard wrote:
> The format specifier "%p" can leak kernel addresses.
> Use "%pK" instead.

This patch no longer applies. AFAICT it is obsolete after some code reorg.

Regards,

	Hans

> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
>  drivers/media/platform/stm32/stm32-dcmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
> index 2e1933d872ee..fe90672cf16f 100644
> --- a/drivers/media/platform/stm32/stm32-dcmi.c
> +++ b/drivers/media/platform/stm32/stm32-dcmi.c
> @@ -1753,7 +1753,7 @@ static int dcmi_probe(struct platform_device *pdev)
>  
>  	ret = clk_prepare(mclk);
>  	if (ret) {
> -		dev_err(&pdev->dev, "Unable to prepare mclk %p\n", mclk);
> +		dev_err(&pdev->dev, "Unable to prepare mclk %pK\n", mclk);
>  		goto err_dma_release;
>  	}
>  
>
diff mbox

Patch

diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c
index 2e1933d872ee..fe90672cf16f 100644
--- a/drivers/media/platform/stm32/stm32-dcmi.c
+++ b/drivers/media/platform/stm32/stm32-dcmi.c
@@ -1753,7 +1753,7 @@  static int dcmi_probe(struct platform_device *pdev)
 
 	ret = clk_prepare(mclk);
 	if (ret) {
-		dev_err(&pdev->dev, "Unable to prepare mclk %p\n", mclk);
+		dev_err(&pdev->dev, "Unable to prepare mclk %pK\n", mclk);
 		goto err_dma_release;
 	}