From patchwork Sun Jul 8 00:32:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 10512991 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 873BD603D7 for ; Sun, 8 Jul 2018 00:41:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 72FF0288FC for ; Sun, 8 Jul 2018 00:41:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6472E28900; Sun, 8 Jul 2018 00:41:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0C121288FC for ; Sun, 8 Jul 2018 00:41:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=9dOal+fwiKCeHHe6Nz+cgWruzp922LqKgi5qWAsH0oI=; b=Bbw ZLu32AyvaPZn082WdvMsbCsxoYWKgXll/gUxKXaJLqaRxZ+YN89N/17ZI0DxsvTQTTVyO6w/dGS23 UHQn18UVmIVAUT18YlPzKNXWKNLmeQCr1TVONFzU7G0xBZBgUBE1CmpCmMjH5mJV1DpYzXIy1woF/ r5Px8otHkQyCbu7XjumLdrYWhgTHjutW6o+WnJsapbxqoDuQ7J21Ht8zrlYjYHbU0S4PLJw3UbhXk iq0iAS0zuE6x1H9rIODmmPvz85U09XIujjKvWX4quP8ZLiGDp4FCh75EMS0Y6tArnXBzbbWl2pKU3 sJ1Tj1Madl/uMY2lB1kpIzmiwuoztiw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fbxlh-0007Dn-4u; Sun, 08 Jul 2018 00:41:37 +0000 Received: from mail-wr1-f67.google.com ([209.85.221.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fbxld-0007AL-ND for linux-arm-kernel@lists.infradead.org; Sun, 08 Jul 2018 00:41:35 +0000 Received: by mail-wr1-f67.google.com with SMTP id u7-v6so7426193wrn.12 for ; Sat, 07 Jul 2018 17:41:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BM+QKlIC8KthSCu/wLbxxvH7RykkrTcJ4SBfwo/UojQ=; b=ETpa5WlV5GqVp/CId36PKKcrLcZuMibeUzsZYPt3JRr7qqp42xrbmAfALLolJuYG4E Lpa6cCN6r//svPIRpuJjVnxtAwmPegW30a7XOLEKrlY5X0kb9lJLhqtYqJW25SvEoFe2 SfD6bpHUY930zWxz+JPtNjHfnYVG8/GktUvGxedffOJoLMRqjlUFKniJ71jSEyxQ/kKE MCelNCHBNmpN4cdlmHFv3/kTjgyZ3wsHpJ3jLRPeTKl0lhyqSgo7+1GEK5gQ9RShEGLh f6T65PTMTyYmjRGxsay7iqh4Z0D5phw2EH+LR5uYc/Bn5IAXa98ZMZGtWVPMT7igDOSH Igbw== X-Gm-Message-State: APt69E1T1IwuoWtSKFPHyZ12QfFBIdk5n6yuMNyvGCkiLmIo/wXD71+u R330NdJRY3e9zcV/ChO/V1JEIA== X-Google-Smtp-Source: AAOMgpdkm8dSZh8XQqmMf+wqjJ09abeHgXWYE5CGtgMoAQOA7zIlfhRbFgTdJ1JauFiEDN7qu9e+8A== X-Received: by 2002:adf:aadb:: with SMTP id i27-v6mr10637527wrc.149.1531009986622; Sat, 07 Jul 2018 17:33:06 -0700 (PDT) Received: from minerva.wifivip.local (88.red-83-53-218.dynamicip.rima-tde.net. [83.53.218.88]) by smtp.gmail.com with ESMTPSA id z193-v6sm16197829wmc.14.2018.07.07.17.33.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Jul 2018 17:33:05 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Subject: [PATCH v3] driver core: add a debugfs entry to show deferred devices Date: Sun, 8 Jul 2018 02:32:56 +0200 Message-Id: <20180708003256.15655-1-javierm@redhat.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180707_174133_755498_4EB1FBC3 X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Tomeu Vizoso , Greg Kroah-Hartman , Javier Martinez Canillas , Andy Shevchenko , Mark Brown , Peter Robinson , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP With Device Trees (DT), the dependencies of the devices are defined in the DT, then the drivers parse that information to lookup the needed resources that have as dependencies. Since drivers and devices are registered in a non-deterministic way, it is possible that a device that is a dependency has not been registered yet by the time that is looked up. In this case the driver that requires this dependency cannot probe and has to defer it. So the driver core adds it to a list of deferred devices that is iterated again every time that a new driver is probed successfully. For debugging purposes it may be useful to know what are the devices whose probe function was deferred. Add a debugfs entry showing that information. $ cat /sys/kernel/debug/devices_deferred 48070000.i2c:twl@48:bci musb-hdrc.0.auto omapdrm.0 This information could be obtained partially by enabling debugging, but it means that the kernel log has to be parsed and the probe deferral balanced with the successes. This can be error probe and has to be done in a ad-hoc manner by everyone who needs to debug these kind of issues. Since the information is already known by the kernel, just show it to make it easier to debug. Signed-off-by: Javier Martinez Canillas Reviewed-by: Andy Shevchenko Reviewed-by: Mark Brown --- Changes since RFC v1: - Remove unneeded ret variable from deferred_devs_show() Changes since RFC v2: - Use DEFINE_SHOW_ATTRIBUTE() macro. - Don't propagate debugfs_create_file() error. - Remove IS_ENABLED(CONFIG_DEBUG_FS) guards. - Drop RFC prefix. Changes since v1: - Better explain in the commit message why this patch is useful. - Rename deferred_devices entry to devices_deferred. - Add an exit function and remove the debugfs entry. Changes since v2: - Add Andy Shevchenko and Mark Brown Reviewed-by tag. - Rebase on top of Greg's driver-core-next branch. drivers/base/dd.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 6ea9c5cece7..140f534ee9c 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -16,6 +16,7 @@ * Copyright (c) 2007-2009 Novell Inc. */ +#include #include #include #include @@ -53,6 +54,8 @@ static DEFINE_MUTEX(deferred_probe_mutex); static LIST_HEAD(deferred_probe_pending_list); static LIST_HEAD(deferred_probe_active_list); static atomic_t deferred_trigger_count = ATOMIC_INIT(0); +static struct dentry *deferred_devices; +static bool initcalls_done; /* * In some cases, like suspend to RAM or hibernation, It might be reasonable @@ -199,6 +202,24 @@ void device_unblock_probing(void) driver_deferred_probe_trigger(); } +/* + * deferred_devs_show() - Show the devices in the deferred probe pending list. + */ +static int deferred_devs_show(struct seq_file *s, void *data) +{ + struct device_private *curr; + + mutex_lock(&deferred_probe_mutex); + + list_for_each_entry(curr, &deferred_probe_pending_list, deferred_probe) + seq_printf(s, "%s\n", dev_name(curr->device)); + + mutex_unlock(&deferred_probe_mutex); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(deferred_devs); + /** * deferred_probe_initcall() - Enable probing of deferred devices * @@ -208,6 +229,9 @@ void device_unblock_probing(void) */ static int deferred_probe_initcall(void) { + deferred_devices = debugfs_create_file("devices_deferred", 0444, NULL, + NULL, &deferred_devs_fops); + driver_deferred_probe_enable = true; driver_deferred_probe_trigger(); /* Sort as many dependencies as possible before exiting initcalls */ @@ -216,6 +240,12 @@ static int deferred_probe_initcall(void) } late_initcall(deferred_probe_initcall); +static void __exit deferred_probe_exit(void) +{ + debugfs_remove_recursive(deferred_devices); +} +__exitcall(deferred_probe_exit); + /** * device_is_bound() - Check if device is bound to a driver * @dev: device to check