| Message ID | 20180711132623.13227-1-ludovic.desroches@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 11, 2018 at 03:26:23PM +0200, Ludovic Desroches wrote: > From: Nicolas Ferre <nicolas.ferre@microchip.com> > > In atmel_shutdown() we call atmel_stop_rx() and atmel_stop_tx() functions. > Prevent the rx restart that is implemented in RS485 or ISO7816 modes when > calling atmel_stop_tx() by using the atomic information tasklet_shutdown > that is already in place for this purpose. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > drivers/tty/serial/atmel_serial.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Did you send this patch twice? confused, greg k-h
On Thu, Jul 12, 2018 at 04:58:27PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:26:23PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre <nicolas.ferre@microchip.com> > > > > In atmel_shutdown() we call atmel_stop_rx() and atmel_stop_tx() functions. > > Prevent the rx restart that is implemented in RS485 or ISO7816 modes when > > calling atmel_stop_tx() by using the atomic information tasklet_shutdown > > that is already in place for this purpose. > > > > Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com> > > --- > > drivers/tty/serial/atmel_serial.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > Did you send this patch twice? > > confused, Yes sorry, as I didn't receive patch 3/3, I resend it. At the end, it was sent twice. Regards Ludovic > > greg k-h > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index 0118b219f3a8..e4f877e1f3c6 100644 --- a/drivers/tty/serial/atmel_serial.c +++ b/drivers/tty/serial/atmel_serial.c @@ -617,7 +617,9 @@ static void atmel_stop_tx(struct uart_port *port) if (((port->rs485.flags & SER_RS485_ENABLED) && !(port->rs485.flags & SER_RS485_RX_DURING_TX)) || port->iso7816.flags & SER_ISO7816_ENABLED) - atmel_start_rx(port); + if (!atomic_read(&atmel_port->tasklet_shutdown)) + atmel_start_rx(port); + } /*