From patchwork Wed Jul 11 22:50:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Hutchings X-Patchwork-Id: 10520681 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 92141600CA for ; Wed, 11 Jul 2018 22:50:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7925029626 for ; Wed, 11 Jul 2018 22:50:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7691D2983A; Wed, 11 Jul 2018 22:50:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E8A9A29626 for ; Wed, 11 Jul 2018 22:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:Message-ID:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=+fU6/UGefz56HLe88Gg03CD3FXLgPe9hGzzMiErHJmQ=; b=bfu gevl8uyHK81pHzrTB3o6167yj7D47/pbX9sH4T1YJF30rWRcBvcqhTGva6rWDALNFpHbNuMvp2TSz msL4y6d7URlE1+Ioz6yrh9aHHOdW64+l7HH0cNf4gRggoKlynkd2BhM+/MPNT+EQrDOZUaZguvLif 1vlUJC3AirCpt32qfy/aTUCWnrej6P9OaicH+lp8lQIVf3MalgADlspZd9RaFhMKDKHzmxZGpEowy UBe/oD5nWRwD7cJ66JCurnD2DQ0rr81Q+JwK2ffpixiJvjOgzGjQwvsM7W5k0KvJ3PkyzEbJXrLuv 8YXfUtjZHm43VpCa9WHoF+6oRDJowOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fdNwP-0002oG-Np; Wed, 11 Jul 2018 22:50:33 +0000 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fdNwM-0002mM-Pf for linux-arm-kernel@lists.infradead.org; Wed, 11 Jul 2018 22:50:32 +0000 Received: from ben by shadbolt.decadent.org.uk with local (Exim 4.84_2) (envelope-from ) id 1fdNw6-0003Hz-07; Wed, 11 Jul 2018 23:50:14 +0100 Date: Wed, 11 Jul 2018 23:50:13 +0100 From: Ben Hutchings To: linux-arm-kernel@lists.infradead.org Message-ID: <20180711225013.GF14131@decadent.org.uk> MIME-Version: 1.0 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: ben@decadent.org.uk Subject: [PATCH] ARM: mm: Export __sync_icache_dcache() for xen-privcmd X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on shadbolt.decadent.org.uk) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180711_155030_979852_BF8A16FE X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Durrant Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The xen-privcmd driver, which can be modular, calls set_pte_at() which in turn may call __sync_icache_dcache(). The call to __sync_icache_dcache() may be optimised out because it is conditional on !pte_special(), and xen-privcmd calls pte_mkspecial(). However, in a non-LPAE configuration there is no "special" bit and the call is really unconditional. Fixes: 3ad0876554ca ("xen/privcmd: add IOCTL_PRIVCMD_MMAP_RESOURCE") Signed-off-by: Ben Hutchings --- This is a 4.18 regression so ideally should be fixed before 4.18 is released. Ben. arch/arm/mm/flush.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mm/flush.c b/arch/arm/mm/flush.c index 58469623b015..5345f86c56d2 100644 --- a/arch/arm/mm/flush.c +++ b/arch/arm/mm/flush.c @@ -295,6 +295,7 @@ void __sync_icache_dcache(pte_t pteval) if (pte_exec(pteval)) __flush_icache_all(); } +EXPORT_SYMBOL_GPL(__sync_icache_dcache); #endif /*