| Message ID | 20180719175356.14753-2-vivek.gautam@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jul 19, 2018 at 11:54 AM Vivek Gautam <vivek.gautam@codeaurora.org> wrote: > > Add device node for arm,mmu-500 available on sdm845. > This MMU-500 with single TCU and multiple TBU architecture > is shared among all the peripherals except gpu on sdm845. > > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ++ > arch/arm64/boot/dts/qcom/sdm845.dtsi | 73 +++++++++++++++++++++++++++++++++ > 2 files changed, 77 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > index 6d651f314193..13b50dff440f 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > @@ -58,3 +58,7 @@ > bias-pull-up; > }; > }; > + > +&apps_smmu { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 00722b533a92..70ca18ae6cb3 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -980,6 +980,79 @@ > cell-index = <0>; > }; > > + apps_smmu: arm,smmu@15000000 { iommu@... > + compatible = "arm,mmu-500"; Really unmodified by QCom? Would be better to have SoC specific compatible. Rob
Hi Rob, On Fri, Jul 20, 2018 at 4:38 AM, Rob Herring <robh+dt@kernel.org> wrote: > On Thu, Jul 19, 2018 at 11:54 AM Vivek Gautam > <vivek.gautam@codeaurora.org> wrote: >> >> Add device node for arm,mmu-500 available on sdm845. >> This MMU-500 with single TCU and multiple TBU architecture >> is shared among all the peripherals except gpu on sdm845. >> >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ++ >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 73 +++++++++++++++++++++++++++++++++ >> 2 files changed, 77 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >> index 6d651f314193..13b50dff440f 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >> @@ -58,3 +58,7 @@ >> bias-pull-up; >> }; >> }; >> + >> +&apps_smmu { >> + status = "okay"; >> +}; >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> index 00722b533a92..70ca18ae6cb3 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> @@ -980,6 +980,79 @@ >> cell-index = <0>; >> }; >> >> + apps_smmu: arm,smmu@15000000 { > > iommu@... Thanks for the review. Sure, will modify this. > >> + compatible = "arm,mmu-500"; > > Really unmodified by QCom? Would be better to have SoC specific compatible. Yes, at this point we are able to use the driver as is on 845. But, will add a SoC specific compatible as suggested to make bindings future proof. Best regards Vivek > > Rob > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi, On Thu, Jul 19, 2018 at 10:53 AM, Vivek Gautam <vivek.gautam@codeaurora.org> wrote: > Add device node for arm,mmu-500 available on sdm845. > This MMU-500 with single TCU and multiple TBU architecture > is shared among all the peripherals except gpu on sdm845. > > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ++ > arch/arm64/boot/dts/qcom/sdm845.dtsi | 73 +++++++++++++++++++++++++++++++++ > 2 files changed, 77 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > index 6d651f314193..13b50dff440f 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts > @@ -58,3 +58,7 @@ > bias-pull-up; > }; > }; > + > +&apps_smmu { > + status = "okay"; > +}; When you spin this patch please put the above in the correct place. Since "a" sorts alphabetically before "i" then this should be just before the line: &i2c10 { Thanks! -Doug
Hi, On Fri, Aug 10, 2018 at 3:18 PM, Doug Anderson <dianders@chromium.org> wrote: > Hi, > > On Thu, Jul 19, 2018 at 10:53 AM, Vivek Gautam > <vivek.gautam@codeaurora.org> wrote: >> Add device node for arm,mmu-500 available on sdm845. >> This MMU-500 with single TCU and multiple TBU architecture >> is shared among all the peripherals except gpu on sdm845. >> >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ++ >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 73 +++++++++++++++++++++++++++++++++ >> 2 files changed, 77 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >> index 6d651f314193..13b50dff440f 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >> @@ -58,3 +58,7 @@ >> bias-pull-up; >> }; >> }; >> + >> +&apps_smmu { >> + status = "okay"; >> +}; > > When you spin this patch please put the above in the correct place. > Since "a" sorts alphabetically before "i" then this should be just > before the line: > > &i2c10 { Sorry--one more thing I thought of after I sent this out... Possibly you can drop this part of the patch completely and get rid of the 'status = "disabled";' in sdm845.dtsi. As I understand it you really only want to mark things as disabled in the SoC dtsi file if some boards might use this device and other boards wouldn't. For instance not all boards will have the SD card controller hooked up / enabled so having that set to "disabled" in the SoC device tree file makes sense. ...but it's not a board-level question about whether the SMMU is present--it's always there. You don't gain anything by forcing all boards to set status to "okay". -Doug
Hi Doug, On 8/11/2018 4:00 AM, Doug Anderson wrote: > Hi, > > On Fri, Aug 10, 2018 at 3:18 PM, Doug Anderson <dianders@chromium.org> wrote: >> Hi, >> >> On Thu, Jul 19, 2018 at 10:53 AM, Vivek Gautam >> <vivek.gautam@codeaurora.org> wrote: >>> Add device node for arm,mmu-500 available on sdm845. >>> This MMU-500 with single TCU and multiple TBU architecture >>> is shared among all the peripherals except gpu on sdm845. >>> >>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >>> --- >>> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ++ >>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 73 +++++++++++++++++++++++++++++++++ >>> 2 files changed, 77 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >>> index 6d651f314193..13b50dff440f 100644 >>> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >>> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >>> @@ -58,3 +58,7 @@ >>> bias-pull-up; >>> }; >>> }; >>> + >>> +&apps_smmu { >>> + status = "okay"; >>> +}; >> When you spin this patch please put the above in the correct place. >> Since "a" sorts alphabetically before "i" then this should be just >> before the line: >> >> &i2c10 { > Sorry--one more thing I thought of after I sent this out... > > Possibly you can drop this part of the patch completely and get rid of > the 'status = "disabled";' in sdm845.dtsi. As I understand it you > really only want to mark things as disabled in the SoC dtsi file if > some boards might use this device and other boards wouldn't. For > instance not all boards will have the SD card controller hooked up / > enabled so having that set to "disabled" in the SoC device tree file > makes sense. ...but it's not a board-level question about whether the > SMMU is present--it's always there. You don't gain anything by > forcing all boards to set status to "okay". Thanks for reviewing the patches. Will sort the node as per alphabetical order. Also as you pointed, it makes sense to not have the 'status' property in SMMU. Will remove that. Thanks. Best regards Vivek > > > -Doug
diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts index 6d651f314193..13b50dff440f 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts @@ -58,3 +58,7 @@ bias-pull-up; }; }; + +&apps_smmu { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 00722b533a92..70ca18ae6cb3 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -980,6 +980,79 @@ cell-index = <0>; }; + apps_smmu: arm,smmu@15000000 { + compatible = "arm,mmu-500"; + reg = <0x15000000 0x80000>; + #iommu-cells = <2>; + #global-interrupts = <1>; + interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 181 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 182 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 316 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 318 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 319 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 320 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 321 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 322 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 323 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 324 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 325 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 326 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 327 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 328 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 329 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 330 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 333 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 334 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 335 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 336 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 337 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 339 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 340 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 341 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 342 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 343 IRQ_TYPE_LEVEL_HIGH>; + status = "disabled"; + }; + apss_shared: mailbox@17990000 { compatible = "qcom,sdm845-apss-shared"; reg = <0x17990000 0x1000>;
Add device node for arm,mmu-500 available on sdm845. This MMU-500 with single TCU and multiple TBU architecture is shared among all the peripherals except gpu on sdm845. Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> --- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 4 ++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 73 +++++++++++++++++++++++++++++++++ 2 files changed, 77 insertions(+)