From patchwork Wed Jul 25 09:55:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 10543789 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F25A31822 for ; Wed, 25 Jul 2018 09:56:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF68029439 for ; Wed, 25 Jul 2018 09:56:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D13D52943E; Wed, 25 Jul 2018 09:56:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 669E629439 for ; Wed, 25 Jul 2018 09:56:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=AGnMt9xsGi+pIoiu9UCNuoXKNtKeLvLiLQSPeZEpu4I=; b=XcTTGtwjxcjlAB 6doWn23Oa84UYXnW/KYjYUqX+P+TKWiu5VdKN1Oojufkj8K8YFxZ4y92X8MEKgaP3S6QC+Coxwa0R Bsv0NmGfRrkA7uka3m6k5TuKxzdJM+j0O1Z0h3W5RKkVnhjtj/yaIMmqSf76MI3v0+duUMUPGZLuz YQKTlCA/dLMMhBpmKDqw8CAjUXYknQvCWb2nothqazfmt0pGbs5SZ/Yr/WtJq6l5KvtGerX2+UDPh QkGiKwgGV8jUFbHrGm7WcU0XBAxS+QgP7bpOtSsFQbxdr/5oY/aAgnkAib8jdwJTIuTi/oyKPnnNt 1bpChKLdFhK9JLp2hqRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fiGWq-0007e1-JY; Wed, 25 Jul 2018 09:56:20 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fiGWn-0007ch-9Z for linux-arm-kernel@lists.infradead.org; Wed, 25 Jul 2018 09:56:18 +0000 Received: by mail-lj1-x244.google.com with SMTP id r13-v6so6148991ljg.10 for ; Wed, 25 Jul 2018 02:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Cgw709ofsERJ+D62PUlElyHEPGhEDBMyoUL1H2Y3XZE=; b=SKCJWjnIU3lyq4FYlmI7Zcr3CaG3RLKyCQt7Fdd1/0qKo/s0CYhN6Q5dhRQgVyK/VK gTHbR7WJZ/8W4O+7ETql2for2UZRuZnjSPW6+Boi3vL+uLVXXgyvOgnulpVxkoJUY6u8 5vBSc06QPEMTSjecbMk61N4XmES75ExnaR4TY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Cgw709ofsERJ+D62PUlElyHEPGhEDBMyoUL1H2Y3XZE=; b=VTJiKEme5uwM7ap5/05G5nTtxsFenBYxuhDikklTmlfj2sh8LgCNxuBpPMBLsmvKAP +FljcFJmvvmWnQhlnE7qBicfJDRxs34ox+vfc6IkIl/QUGHy1KotaLQGlzm7itR/HCbB /Mso74Zcm3EMjGwpxPp3f8ZP3I2eIasLdFe9t59sROGIXLwuQvN/opztBOBpWviQv+so MvS+BxpfHipnlm5ymjX0zVDUdjI8epkMPdcDiR0mywD/KqbTaNHJXF1NQg0Il2+yD8F+ bytoyx37f+kcC/fH2sGKe64puH7IfgnfujzBjN4MBZqDztR6/WViD4IagF/cfqWu2/v4 4T7w== X-Gm-Message-State: AOUpUlGMHM9pcMZM0t4qE63YSRw80thsJ0MmoIQxVs2SLrGQIKU7j9mM Fv9lJDv8PAq9W3J7au0YB0Tsr0oFI0o= X-Google-Smtp-Source: AAOMgpfdHGjhADoQrtCu3U4Bjb4+JlEwzvj0OO2nLSwwQCppm1tZvbpjbk/3sxUHKUaW2SUIe2WZlA== X-Received: by 2002:a2e:4701:: with SMTP id u1-v6mr15487858lja.54.1532512564825; Wed, 25 Jul 2018 02:56:04 -0700 (PDT) Received: from localhost (c-2c3d70d5.07-21-73746f28.bbcust.telenor.se. [213.112.61.44]) by smtp.gmail.com with ESMTPSA id 20-v6sm2675198ljs.32.2018.07.25.02.56.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Jul 2018 02:56:04 -0700 (PDT) From: Anders Roxell To: riel@surriel.com, peterz@infradead.org, mingo@kernel.org, songliubraving@fb.com, linux@armlinux.org.uk, dave.hansen@intel.com, x86@kernel.org Subject: [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration Date: Wed, 25 Jul 2018 11:55:57 +0200 Message-Id: <20180725095557.19668-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180725_025617_339440_CA362581 X-CRM114-Status: GOOD ( 10.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anders Roxell , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Building on arm 32 with LPAE enabled we don't include asm-generic/tlb.h, where we have tlb_flush_remove_tables_local and tlb_flush_remove_tables defined. mm/memory.c: In function ‘tlb_remove_table_smp_sync’: mm/memory.c:339:2: error: implicit declaration of function ‘tlb_flush_remove_tables_local’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration] tlb_flush_remove_tables_local(mm); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tlb_remove_table mm/memory.c: In function ‘tlb_table_flush’: mm/memory.c:372:2: error: implicit declaration of function ‘tlb_flush_remove_tables’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration] tlb_flush_remove_tables(tlb->mm); ^~~~~~~~~~~~~~~~~~~~~~~ tlb_remove_table To fix this issue we define them in arm 32's specific asm/tlb.h file. Fixes: 2ff6ddf19c0e ("x86/mm/tlb: Leave lazy TLB mode at page table free time") Signed-off-by: Anders Roxell --- Ingo, would it make sense for you to pick it up into the x86 tree since that contains the bug ? Cheers, Anders arch/arm/include/asm/tlb.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h index d5562f9ce600..f854148c8d7c 100644 --- a/arch/arm/include/asm/tlb.h +++ b/arch/arm/include/asm/tlb.h @@ -292,5 +292,13 @@ static inline void tlb_remove_check_page_size_change(struct mmu_gather *tlb, { } +static inline void tlb_flush_remove_tables(struct mm_struct *mm) +{ +} + +static inline void tlb_flush_remove_tables_local(void *arg) +{ +} + #endif /* CONFIG_MMU */ #endif