| Message ID | 20180904163609.10171-4-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4,1/4] clk: sunxi-ng: Enable DE2_CCU for SUN8I and SUN50I | expand |
On Tue, Sep 04, 2018 at 10:06:09PM +0530, Jagan Teki wrote: > Allwinner SUN50I are now using DesignWare HDMI so enable > them as default. This can build DRM_SUN8I_DW_HDMI as module > since DRM in arm64 has module. > > Making this as defult to SUN8I, may cause an issue while > loading since arm32 DRM built as static. Uh? Why? We should fix this instead of working around it. Maxime
On Wed, Sep 5, 2018 at 12:38 PM, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > On Tue, Sep 04, 2018 at 10:06:09PM +0530, Jagan Teki wrote: >> Allwinner SUN50I are now using DesignWare HDMI so enable >> them as default. This can build DRM_SUN8I_DW_HDMI as module >> since DRM in arm64 has module. >> >> Making this as defult to SUN8I, may cause an issue while >> loading since arm32 DRM built as static. > > Uh? Why? We should fix this instead of working around it. I didn't dig further on this. Since ARM64 has is fine with it both (module and static) may be we can take this.
On Wed, Sep 05, 2018 at 01:54:42PM +0530, Jagan Teki wrote: > On Wed, Sep 5, 2018 at 12:38 PM, Maxime Ripard > <maxime.ripard@bootlin.com> wrote: > > On Tue, Sep 04, 2018 at 10:06:09PM +0530, Jagan Teki wrote: > >> Allwinner SUN50I are now using DesignWare HDMI so enable > >> them as default. This can build DRM_SUN8I_DW_HDMI as module > >> since DRM in arm64 has module. > >> > >> Making this as defult to SUN8I, may cause an issue while > >> loading since arm32 DRM built as static. > > > > Uh? Why? We should fix this instead of working around it. > > I didn't dig further on this. Since ARM64 has is fine with it both > (module and static) may be we can take this. No, this build breakage needs to be (reported and) addressed first. Maxime
diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig index cfa8b96273fb..5d0c450db148 100644 --- a/drivers/gpu/drm/sun4i/Kconfig +++ b/drivers/gpu/drm/sun4i/Kconfig @@ -52,6 +52,7 @@ config DRM_SUN6I_DSI config DRM_SUN8I_DW_HDMI tristate "Support for Allwinner version of DesignWare HDMI" + default ARM64 && ARCH_SUNXI depends on DRM_SUN4I select DRM_DW_HDMI help
Allwinner SUN50I are now using DesignWare HDMI so enable them as default. This can build DRM_SUN8I_DW_HDMI as module since DRM in arm64 has module. Making this as defult to SUN8I, may cause an issue while loading since arm32 DRM built as static. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v4: - none Changes for v3: - skip SUN8I enablement, since it built statically for arm32 Changes for v2: - Enable for SUN8I drivers/gpu/drm/sun4i/Kconfig | 1 + 1 file changed, 1 insertion(+)