diff mbox series

clk: mvebu: ap806: Remove superfluous of_clk_add_provider

Message ID 20180912153549.14437-1-gregory.clement@bootlin.com (mailing list archive)
State New, archived
Headers show
Series clk: mvebu: ap806: Remove superfluous of_clk_add_provider | expand

Commit Message

Gregory CLEMENT Sept. 12, 2018, 3:35 p.m. UTC 
While applying the commit a8309cedcdce ("clk: apn806: Add eMMC clock to
system controller driver"), of_clk_add_provider was added wheres it was
already present in the probe function.

This extraneous call is harmless but not useful so remove it.

Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---
 drivers/clk/mvebu/ap806-system-controller.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Stephen Boyd Oct. 1, 2018, 10:13 p.m. UTC | #1 
Quoting Gregory CLEMENT (2018-09-12 08:35:49)
> While applying the commit a8309cedcdce ("clk: apn806: Add eMMC clock to
> system controller driver"), of_clk_add_provider was added wheres it was
> already present in the probe function.
> 
> This extraneous call is harmless but not useful so remove it.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/mvebu/ap806-system-controller.c b/drivers/clk/mvebu/ap806-system-controller.c
index 9fbec3eb725f..ea54a874bbda 100644
--- a/drivers/clk/mvebu/ap806-system-controller.c
+++ b/drivers/clk/mvebu/ap806-system-controller.c
@@ -153,7 +153,6 @@  static int ap806_syscon_common_probe(struct platform_device *pdev,
 		goto fail4;
 	}
 
-	of_clk_add_provider(np, of_clk_src_onecell_get, &ap806_clk_data);
 	ret = of_clk_add_provider(np, of_clk_src_onecell_get, &ap806_clk_data);
 	if (ret)
 		goto fail_clk_add;