From patchwork Fri Sep 14 10:13:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Izard X-Patchwork-Id: 10600603 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6F03A933 for ; Fri, 14 Sep 2018 10:15:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 47D242B188 for ; Fri, 14 Sep 2018 10:15:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3B1E22B1BF; Fri, 14 Sep 2018 10:15:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BC6402B188 for ; Fri, 14 Sep 2018 10:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=PBhwExtsrtGwoDWOYMhddLOa0e8ibrYZOxwqYpH99hc=; b=hYGo9x4pDLjs3IUSKmVDFIAN5Z y2HvhnP1JPeFFiclaCKBfD9m9jinakIuW8IOsthR/6SzBK7hdZ03CYyH1BQygIctxt3bUgnx9UpW8 nGy5b1J4c0sccPVKo+lxs2cg4A6ciBqxvftbVDwDjFIDqRpGaWATDF8p+/zlB1DDZopKRfEfLXHa7 0VH9GfNQb7tp6kYAKj4av9M9QWAPVotqmcks4SkKVnRFxPcvqgXLMNg+bi40o9lNsJbmoH4w0q/bN vYkZ/NMxG2rQF5dOezEzNjxAZoAmX8wUau+9XoFihYXG8H3LJKcTK8BVnpcYeb/as6QOUZY9s1dcU EOadBV2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g0l7c-00077m-9t; Fri, 14 Sep 2018 10:14:44 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g0l72-0006hq-UY for linux-arm-kernel@lists.infradead.org; Fri, 14 Sep 2018 10:14:10 +0000 Received: by mail-wm1-x341.google.com with SMTP id f21-v6so1369670wmc.5 for ; Fri, 14 Sep 2018 03:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wQJV+ddJAv5kZKQDNvJ+wHS7DL8i4Je+cSh6xS7XWuM=; b=rircDlgBDrHWS6V0DOCcfoALp08ITkG3cQ57mUW7/dQW9MhPvpXC9MaJHZD4JFOI7h qKMb3jIRf04nxQSuFVj4cpLQJ78Cm+PNn648suHBIaqZP2UWd8b3tCgjEfSyPdSxIqjm A1loWb8zNhxtU80TYzg0Dj6lTTtHHGbgu0W1aky+Ukrdv8j2iaRljnVwl9IEiuy6noJr CoexKYHOav8Shb2F26s6rbnNSBjZfZAGDXBDZgdXJKLu22hORAr1+f0ozckapDmBpLJ3 ihAzUGDDn550klDx8+4KhI+utfVHeFKEtUc2rRK7zlvyp7MjPxBZ7ptAeDwE2IsCg1Wn hRuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wQJV+ddJAv5kZKQDNvJ+wHS7DL8i4Je+cSh6xS7XWuM=; b=MIqwnEw6mK0gJmYAiA7gpnH/oM8m5XgyQ8XfFCiUHJjx9X3+E7R9eZIhlnnxDVUrUt Awbl2U3iDPlJ0+ejDfTy0yt5yY30UxqgEOrWyX76XLXBq/cySD5fM2vyegtS2zh8nNXq 5vkhGWyvS32DASByJ19hEy1B4fTS4O9Z+nmLwk3nJFCYLf0IwjNfaqyKngQUumjDdisz csVtDBHvI2V48aq6Xgj3xCeEAfpgDAVYVLTVWCGAoO5Gmu8IiXedo9KJVckU1nVjWrCI pJA2jRSiarqXdlCWw5cSfHwh5JHiHK8Jpij//K6SiNjiodLnwkRg4vUTTC5uJkTW6OUh B81Q== X-Gm-Message-State: APzg51CzOlsV2y6/W4OYosDSKmixDvxootMkCyGsDJEZdorhHC7orAzg AaXgacoYzQrpIItfR/mthWyyhOPy X-Google-Smtp-Source: ANB0VdZY8rvGy+QS/OOWRyvjzzsgebRm2THF2oWSkUDULpGLrdu6XY0391j5GLt03LxcjIDA5ZGA7w== X-Received: by 2002:a1c:ed4:: with SMTP id 203-v6mr1576847wmo.96.1536920037259; Fri, 14 Sep 2018 03:13:57 -0700 (PDT) Received: from localhost.localdomain (static-css-cqn-143221.business.bouyguestelecom.com. [176.149.143.221]) by smtp.gmail.com with ESMTPSA id x15-v6sm5618524wrt.53.2018.09.14.03.13.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Sep 2018 03:13:56 -0700 (PDT) From: Romain Izard To: Nicolas Ferre , Alexandre Belloni , Wim Van Sebroeck , Guenter Roeck , Marcus Folkesson Subject: [PATCH 1/2] watchdog: sama5d4: fix timeout-sec usage Date: Fri, 14 Sep 2018 12:13:38 +0200 Message-Id: <20180914101339.7382-2-romain.izard.pro@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180914101339.7382-1-romain.izard.pro@gmail.com> References: <20180914101339.7382-1-romain.izard.pro@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180914_031408_988706_2F47B036 X-CRM114-Status: GOOD ( 14.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Romain Izard , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When using watchdog_init_timeout to update the default timeout value, an error means that there is no "timeout-sec" in the relevant device tree node. This should not prevent binding of the driver to the device. Fixes: 976932e40036 ("watchdog: sama5d4: make use of timeout-secs provided in devicetree") Signed-off-by: Romain Izard Reviewed-by: Guenter Roeck Reviewed-by: Marcus Folkesson --- drivers/watchdog/sama5d4_wdt.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c index 255169916dbb..1e93c1b0e3cf 100644 --- a/drivers/watchdog/sama5d4_wdt.c +++ b/drivers/watchdog/sama5d4_wdt.c @@ -247,11 +247,7 @@ static int sama5d4_wdt_probe(struct platform_device *pdev) } } - ret = watchdog_init_timeout(wdd, wdt_timeout, &pdev->dev); - if (ret) { - dev_err(&pdev->dev, "unable to set timeout value\n"); - return ret; - } + watchdog_init_timeout(wdd, wdt_timeout, &pdev->dev); timeout = WDT_SEC2TICKS(wdd->timeout);