From patchwork Wed Sep 19 06:29:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pi-Hsun Shih X-Patchwork-Id: 10605365 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A740B15A6 for ; Wed, 19 Sep 2018 06:30:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 92D9E2B629 for ; Wed, 19 Sep 2018 06:30:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8522B2B633; Wed, 19 Sep 2018 06:30:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1D0852B629 for ; Wed, 19 Sep 2018 06:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b1xOSjr0Bz4UgJztX+GcJ/VkKY02zxtRrETkHAqUDd0=; b=BFZjy6db602kDJ EcoVMnNtJr5PdmJpmxJQCDPc37NuAfirK5rmOZX92hEzaR4buBVynCMLeU7Dz/eP72oB+p6M+u7AL 4fN3EZco5kxafPwEerKTepRPIfgZrVYsD54FDYG7IhIE8t1Qk5agR2b5Kjz42WgAJhPiIeBrwLRUB Q5XU+rbT9Dn0OWT40XWxLp+7Dye9HiiSIJ8Ay7yf1rXxT39cW7FmmLiZgfRMG2CQf02TDpJtppiKb y4dMjiAAPCR6zW0GJZDop6Vsi0O/LUeXETpFq+UTou0BIb5Kidpng2SMh+bf0zs+d2jMhGw3HdGIH KGY8s+1Pwk9FiENQeVsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g2W0V-0003M0-Qq; Wed, 19 Sep 2018 06:30:39 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g2W0P-0003Jw-5z for linux-arm-kernel@lists.infradead.org; Wed, 19 Sep 2018 06:30:36 +0000 Received: by mail-pf1-x443.google.com with SMTP id h79-v6so2197992pfk.8 for ; Tue, 18 Sep 2018 23:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4UxYp9Fd6cQxttmxSAWHS+kOvGw5onYHLG7nB8EqH7I=; b=iPxpUv9YM2oQncReLzlo1rl/sWHUju78qzBVX/OAYcoi1eagyg98xgBQ3+5oJL3iaW GWV96pP18tXwXLAhmmMo4E2ljmlQ9GOywT5iMouqVC5TGpl/3qsrfYiTABeNpK36dz/x Z+1kO/OV3kNgeoxtFE7+vsr9OWrxJo1PzJT2I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4UxYp9Fd6cQxttmxSAWHS+kOvGw5onYHLG7nB8EqH7I=; b=B3xVNzzaZc7ULzQh8SoEZkQrDiIC81RIdo6tUT1HVG+ITW4cdItC/xX9bFht0BwJm2 dgP31FK2DZ2o0376Gtsc1gK2nvbTR+92bYHunmPAjIhj0OAlbER2rOdipvb8yOODbFBv AxaRKBcT7A2dKy9gceCb0J2Xyt0lsNx6D3eknxtJiqHCnR+8+dzAhHxYMAEUg5Wu2gDE I4gKJt+22/INMzTPPLWZrAZB9pPRf/YRRW5IcirgBmJBlepFWFa3hBbHNneVr3qLfGbJ LWlZqiw2CYH28c8EaodDwlTdk/oLyroyNhaQ365YWOOG6E3EEPZP0l9BFqgW5YCDQyMN YKDw== X-Gm-Message-State: APzg51Cyb6VtZtK8T6UMir8c19zi+JWTkFHK2EqPl+HgoAL/R9yM+vvq Tr5aXAIMjR7FVtqPLJi3hyqVqw== X-Google-Smtp-Source: ANB0VdZc+2gPVF+SaGBErUHPlMfEpvdDJvd8gWELQlNaZib6i7Gt+oXWyvy0syRfyje1OQLWJExlUg== X-Received: by 2002:a63:e54b:: with SMTP id z11-v6mr30498558pgj.328.1537338620266; Tue, 18 Sep 2018 23:30:20 -0700 (PDT) Received: from pihsun-z840.tpe.corp.google.com ([2401:fa00:1:10:1039:d81d:d174:8fe9]) by smtp.googlemail.com with ESMTPSA id y7-v6sm37188874pff.181.2018.09.18.23.30.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Sep 2018 23:30:19 -0700 (PDT) From: Peter Shih To: Subject: [PATCH v3] spi: mediatek: Don't modify spi_transfer when transfer. Date: Wed, 19 Sep 2018 14:29:27 +0800 Message-Id: <20180919062928.238917-1-pihsun@chromium.org> X-Mailer: git-send-email 2.19.0.397.gdd90340f6a-goog In-Reply-To: <20180918161504.GM2471@sirena.org.uk> References: <20180918161504.GM2471@sirena.org.uk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180918_233033_235227_FDDC61B7 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , linux-mediatek@lists.infradead.org, pihsun@chromium.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Mediatek SPI driver modifies some fields (tx_buf, rx_buf, len, tx_dma, rx_dma) of the spi_transfer* passed in when doing transfer_one and in interrupt handler. This is somewhat unexpected, and there are some caller (e.g. Cr50 spi driver) that reuse the spi_transfer for multiple messages. Add a field to record how many bytes have been transferred, and calculate the right len / buffer based on it instead. Signed-off-by: Pi-Hsun Shih --- drivers/spi/spi-mt65xx.c | 37 +++++++++++++++++++++---------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c index 86bf45667a040..3dc31627c6558 100644 --- a/drivers/spi/spi-mt65xx.c +++ b/drivers/spi/spi-mt65xx.c @@ -98,6 +98,7 @@ struct mtk_spi { struct clk *parent_clk, *sel_clk, *spi_clk; struct spi_transfer *cur_transfer; u32 xfer_len; + u32 num_xfered; struct scatterlist *tx_sgl, *rx_sgl; u32 tx_sgl_len, rx_sgl_len; const struct mtk_spi_compatible *dev_comp; @@ -385,6 +386,7 @@ static int mtk_spi_fifo_transfer(struct spi_master *master, mdata->cur_transfer = xfer; mdata->xfer_len = min(MTK_SPI_MAX_FIFO_SIZE, xfer->len); + mdata->num_xfered = 0; mtk_spi_prepare_transfer(master, xfer); mtk_spi_setup_packet(master); @@ -415,6 +417,7 @@ static int mtk_spi_dma_transfer(struct spi_master *master, mdata->tx_sgl_len = 0; mdata->rx_sgl_len = 0; mdata->cur_transfer = xfer; + mdata->num_xfered = 0; mtk_spi_prepare_transfer(master, xfer); @@ -482,7 +485,7 @@ static int mtk_spi_setup(struct spi_device *spi) static irqreturn_t mtk_spi_interrupt(int irq, void *dev_id) { - u32 cmd, reg_val, cnt, remainder; + u32 cmd, reg_val, cnt, remainder, len; struct spi_master *master = dev_id; struct mtk_spi *mdata = spi_master_get_devdata(master); struct spi_transfer *trans = mdata->cur_transfer; @@ -497,36 +500,38 @@ static irqreturn_t mtk_spi_interrupt(int irq, void *dev_id) if (trans->rx_buf) { cnt = mdata->xfer_len / 4; ioread32_rep(mdata->base + SPI_RX_DATA_REG, - trans->rx_buf, cnt); + trans->rx_buf + mdata->num_xfered, cnt); remainder = mdata->xfer_len % 4; if (remainder > 0) { reg_val = readl(mdata->base + SPI_RX_DATA_REG); - memcpy(trans->rx_buf + (cnt * 4), - ®_val, remainder); + memcpy(trans->rx_buf + + mdata->num_xfered + + (cnt * 4), + ®_val, + remainder); } } - trans->len -= mdata->xfer_len; - if (!trans->len) { + mdata->num_xfered += mdata->xfer_len; + if (mdata->num_xfered == trans->len) { spi_finalize_current_transfer(master); return IRQ_HANDLED; } - if (trans->tx_buf) - trans->tx_buf += mdata->xfer_len; - if (trans->rx_buf) - trans->rx_buf += mdata->xfer_len; - - mdata->xfer_len = min(MTK_SPI_MAX_FIFO_SIZE, trans->len); + len = trans->len - mdata->num_xfered; + mdata->xfer_len = min(MTK_SPI_MAX_FIFO_SIZE, len); mtk_spi_setup_packet(master); - cnt = trans->len / 4; - iowrite32_rep(mdata->base + SPI_TX_DATA_REG, trans->tx_buf, cnt); + cnt = len / 4; + iowrite32_rep(mdata->base + SPI_TX_DATA_REG, + trans->tx_buf + mdata->num_xfered, cnt); - remainder = trans->len % 4; + remainder = len % 4; if (remainder > 0) { reg_val = 0; - memcpy(®_val, trans->tx_buf + (cnt * 4), remainder); + memcpy(®_val, + trans->tx_buf + (cnt * 4) + mdata->num_xfered, + remainder); writel(reg_val, mdata->base + SPI_TX_DATA_REG); }