From patchwork Fri Sep 21 11:33:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Willy Wolff X-Patchwork-Id: 10609887 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D23821390 for ; Fri, 21 Sep 2018 11:35:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B39202D9DB for ; Fri, 21 Sep 2018 11:35:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A2E212D9E4; Fri, 21 Sep 2018 11:35:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 449352D9DB for ; Fri, 21 Sep 2018 11:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:Date :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=b5xdukvAj2tv9eLFsu4HVRAG9FN5dZnP7dkbnuAbbCU=; b=WKFCCl4ND3x7cs aU1LHBHxZP3WkyZ1y0908h8ZOPPEBy2ip813m/tl8jAbdduhKOWG4SzmTOqRmnraftNV4tNygiIkt dDzA4Ki8i09537s+4JMk+fbcfTOy0MFnT5vTOOLLKgASBroG2dUgX7V3AoqOetCdg8a43cZlxgpkE t4eU/dyQlP4ReqEckOgsKOddhmD9Qc/KKAF4V8TZkSBylGLBVGpTOobdAV4lPPvEAki61CmLF2Q+w 8oN/x/IZ3O7MDbwxzDQ9H+lXSj8lsNKFqPeNAYbn03D1vcBnEx4iXSuIaStrlxCcuu121ImZeRloP VgbU68mYCzFuiX7p1D3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g3JiW-0007xf-F9; Fri, 21 Sep 2018 11:35:24 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g3Jgt-0006mq-K4 for linux-arm-kernel@lists.infradead.org; Fri, 21 Sep 2018 11:35:19 +0000 Received: by mail-wm1-x342.google.com with SMTP id n11-v6so2878420wmc.2 for ; Fri, 21 Sep 2018 04:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:subject:message-id:mime-version:content-disposition :user-agent; bh=Rwfhn7cN/qx//wJgbq96vWyhsg0cmvYywmwUb3M8DOI=; b=okGL05gekctPsZoofUFLp7/LKbjAZuNxhPLt/+ciZl7zVrnXv2ixQfeDFK5Om0s/WO 7fRHcvB/DpwvsV82agIUuIErAR0u4EqFMThKIffAp/wNV+wrVlKUvTmZaflmRVNyv/qR pJsV1tykkbOm0ryMRDvQyYqmDjU9kSirrgMOO20X9NlyIPE81lJwUrGtbfYkOsIb3aF8 /77ujeLiD/cQqKsH9UMb72vMs/9wpCUjnaie3fDRBm+acF6UWRr59fVr9uLCABc8G6Vs TQNKQEYKXzNhPYLXyJ+uAKuuMNo1wtubQMmQ9O7XE7w9ZvsvvcWI0ZU6lT5kEr/Cpf8K cQKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:subject:message-id:mime-version :content-disposition:user-agent; bh=Rwfhn7cN/qx//wJgbq96vWyhsg0cmvYywmwUb3M8DOI=; b=SR+hvrCHgvQgOGtBBLj4bAmYv5TBFIlj3ZQ35ucOvj80+wPiBzMA0XjKcEPegNGT6M gJNfDzLQFnKcBmXRxoqvOFOePxuYRUqC4bj1z5AY7mhcEM5KuqrKflKYgL6a8TQtyHrg 6jT4kmxk/zXXlOh8vFDB2H7PH8a1uaCUujpKHCCvatxqB34O0W9omtTaZLLV0AHzA7kX 3I9OsHH5aTrxScDBx3PMdc/sy0vvHmgJaEVLdoUOoxVoes2yIOr4WJkUFD4fHawPcdHz SC6QA4Ture6JXzFSlVI1aESKYpztl+Lxcwq+S/AE0EcHB1YashSw/WOL38ZE/y5Z8dVv IAxg== X-Gm-Message-State: APzg51A48pJIIbCZtZpCNaty6u1INFAQ5Uj9t1xkbGaDssmRrK5tYoLz Rl0bBX4Tv+KFSf4LX2MU5yU= X-Google-Smtp-Source: ANB0Vda4XCjShMTg/d25lxWydirM8bWXQRveC9M+Yt0zkgoH3iwW/PfX3NxyxCm8k83abdTt66b9ZA== X-Received: by 2002:a1c:dd05:: with SMTP id u5-v6mr3012704wmg.107.1537529610735; Fri, 21 Sep 2018 04:33:30 -0700 (PDT) Received: from inc028000032.lancs.ac.uk (inc028000032.lancs.ac.uk. [148.88.228.92]) by smtp.gmail.com with ESMTPSA id e7-v6sm6052593wrs.25.2018.09.21.04.33.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Sep 2018 04:33:30 -0700 (PDT) From: Willy Wolff X-Google-Original-From: Willy Wolff Date: Fri, 21 Sep 2018 12:33:29 +0100 To: Rob Herring , Mark Rutland , Kukjin Kim , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: dts: exynos: ordering wrong order tmu_cpu on Odroid-XU3/4 thermal-zones definition Message-ID: <20180921113329.tha5tfrsvdf7dtws@inc028000032.lancs.ac.uk> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180921_043343_698922_AA1B72A4 X-CRM114-Status: GOOD ( 14.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch is to open a discussion about wrong order of tmu_cpu. It seems that tmu_cpu1 correspond to cpu3, and tmu_cpu3 match cpu1. Note, cpu{0|3} in dtsi correspond to cpu{3|7} in linux and are the big cores. By dependencis from exynos5422-odroidxu3-common.dtsi to exynos5800.dtsi -> exynos5420.dtsi, I guess definitions of tmu_cpuX are incorrect. However, changing the address, reg interrupts or clocks would breack other boards depending on it. As I can't test other boards, I've just overload the reference in the thermal-zones node. To reproduce the problem, I provide two scripts: == script_stress: for i in 0 10 20 40 80; do echo $i taskset $i stress -t 10 -c 1 done; == script_read_temp: while true; do for i in 0 1 2 3 4; do echo $i cat /sys/devices/virtual/thermal/thermal_zone$i/temp done; sleep 1 clear done; Signed-off-by: Willy Wolff --- arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index 96e281c0a118..4512ffad2785 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -135,7 +135,8 @@ }; }; cpu1_thermal: cpu1-thermal { - thermal-sensors = <&tmu_cpu1 0>; + // thermal-sensors = <&tmu_cpu1 0>; + thermal-sensors = <&tmu_cpu3 0>; polling-delay-passive = <250>; polling-delay = <0>; trips { @@ -269,7 +270,8 @@ }; }; cpu3_thermal: cpu3-thermal { - thermal-sensors = <&tmu_cpu3 0>; + // thermal-sensors = <&tmu_cpu3 0>; + thermal-sensors = <&tmu_cpu1 0>; polling-delay-passive = <250>; polling-delay = <0>; trips {