From patchwork Mon Oct 15 15:50:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 10642075 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A385C13AD for ; Mon, 15 Oct 2018 15:50:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9281F29D8C for ; Mon, 15 Oct 2018 15:50:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 908EC29DAB; Mon, 15 Oct 2018 15:50:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_MUA_MOZILLA,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F301129DB4 for ; Mon, 15 Oct 2018 15:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:Message-Id:MIME-Version:Date :Subject:From:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: List-Owner; bh=AqBdKNPAM9L97BkmiWVNMx6MXIyg66qnmIk+thlxn+8=; b=tOUe2UcMMXpSRY 11gKNRgIMYxw8tZ2XCuGwfFI0wtDvxj1BRuvqLVQ5tX+C7wOj8E8VRd0hW2H2h36ChMrfTm2CGm/1 vvZF2kjPk3i89HuJbDI6lGPyut7uDiyRjGUtI+vJ3zDmLZJiFWHeNA8m725rRsxdkGi0AVT17t3QE G+yZuMGOBKqs00Pms8Ae+pt3tgC7ZmntpogUak5+lWh0hwu9bepo/VNoGjPYxwcJon5ua3MZUwshU rH4B5sCADY/oXKNzArF8M+f2AlBRRdnPw87GHccWVuaqVP7lTb/p5McRARlo2HvGyIi/6GV0vJmvS 0jHIh4n8FZGc2ibmripg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gC58R-0000oI-DT; Mon, 15 Oct 2018 15:50:23 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gC58N-0008PI-Ly for linux-arm-kernel@lists.infradead.org; Mon, 15 Oct 2018 15:50:22 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181015155003euoutp01727f99e25a24955183efdc630894ab10~d0vZ5VN191628216282euoutp01S for ; Mon, 15 Oct 2018 15:50:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181015155003euoutp01727f99e25a24955183efdc630894ab10~d0vZ5VN191628216282euoutp01S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1539618603; bh=hh1KGglSPI+vJNV3+yd7Y2Prn40j1RzSrpL5baAiIzk=; h=To:Cc:From:Subject:Date:References:From; b=czYMUjDLVcFYW/bw0nWhvrhS+pdl+cM8eikGF24jq54WXG2PABeoEibC/LQ6ozvcM UDRl8GSoTILPASx3ucioIOICU5F7AB9Mx3U8C5B86FQTG2SO0dK8PDDuNLEIJ6e58m nxKWxQ6XSUOROgUaUMFh34wbJCuS/uOIV9Arzagk= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181015155002eucas1p1610decd6fd934c87354180bb0a13e9ce~d0vZHbZtN2443224432eucas1p1Q; Mon, 15 Oct 2018 15:50:02 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id EE.EC.04806.A27B4CB5; Mon, 15 Oct 2018 16:50:02 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20181015155001eucas1p249f539be47eaff0d10ddc74e1f681b37~d0vYKtP7-2027420274eucas1p2g; Mon, 15 Oct 2018 15:50:01 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20181015155001eusmtrp1b6e6ae42b2b79b602c44d006c7047f02~d0vX8JV5c3173531735eusmtrp1M; Mon, 15 Oct 2018 15:50:01 +0000 (GMT) X-AuditID: cbfec7f5-34dff700000012c6-9e-5bc4b72ad01b Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 6A.FB.04128.927B4CB5; Mon, 15 Oct 2018 16:50:01 +0100 (BST) Received: from [106.120.53.102] (unknown [106.120.53.102]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181015155001eusmtip19debc16b922c833233933c1cf37494fc~d0vXkVCAf3225232252eusmtip1C; Mon, 15 Oct 2018 15:50:01 +0000 (GMT) To: Krzysztof Kozlowski From: Bartlomiej Zolnierkiewicz Subject: [PATCH v3] ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms Date: Mon, 15 Oct 2018 17:50:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsWy7djP87pa249EG/RPUrLYOGM9q0X/49fM FufPb2C32PT4GqvF5V1z2CxmnN/HZHFo6l5GB3aPy9cuMntsWtXJ5rF5Sb1H35ZVjB6fN8kF sEZx2aSk5mSWpRbp2yVwZZz/K1bwT7zi26l1TA2MM0S6GDk5JARMJO4c+8/axcjFISSwglHi yK9fjBDOF0aJCyf7WCCcz4wSU7/dY+5i5ABrWTrLCCK+nFFi0YbDTBDOe0aJ/78OMoPMFRHQ lLj+9zvYXGaBV4wSDbP3MoEk2ASsJCa2r2IEsYUFEiSmXD8ONpVFQFXixw8/EFNUIEKi/4w6 SAWvgKDEyZlPWEBsZgF5ie1v5zCDjJQQaGeXuHfsKQtEUZnEiuYtjBD/uEicmv6dCcIWlnh1 fAs7hC0jcXpyDwtE83RGiTe/lkI56xkl1pw5BtVhLXH4+EVWkCuYgT5Yv0sfIuwo8eHgLCaI 7/kkbrwVhDiIT2LStunQQOGV6GgTgqhWk9iwbAMbzNqunSuZIWwPiZZ/p8FOFhKIlbj/4gzL BEaFWUjenIXkzVkINyxgZF7FKJ5aWpybnlpsnJdarlecmFtcmpeul5yfu4kRmGZO/zv+dQfj vj9JhxgFOBiVeHgFeI5EC7EmlhVX5h5ilOBgVhLh7dkEFOJNSaysSi3Kjy8qzUktPsQozcGi JM67bN7GaCGB9MSS1OzU1ILUIpgsEwenVAOj1guTHEefVvuryY2OL29v//Tao/Dw5fNr6j7o vl6YdbwzsF/O5mObc1GSatQL3ZWXLh+Ie5BYtd5mHf/EhdIZcccaqppkMkJea23L7HKo7t2+ cMeNZXw50/o03k3ed0vid3tYfaj8nemTDF2Dpl/6ZfDzzJqlszO/LDnx7nSqlcySKx9FPEqO KbEUZyQaajEXFScCAOFMdYwvAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42I5/e/4XV3N7UeiDWY/krHYOGM9q0X/49fM FufPb2C32PT4GqvF5V1z2CxmnN/HZHFo6l5GB3aPy9cuMntsWtXJ5rF5Sb1H35ZVjB6fN8kF sEbp2RTll5akKmTkF5fYKkUbWhjpGVpa6BmZWOoZGpvHWhmZKunb2aSk5mSWpRbp2yXoZZz/ K1bwT7zi26l1TA2MM0S6GDk4JARMJJbOMupi5OIQEljKKDFr7wlGiLiMxPH1ZV2MnECmsMSf a11sEDVvGSUeb93CCJIQEdCUuP73OytIglngFaPEnonnwRJsAlYSE9tXgdnCAgkSU64fZwax eQXsJA4svcgGsoBFQFXixw8/kLCoQITErYcdLBAlghInZz4Bs5kF1CX+zLvEDGHLS2x/O4d5 AiP/LCRls5CUzUJStoCReRWjSGppcW56brGRXnFibnFpXrpecn7uJkZgNGw79nPLDsaud8GH GAU4GJV4eAV4jkQLsSaWFVfmHmKU4GBWEuHt2QQU4k1JrKxKLcqPLyrNSS0+xGgKdPdEZinR 5HxgpOaVxBuaGppbWBqaG5sbm1koifOeN6iMEhJITyxJzU5NLUgtgulj4uCUamA8WVE2a5NV LZNu+pGdmTpK/8KeH+RYNIlPKMtegvmT64wdsnkrrlY3Re2sW/TpmbzgoxM9FvMPyL5feujP v45K7kXJPK/P31UyaDY9q7iz7YCtS8oDiXWrDl50MWnP2VDqtzZe7InCR/96oc/7/hv7sh66 q/r977WQldm7kibWnPk0kc9iWfZWJZbijERDLeai4kQARxtNMpwCAAA= Message-Id: <20181015155001eucas1p249f539be47eaff0d10ddc74e1f681b37~d0vYKtP7-2027420274eucas1p2g@eucas1p2.samsung.com> X-CMS-MailID: 20181015155001eucas1p249f539be47eaff0d10ddc74e1f681b37 X-Msg-Generator: CA X-RootMTR: 20181015155001eucas1p249f539be47eaff0d10ddc74e1f681b37 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181015155001eucas1p249f539be47eaff0d10ddc74e1f681b37 References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181015_085020_017927_FD927029 X-CRM114-Status: GOOD ( 17.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, Russell King , Kukjin Kim , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG config option) is not working properly (debug messages are not displayed after resume) on Exynos platforms because GPIOs restore code is not implemented. Add PLAT_S3C24XX, ARCH_S3C64XX and ARCH_S5PV210 dependencies to SAMSUNG_PM_DEBUG config option to hide it on Exynos platforms. Then convert Exynos code to not require header (use pr_debug() directly instead of S3C_PMDBG() macro and remove redundant s3c_pm_*() calls). Signed-off-by: Bartlomiej Zolnierkiewicz --- v3: - don't move PM to the line below in Kconfig v2: - convert Exynos code to not require header Should by applied on top of "[PATCH] ARM: EXYNOS: remove no longer needed s3c_pm_check_*() calls". arch/arm/mach-exynos/suspend.c | 14 ++++---------- arch/arm/plat-samsung/Kconfig | 1 + 2 files changed, 5 insertions(+), 10 deletions(-) Index: b/arch/arm/mach-exynos/suspend.c =================================================================== --- a/arch/arm/mach-exynos/suspend.c 2018-10-15 17:39:54.628412461 +0200 +++ b/arch/arm/mach-exynos/suspend.c 2018-10-15 17:39:54.624412461 +0200 @@ -30,8 +30,6 @@ #include #include -#include - #include "common.h" #define REG_TABLE_END (-1U) @@ -490,11 +488,9 @@ static int exynos_suspend_enter(suspend_ { int ret; - s3c_pm_debug_init(); - - S3C_PMDBG("%s: suspending the system...\n", __func__); + pr_debug("%s: suspending the system...\n", __func__); - S3C_PMDBG("%s: wakeup masks: %08x,%08x\n", __func__, + pr_debug("%s: wakeup masks: %08x,%08x\n", __func__, exynos_irqwake_intmask, exynos_get_eint_wake_mask()); if (exynos_irqwake_intmask == -1U @@ -504,7 +500,6 @@ static int exynos_suspend_enter(suspend_ return -EINVAL; } - s3c_pm_save_uarts(); if (pm_data->pm_prepare) pm_data->pm_prepare(); flush_cache_all(); @@ -517,12 +512,11 @@ static int exynos_suspend_enter(suspend_ if (pm_data->pm_resume_prepare) pm_data->pm_resume_prepare(); - s3c_pm_restore_uarts(); - S3C_PMDBG("%s: wakeup stat: %08x\n", __func__, + pr_debug("%s: wakeup stat: %08x\n", __func__, pmu_raw_readl(S5P_WAKEUP_STAT)); - S3C_PMDBG("%s: resuming the system...\n", __func__); + pr_debug("%s: resuming the system...\n", __func__); return 0; } Index: b/arch/arm/plat-samsung/Kconfig =================================================================== --- a/arch/arm/plat-samsung/Kconfig 2018-10-15 17:39:54.628412461 +0200 +++ b/arch/arm/plat-samsung/Kconfig 2018-10-15 17:40:35.416413489 +0200 @@ -239,6 +239,7 @@ comment "Power management" config SAMSUNG_PM_DEBUG bool "Samsung PM Suspend debug" depends on PM && DEBUG_KERNEL + depends on PLAT_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210 depends on DEBUG_EXYNOS_UART || DEBUG_S3C24XX_UART || DEBUG_S3C2410_UART help Say Y here if you want verbose debugging from the PM Suspend and