From patchwork Wed Oct 17 17:09:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Chancellor X-Patchwork-Id: 10645963 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C863E1508 for ; Wed, 17 Oct 2018 17:11:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B2D76288A9 for ; Wed, 17 Oct 2018 17:11:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A5972287C6; Wed, 17 Oct 2018 17:11:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 33DFB287C6 for ; Wed, 17 Oct 2018 17:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=1uE8eyr0QO7pCtLVD7oJ0h6h/mAk85sfURT1L38rtpM=; b=mIGSWiWMnTg5Wl 9nf7CVpKOR4LdQBRWS8euYqsM2dxnhJQhDe5yPtvrugsqjbcd+N1WMH3bV5CuQkgKYSkpKHVnj5vq jDwJBLJ6Wzthqzdj3NANXCXYK/8AdgC68Zv1269OEg4hSOEXNdhuKIO02nWArcRirSpZMoE40jxx0 yKJ79+XvYNtxJVNWx6koz7HM+LhQMhZ+AkZPqUBNqov7pI9WhwqhlczFRWc6aTJ13IsIZ11V/KL+1 N+NDefpb/eMFWKcKCY3LyKi3tSw1lVbiWNLZAFHDMCVFly6XjhnPXzszyk2y1fWShXj7H9rcOFooG Qk+wv2nIq/p1HMS0ndyQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gCpM2-000164-Ov; Wed, 17 Oct 2018 17:11:30 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gCpLf-0000px-Lx for linux-arm-kernel@lists.infradead.org; Wed, 17 Oct 2018 17:11:16 +0000 Received: by mail-wm1-x343.google.com with SMTP id y11-v6so2768294wma.3 for ; Wed, 17 Oct 2018 10:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v03iK3x/plWm5Rp2GkHTWEKr5Z/RFjW88mQS4/6o62c=; b=DxtTs02efnuzZgcun0XYIMnbYd4502k+bj2hNVsoDdQR84FS0AjrPatM990wsoDfjo 9Q36etgwMCtgxo61NDNQj4AsdK+1/Q8LE1071vPl2fEBMrS8PkFp/wpKINDe1xI+bK8m mCDs99nCRToHPSd94iyTgcek4GbWKHXf60Wxcf8HGZDoF73ndzoDNzPJvom3FbSXJZgz ZmufODVijtdDBr6BjJyGzywuD/cbFOzEZJhdkOFSBweRS45GnqUcPJE7bznjuSPDXwdt Z9SLw4NGAwjvy8+VIQKlYEjnBzcqSMj4k/CnrrabzNhncP6AGrEsZ94bj7q1TsFR1QNN emug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v03iK3x/plWm5Rp2GkHTWEKr5Z/RFjW88mQS4/6o62c=; b=oeN5L24EWdUPbBbrv0AHUvPiW+H4fijT35Zuh1tvVM2CUbrdbXXIndIT0j1WK3APwJ 9dGrBwq2F9pgvEQO0VWWZehMCnZE8ItRDEiMuAgI8R+F0p0qU6QCD5psRajSd6NymYcs dvAgTtywBIYikdKa0UEp9l94xxPszdbkiBD6L8eU7YjL84m14ejgDcc1J0pFyNppKQRz GdN4ze+a8uSb8EyimlFiz05Vis6lCDyV9QzAi9zh3JTCfTDV696BNvjV+Mlsp6ydc+M9 PGHmxbAnBnrIxkdcbaAhH2zQ1oqXhDjcz97eoKeSCaC9HZMJzawHkDVNejhw7JEK6Xi9 ThhA== X-Gm-Message-State: ABuFfogtH8DfVdr2vUMFEZ7pxSLgwF0XXEjF9X1bP5kKs/gQblyQIqe/ qrUmaFd/8nm+MC6YWWncOb0= X-Google-Smtp-Source: ACcGV61sfXfTzMzcZbtZzgVmEIR6KfxdqejpnXXX/iaGwn2mcuS7szyCfY0P0BDXmrbsTh83QhePow== X-Received: by 2002:a1c:1a52:: with SMTP id a79-v6mr3752892wma.119.1539796254873; Wed, 17 Oct 2018 10:10:54 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:10b:24a5::2]) by smtp.gmail.com with ESMTPSA id t3-v6sm16371009wru.47.2018.10.17.10.10.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Oct 2018 10:10:53 -0700 (PDT) From: Nathan Chancellor To: Nicolas Ferre , Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH] misc: atmel-ssc: Fix section annotation on atmel_ssc_get_driver_data Date: Wed, 17 Oct 2018 10:09:02 -0700 Message-Id: <20181017170901.13119-1-natechancellor@gmail.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181017_101107_781460_B463B25B X-CRM114-Status: GOOD ( 15.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nathan Chancellor , Alexandre Belloni , Ludovic Desroches , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP After building the kernel with Clang, the following section mismatch warning appears: WARNING: vmlinux.o(.text+0x3bf19a6): Section mismatch in reference from the function ssc_probe() to the function .init.text:atmel_ssc_get_driver_data() The function ssc_probe() references the function __init atmel_ssc_get_driver_data(). This is often because ssc_probe lacks a __init annotation or the annotation of atmel_ssc_get_driver_data is wrong. Remove __init from atmel_ssc_get_driver_data to get rid of the mismatch. Signed-off-by: Nathan Chancellor Reviewed-by: Alexandre Belloni --- Alternatively, ssc_probe could be marked as __init, I don't think there is any way for the probe to defer. I decided to go with the more conservative option first but I'm happy to respin if necessary. Thanks! drivers/misc/atmel-ssc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c index b2a0340f277e..d8e3cc2dc747 100644 --- a/drivers/misc/atmel-ssc.c +++ b/drivers/misc/atmel-ssc.c @@ -132,7 +132,7 @@ static const struct of_device_id atmel_ssc_dt_ids[] = { MODULE_DEVICE_TABLE(of, atmel_ssc_dt_ids); #endif -static inline const struct atmel_ssc_platform_data * __init +static inline const struct atmel_ssc_platform_data * atmel_ssc_get_driver_data(struct platform_device *pdev) { if (pdev->dev.of_node) {