From patchwork Tue Oct 30 22:11:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10661737 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BC96A14DE for ; Tue, 30 Oct 2018 22:28:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB7162A9C0 for ; Tue, 30 Oct 2018 22:28:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9D9DA2AA8D; Tue, 30 Oct 2018 22:28:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0F8772A9C0 for ; Tue, 30 Oct 2018 22:28:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Yl3wxLMMFhZFqyYALCoxdlEw8U03YhZ/dM+TRCUuWA=; b=Bn0fY8hkJ9EdFv /yxKX8shMlX1ChN92AS8Fsq4ngvSSW/sHozA84EpLFpPhX69uMjO5DEOhI2+u5lortT3Xdl8xVWM7 Q8Gv6NeVGk2ltvaeOtHh+hkHgvvjHnOLtFs1n1ZCN4MZ2Ub/PFaj/26SH967RPqyX7t+tolwxhY9+ dRzNohCNNrOZRPiYHtq9KzTOotpwKHJ74QeuRYfE7fBf5bfrxFgWJpD24BaUlpiwuK1X/i9B/3CYT riALnqP+agU8ZlaeQqyQjPnXuEW01zGSEJeVT5HXHrYdt5/XWiQBXWJlAnTEmnGT+6Maug09akxbX hs/A4nut5nMuSIwzhX9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gHcUR-0006vN-BN; Tue, 30 Oct 2018 22:27:59 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gHcEw-00078g-3Q for linux-arm-kernel@lists.infradead.org; Tue, 30 Oct 2018 22:12:02 +0000 Received: by mail-pf1-x441.google.com with SMTP id e22-v6so3523989pfn.8 for ; Tue, 30 Oct 2018 15:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=G4It3xDRhjbwJBDZhyOLMXPJlT41mX/wrMU8U1COu/w=; b=J7kpoqW4nCOMflV/GPpFHw3wbowwLlSw5cHb8BwCL0tjDKLS2pX+uBdYNdhSv5qJeR YIFqcoisweNYAEye7pDR4UbDTnN4qdVcG62oRk25fXvCZc6XVhIDzWTdT2NTPgeOBPqs 46XOtbWk86TJzDnegELyy5ty0b8CDo42RpUt8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=G4It3xDRhjbwJBDZhyOLMXPJlT41mX/wrMU8U1COu/w=; b=cJipnbqnWtpeEGAtbiHKMDBcMlYJxWAc47FiYnQ24TLE6VEZtgLDS5i5tjuiiy/2WU TkXqsa4F2cPDyG8qV8ekWHI/ZVcQprrXTzLF96fhl8aJXOWxryksuebycKjxZbM19KQN qmIoGHHS2VwHyK0c3FRD4+6QOfMSXIFRa/zRCj08Z/4ITrZSFidLJUWuySEm0IpzZjpR zGlxOjZjaGkt9yQGd2ZE+B9RIwLRBlEuhZ55QfmOuqmZfF7ezbMqVAMxidk5OCwOhrVn TR0nNlHFz17bf50grYhFPIuTzCAAt/AdmRbeW+p/1qe/tn7zwIuf3edJlOdcbJUzS+Xo CDCA== X-Gm-Message-State: AGRZ1gLtl2mySgZqwCRRaZj6NijHlKbYgAIucXxpu2SrnXyZ5skjhXkI X3/sxR5aGImiFB9lP1hAKAYrGw== X-Google-Smtp-Source: AJdET5dD/X8oQn38qFkhnjnryX1IEDPvPKRA/R7wBL1aiw2Hj0b6uuIZql51K1rGVa5QRIGGqc0Iiw== X-Received: by 2002:a65:40c5:: with SMTP id u5mr516665pgp.46.1540937507248; Tue, 30 Oct 2018 15:11:47 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id b11-v6sm12844491pgi.10.2018.10.30.15.11.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Oct 2018 15:11:46 -0700 (PDT) From: Douglas Anderson To: Greg Kroah-Hartman , Jiri Slaby Subject: [PATCH v2 4/5] serial: core: Include console.h from serial_core.h Date: Tue, 30 Oct 2018 15:11:06 -0700 Message-Id: <20181030221107.79758-5-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181030221107.79758-1-dianders@chromium.org> References: <20181030221107.79758-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181030_151158_577349_B8F19196 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dan.carpenter@oracle.com, vigneshr@ti.com, linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, linux-arm-msm@vger.kernel.org, Douglas Anderson , tony@atomide.com, joel@jms.id.au, linux-serial@vger.kernel.org, andriy.shevchenko@linux.intel.com, linux-arm-kernel@lists.infradead.org, jk@ozlabs.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In the static inline function uart_handle_break() in serial_core.h we dereference port->cons. That gives an error unless console.h is also included. This error hasn't shown up till now because everyone who has defined SUPPORT_SYSRQ has also included console.h, but it's a bit ugly to make this requirement. Let's make the include explicit. Signed-off-by: Douglas Anderson --- include/linux/serial_core.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h index 3460b15a2607..ff9d0ee32f11 100644 --- a/include/linux/serial_core.h +++ b/include/linux/serial_core.h @@ -22,6 +22,7 @@ #include #include +#include #include #include #include