From patchwork Tue Nov 20 17:19:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Anholt X-Patchwork-Id: 10690955 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C2C871709 for ; Tue, 20 Nov 2018 17:30:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A92EC2ACCB for ; Tue, 20 Nov 2018 17:30:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9CD712ACD3; Tue, 20 Nov 2018 17:30:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BB1CD2ACCB for ; Tue, 20 Nov 2018 17:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9/4Ou9DGpd02tCUvLLi7Z4RtOI64ekB1uYHtepwK//4=; b=eR2F/JMQYUl83q W29kfjszJ5C/omNQEo4bPsQmuttA9Xx4hGpu36Ie3syMAc5MRJm1lHJTPyJfMOf59qT87vbIq6TZP PoYZSkYfiE8t/ZkfAryb0Iu2/8rl3WzJcFkBGhQ3eWjuqSQlAVKfq1xU6EeQO/Q9qAlTiO2rsrUlh GYi6q8Tb1DGe0BIcMUBw1K9i3z4wvoZD7pVNAbcseOMU7jdV2OSnNDNbAPNHR2v3a53R12e7c6582 pkQd1S/kXWpVyn1Dqj/Y+WhpzCRg/MflTMOIc8sUFYHumq+uel1pSGBrR1fbLOa0PfdjQihWgdQeF WXZeGOS+68z+M8HtKdMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gP9rG-0006oe-Rx; Tue, 20 Nov 2018 17:30:42 +0000 Received: from anholt.net ([50.246.234.109]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gP9qH-0004Jj-QO; Tue, 20 Nov 2018 17:29:53 +0000 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id EEFC210A165F; Tue, 20 Nov 2018 09:20:09 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CIIWyPnsIOTZ; Tue, 20 Nov 2018 09:20:06 -0800 (PST) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 5A31B10A15EC; Tue, 20 Nov 2018 09:20:01 -0800 (PST) Received: by eliezer.anholt.net (Postfix, from userid 1000) id 100DB2FE1FE8; Tue, 20 Nov 2018 09:20:00 -0800 (PST) From: Eric Anholt To: Florian Fainelli , Rob Herring , Mark Rutland , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org Subject: [PATCH 2/8] soc: bcm: bcm2835-pm: Rename the driver to its new "PM" name. Date: Tue, 20 Nov 2018 09:19:54 -0800 Message-Id: <20181120172000.15102-3-eric@anholt.net> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181120172000.15102-1-eric@anholt.net> References: <20181120172000.15102-1-eric@anholt.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181120_092942_215256_FF6C45A3 X-CRM114-Status: GOOD ( 17.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , linux-kernel@vger.kernel.org, Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This is the name of the block we're controlling. Signed-off-by: Eric Anholt --- drivers/soc/bcm/bcm2835-pm.c | 92 ++++++++++++++++++------------------ 1 file changed, 47 insertions(+), 45 deletions(-) diff --git a/drivers/soc/bcm/bcm2835-pm.c b/drivers/soc/bcm/bcm2835-pm.c index ed05514cc2dc..ca37145e4e40 100644 --- a/drivers/soc/bcm/bcm2835-pm.c +++ b/drivers/soc/bcm/bcm2835-pm.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0+ /* - * Watchdog driver for Broadcom BCM2835 + * PM driver for Broadcom BCM2835 * * "bcm2708_wdog" driver written by Luke Diamand that was obtained from * branch "rpi-3.6.y" of git://github.com/raspberrypi/linux.git was used @@ -42,7 +42,7 @@ #define SECS_TO_WDOG_TICKS(x) ((x) << 16) #define WDOG_TICKS_TO_SECS(x) ((x) >> 16) -struct bcm2835_wdt { +struct bcm2835_pm { void __iomem *base; spinlock_t lock; }; @@ -50,60 +50,60 @@ struct bcm2835_wdt { static unsigned int heartbeat; static bool nowayout = WATCHDOG_NOWAYOUT; -static bool bcm2835_wdt_is_running(struct bcm2835_wdt *wdt) +static bool bcm2835_wdt_is_running(struct bcm2835_pm *pm) { uint32_t cur; - cur = readl(wdt->base + PM_RSTC); + cur = readl(pm->base + PM_RSTC); return !!(cur & PM_RSTC_WRCFG_FULL_RESET); } static int bcm2835_wdt_start(struct watchdog_device *wdog) { - struct bcm2835_wdt *wdt = watchdog_get_drvdata(wdog); + struct bcm2835_pm *pm = watchdog_get_drvdata(wdog); uint32_t cur; unsigned long flags; - spin_lock_irqsave(&wdt->lock, flags); + spin_lock_irqsave(&pm->lock, flags); writel_relaxed(PM_PASSWORD | (SECS_TO_WDOG_TICKS(wdog->timeout) & - PM_WDOG_TIME_SET), wdt->base + PM_WDOG); - cur = readl_relaxed(wdt->base + PM_RSTC); + PM_WDOG_TIME_SET), pm->base + PM_WDOG); + cur = readl_relaxed(pm->base + PM_RSTC); writel_relaxed(PM_PASSWORD | (cur & PM_RSTC_WRCFG_CLR) | - PM_RSTC_WRCFG_FULL_RESET, wdt->base + PM_RSTC); + PM_RSTC_WRCFG_FULL_RESET, pm->base + PM_RSTC); - spin_unlock_irqrestore(&wdt->lock, flags); + spin_unlock_irqrestore(&pm->lock, flags); return 0; } static int bcm2835_wdt_stop(struct watchdog_device *wdog) { - struct bcm2835_wdt *wdt = watchdog_get_drvdata(wdog); + struct bcm2835_pm *pm = watchdog_get_drvdata(wdog); - writel_relaxed(PM_PASSWORD | PM_RSTC_RESET, wdt->base + PM_RSTC); + writel_relaxed(PM_PASSWORD | PM_RSTC_RESET, pm->base + PM_RSTC); return 0; } static unsigned int bcm2835_wdt_get_timeleft(struct watchdog_device *wdog) { - struct bcm2835_wdt *wdt = watchdog_get_drvdata(wdog); + struct bcm2835_pm *pm = watchdog_get_drvdata(wdog); - uint32_t ret = readl_relaxed(wdt->base + PM_WDOG); + uint32_t ret = readl_relaxed(pm->base + PM_WDOG); return WDOG_TICKS_TO_SECS(ret & PM_WDOG_TIME_SET); } -static void __bcm2835_restart(struct bcm2835_wdt *wdt) +static void __bcm2835_restart(struct bcm2835_pm *pm) { u32 val; /* use a timeout of 10 ticks (~150us) */ - writel_relaxed(10 | PM_PASSWORD, wdt->base + PM_WDOG); - val = readl_relaxed(wdt->base + PM_RSTC); + writel_relaxed(10 | PM_PASSWORD, pm->base + PM_WDOG); + val = readl_relaxed(pm->base + PM_RSTC); val &= PM_RSTC_WRCFG_CLR; val |= PM_PASSWORD | PM_RSTC_WRCFG_FULL_RESET; - writel_relaxed(val, wdt->base + PM_RSTC); + writel_relaxed(val, pm->base + PM_RSTC); /* No sleeping, possibly atomic. */ mdelay(1); @@ -112,9 +112,9 @@ static void __bcm2835_restart(struct bcm2835_wdt *wdt) static int bcm2835_restart(struct watchdog_device *wdog, unsigned long action, void *data) { - struct bcm2835_wdt *wdt = watchdog_get_drvdata(wdog); + struct bcm2835_pm *pm = watchdog_get_drvdata(wdog); - __bcm2835_restart(wdt); + __bcm2835_restart(pm); return 0; } @@ -151,7 +151,7 @@ static void bcm2835_power_off(void) struct device_node *np = of_find_compatible_node(NULL, NULL, "brcm,bcm2835-pm-wdt"); struct platform_device *pdev = of_find_device_by_node(np); - struct bcm2835_wdt *wdt = platform_get_drvdata(pdev); + struct bcm2835_pm *pm = platform_get_drvdata(pdev); u32 val; /* @@ -159,38 +159,39 @@ static void bcm2835_power_off(void) * from the normal (full) reset. bootcode.bin will not reboot after a * hard reset. */ - val = readl_relaxed(wdt->base + PM_RSTS); + val = readl_relaxed(pm->base + PM_RSTS); val |= PM_PASSWORD | PM_RSTS_RASPBERRYPI_HALT; - writel_relaxed(val, wdt->base + PM_RSTS); + writel_relaxed(val, pm->base + PM_RSTS); /* Continue with normal reset mechanism */ - __bcm2835_restart(wdt); + __bcm2835_restart(pm); } -static int bcm2835_wdt_probe(struct platform_device *pdev) +static int bcm2835_pm_probe(struct platform_device *pdev) { struct resource *res; struct device *dev = &pdev->dev; - struct bcm2835_wdt *wdt; + struct bcm2835_pm *pm; int err; - wdt = devm_kzalloc(dev, sizeof(struct bcm2835_wdt), GFP_KERNEL); - if (!wdt) + pm = devm_kzalloc(dev, sizeof(struct bcm2835_pm), GFP_KERNEL); + if (!pm) return -ENOMEM; - platform_set_drvdata(pdev, wdt); + platform_set_drvdata(pdev, pm); - spin_lock_init(&wdt->lock); + spin_lock_init(&pm->lock); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - wdt->base = devm_ioremap_resource(dev, res); - if (IS_ERR(wdt->base)) - return PTR_ERR(wdt->base); + pm->base = devm_ioremap_resource(dev, res); + if (IS_ERR(pm->base)) + return PTR_ERR(pm->base); - watchdog_set_drvdata(&bcm2835_wdt_wdd, wdt); +#if defined(CONFIG_WATCHDOG_CORE) + watchdog_set_drvdata(&bcm2835_wdt_wdd, pm); watchdog_init_timeout(&bcm2835_wdt_wdd, heartbeat, dev); watchdog_set_nowayout(&bcm2835_wdt_wdd, nowayout); bcm2835_wdt_wdd.parent = dev; - if (bcm2835_wdt_is_running(wdt)) { + if (bcm2835_wdt_is_running(pm)) { /* * The currently active timeout value (set by the * bootloader) may be different from the module @@ -210,6 +211,7 @@ static int bcm2835_wdt_probe(struct platform_device *pdev) dev_err(dev, "Failed to register watchdog device"); return err; } +#endif if (pm_power_off == NULL) pm_power_off = bcm2835_power_off; @@ -218,7 +220,7 @@ static int bcm2835_wdt_probe(struct platform_device *pdev) return 0; } -static int bcm2835_wdt_remove(struct platform_device *pdev) +static int bcm2835_pm_remove(struct platform_device *pdev) { if (pm_power_off == bcm2835_power_off) pm_power_off = NULL; @@ -226,21 +228,21 @@ static int bcm2835_wdt_remove(struct platform_device *pdev) return 0; } -static const struct of_device_id bcm2835_wdt_of_match[] = { +static const struct of_device_id bcm2835_pm_of_match[] = { { .compatible = "brcm,bcm2835-pm-wdt", }, {}, }; -MODULE_DEVICE_TABLE(of, bcm2835_wdt_of_match); +MODULE_DEVICE_TABLE(of, bcm2835_pm_of_match); -static struct platform_driver bcm2835_wdt_driver = { - .probe = bcm2835_wdt_probe, - .remove = bcm2835_wdt_remove, +static struct platform_driver bcm2835_pm_driver = { + .probe = bcm2835_pm_probe, + .remove = bcm2835_pm_remove, .driver = { - .name = "bcm2835-wdt", - .of_match_table = bcm2835_wdt_of_match, + .name = "bcm2835-pm", + .of_match_table = bcm2835_pm_of_match, }, }; -module_platform_driver(bcm2835_wdt_driver); +module_platform_driver(bcm2835_pm_driver); module_param(heartbeat, uint, 0); MODULE_PARM_DESC(heartbeat, "Initial watchdog heartbeat in seconds"); @@ -250,5 +252,5 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); MODULE_AUTHOR("Lubomir Rintel "); -MODULE_DESCRIPTION("Driver for Broadcom BCM2835 watchdog timer"); +MODULE_DESCRIPTION("Driver for Broadcom BCM2835 PM/WDT"); MODULE_LICENSE("GPL");