| Message ID | 20181219101844.6362-1-horia.geanta@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Revert "arm64: defconfig: Enable FSL_MC_BUS and FSL_MC_DPIO" | expand |
On Wed, Dec 19, 2018 at 11:18 AM Horia Geantă <horia.geanta@nxp.com> wrote: > > This reverts commit d9678adbe733a770428a98651beaa2817d503ed3. > > Received below report from Stefan. > Revert the commit until CAAM driver dependency cycles are fixed. > > this patch in next-20181214 breaks "make modules_install" for > arm64/defconfig on my Ubuntu machine: > > DEPMOD 4.20.0-rc6-next-20181214 > depmod: ERROR: Found 6 modules in dependency cycles! > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio > depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error > depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc > > Reported-by: Stefan Wahren <stefan.wahren@i2se.com> > Signed-off-by: Horia Geantă <horia.geanta@nxp.com> I've applied the revert, but I think there is still a problem, since anyone could manually enable those options and should not see those cycles in the module dependencies. Horia, can you have a look at what caused that and how to fix it? It's probably a commit in the caam drivers. I have also created a patch to address a problem with that driver but forgot to send that out, it might fix this one as well, see my follow-up patch "crypto: caam/qi2 - add a CRYPTO_DEV_FSL_CAAM dependency". Arnd
On 12/20/2018 5:28 PM, Arnd Bergmann wrote: > On Wed, Dec 19, 2018 at 11:18 AM Horia Geantă <horia.geanta@nxp.com> wrote: >> >> This reverts commit d9678adbe733a770428a98651beaa2817d503ed3. >> >> Received below report from Stefan. >> Revert the commit until CAAM driver dependency cycles are fixed. >> >> this patch in next-20181214 breaks "make modules_install" for >> arm64/defconfig on my Ubuntu machine: >> >> DEPMOD 4.20.0-rc6-next-20181214 >> depmod: ERROR: Found 6 modules in dependency cycles! >> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc >> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio >> depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam >> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error >> depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc >> >> Reported-by: Stefan Wahren <stefan.wahren@i2se.com> >> Signed-off-by: Horia Geantă <horia.geanta@nxp.com> > > I've applied the revert, but I think there is still a problem, since > anyone could manually enable those options and should not > see those cycles in the module dependencies. > Agree, root cause has to be fixed. > Horia, can you have a look at what caused that and how to fix it? > It's probably a commit in the caam drivers. I have also created > a patch to address a problem with that driver but forgot > to send that out, it might fix this one as well, see my follow-up > patch "crypto: caam/qi2 - add a CRYPTO_DEV_FSL_CAAM > dependency". > Yes, will continue discussion there. Thanks, Horia
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 989f51bb1bd4..d0724d4e0546 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -200,7 +200,6 @@ CONFIG_DMA_CMA=y CONFIG_CMA_SIZE_MBYTES=32 CONFIG_HISILICON_LPC=y CONFIG_SIMPLE_PM_BUS=y -CONFIG_FSL_MC_BUS=y CONFIG_MTD=y CONFIG_MTD_BLOCK=y CONFIG_MTD_M25P80=y @@ -644,7 +643,6 @@ CONFIG_RPMSG_QCOM_GLINK_RPM=y CONFIG_RPMSG_QCOM_GLINK_SMEM=m CONFIG_RPMSG_QCOM_SMD=y CONFIG_RASPBERRYPI_POWER=y -CONFIG_FSL_MC_DPIO=m CONFIG_QCOM_COMMAND_DB=y CONFIG_QCOM_GENI_SE=y CONFIG_QCOM_GLINK_SSR=m @@ -737,7 +735,6 @@ CONFIG_NLS_ISO8859_1=y CONFIG_SECURITY=y CONFIG_CRYPTO_ECHAINIV=y CONFIG_CRYPTO_ANSI_CPRNG=y -CONFIG_CRYPTO_DEV_FSL_DPAA2_CAAM=m CONFIG_PRINTK_TIME=y CONFIG_DEBUG_INFO=y CONFIG_DEBUG_FS=y
This reverts commit d9678adbe733a770428a98651beaa2817d503ed3. Received below report from Stefan. Revert the commit until CAAM driver dependency cycles are fixed. this patch in next-20181214 breaks "make modules_install" for arm64/defconfig on my Ubuntu machine: DEPMOD 4.20.0-rc6-next-20181214 depmod: ERROR: Found 6 modules in dependency cycles! depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> authenc depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> fsl_mc_dpio depmod: ERROR: Cycle detected: dpaa2_caam -> caamhash_desc -> dpaa2_caam depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> error depmod: ERROR: Cycle detected: caamalg_desc -> dpaa2_caam -> caamhash_desc -> caamalg_desc Reported-by: Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by: Horia Geantă <horia.geanta@nxp.com> --- arch/arm64/configs/defconfig | 3 --- 1 file changed, 3 deletions(-)