| Message ID | 20181231181209.28695-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Commit | 091bb549f7722723b284f63ac665e2aedcf9dec9 |
| Headers | show |
| Series | [v2] ARM: Remove '-p' from LDFLAGS | expand |
On Mon, 31 Dec 2018, Nathan Chancellor wrote: > This option is not supported by lld: > > ld.lld: error: unknown argument: -p > > This has been a no-op in binutils since 2004 (see commit dea514f51da1 in > that tree). Given that the lowest officially supported of binutils for > the kernel is 2.20, which was released in 2009, nobody needs this flag > around so just remove it. Commit 1a381d4a0a9a ("arm64: remove no-op -p > linker flag") did the same for arm64. > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Acked-by: Nicolas Pitre <nico@linaro.org> > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > Reviewed-by: Stefan Agner <stefan@agner.ch> You may now submit your patch to RMK's patch system: http://www.arm.linux.org.uk/developer/patches/ > --- > > v1 -> v2: > > * Collect tags > > * Remove an additional occurence of '-p' in the bootp Makefile, thank > you to Stefan for pointing it out > > * Drop patch 2/2, it will be fixed properly in lld: https://reviews.llvm.org/D55505 > > arch/arm/Makefile | 2 +- > arch/arm/boot/bootp/Makefile | 2 +- > arch/arm/boot/compressed/Makefile | 2 -- > 3 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index 0436002d5091..1d48c8ed5f89 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -10,7 +10,7 @@ > # > # Copyright (C) 1995-2001 by Russell King > > -LDFLAGS_vmlinux :=-p --no-undefined -X --pic-veneer > +LDFLAGS_vmlinux := --no-undefined -X --pic-veneer > ifeq ($(CONFIG_CPU_ENDIAN_BE8),y) > LDFLAGS_vmlinux += --be8 > KBUILD_LDFLAGS_MODULE += --be8 > diff --git a/arch/arm/boot/bootp/Makefile b/arch/arm/boot/bootp/Makefile > index 83e1a076a5d6..981a8d03f064 100644 > --- a/arch/arm/boot/bootp/Makefile > +++ b/arch/arm/boot/bootp/Makefile > @@ -8,7 +8,7 @@ > > GCOV_PROFILE := n > > -LDFLAGS_bootp :=-p --no-undefined -X \ > +LDFLAGS_bootp := --no-undefined -X \ > --defsym initrd_phys=$(INITRD_PHYS) \ > --defsym params_phys=$(PARAMS_PHYS) -T > AFLAGS_initrd.o :=-DINITRD=\"$(INITRD)\" > diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile > index 01bf2585a0fa..ecfa4ca320a7 100644 > --- a/arch/arm/boot/compressed/Makefile > +++ b/arch/arm/boot/compressed/Makefile > @@ -132,8 +132,6 @@ endif > ifeq ($(CONFIG_CPU_ENDIAN_BE8),y) > LDFLAGS_vmlinux += --be8 > endif > -# ? > -LDFLAGS_vmlinux += -p > # Report unresolved symbol references > LDFLAGS_vmlinux += --no-undefined > # Delete all temporary local symbols > -- > 2.20.1 > >
On Sat, Jan 5, 2019 at 8:34 AM Nicolas Pitre <nicolas.pitre@linaro.org> wrote: > > On Mon, 31 Dec 2018, Nathan Chancellor wrote: > > > This option is not supported by lld: > > > > ld.lld: error: unknown argument: -p > > > > This has been a no-op in binutils since 2004 (see commit dea514f51da1 in > > that tree). Given that the lowest officially supported of binutils for > > the kernel is 2.20, which was released in 2009, nobody needs this flag > > around so just remove it. Commit 1a381d4a0a9a ("arm64: remove no-op -p > > linker flag") did the same for arm64. > > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Acked-by: Nicolas Pitre <nico@linaro.org> > > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > Reviewed-by: Stefan Agner <stefan@agner.ch> > > You may now submit your patch to RMK's patch system: > http://www.arm.linux.org.uk/developer/patches/ http://www.arm.linux.org.uk/developer/patches/info.php """ Mailing your patch. Mail it to patches@armlinux.org.uk and check the reply. """ *sighs in GitHub*
diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 0436002d5091..1d48c8ed5f89 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -10,7 +10,7 @@ # # Copyright (C) 1995-2001 by Russell King -LDFLAGS_vmlinux :=-p --no-undefined -X --pic-veneer +LDFLAGS_vmlinux := --no-undefined -X --pic-veneer ifeq ($(CONFIG_CPU_ENDIAN_BE8),y) LDFLAGS_vmlinux += --be8 KBUILD_LDFLAGS_MODULE += --be8 diff --git a/arch/arm/boot/bootp/Makefile b/arch/arm/boot/bootp/Makefile index 83e1a076a5d6..981a8d03f064 100644 --- a/arch/arm/boot/bootp/Makefile +++ b/arch/arm/boot/bootp/Makefile @@ -8,7 +8,7 @@ GCOV_PROFILE := n -LDFLAGS_bootp :=-p --no-undefined -X \ +LDFLAGS_bootp := --no-undefined -X \ --defsym initrd_phys=$(INITRD_PHYS) \ --defsym params_phys=$(PARAMS_PHYS) -T AFLAGS_initrd.o :=-DINITRD=\"$(INITRD)\" diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile index 01bf2585a0fa..ecfa4ca320a7 100644 --- a/arch/arm/boot/compressed/Makefile +++ b/arch/arm/boot/compressed/Makefile @@ -132,8 +132,6 @@ endif ifeq ($(CONFIG_CPU_ENDIAN_BE8),y) LDFLAGS_vmlinux += --be8 endif -# ? -LDFLAGS_vmlinux += -p # Report unresolved symbol references LDFLAGS_vmlinux += --no-undefined # Delete all temporary local symbols
This option is not supported by lld: ld.lld: error: unknown argument: -p This has been a no-op in binutils since 2004 (see commit dea514f51da1 in that tree). Given that the lowest officially supported of binutils for the kernel is 2.20, which was released in 2009, nobody needs this flag around so just remove it. Commit 1a381d4a0a9a ("arm64: remove no-op -p linker flag") did the same for arm64. Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Acked-by: Nicolas Pitre <nico@linaro.org> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Stefan Agner <stefan@agner.ch> --- v1 -> v2: * Collect tags * Remove an additional occurence of '-p' in the bootp Makefile, thank you to Stefan for pointing it out * Drop patch 2/2, it will be fixed properly in lld: https://reviews.llvm.org/D55505 arch/arm/Makefile | 2 +- arch/arm/boot/bootp/Makefile | 2 +- arch/arm/boot/compressed/Makefile | 2 -- 3 files changed, 2 insertions(+), 4 deletions(-)