Message ID | 20190115110145.11017-2-l.stach@pengutronix.de (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v2,1/2] arm64: dts: imx8mq: add GPC power domains | expand |
On Tue, Jan 15, 2019 at 12:01:45PM +0100, Lucas Stach wrote: > The ATF on the i.MX8MQ device disables all non-essential power > domains. For correct on-SoC peripheral operation we need both > the power domain driver and generic domains, so device driver > probe gets ordered behind the power domain controller driver. > > Select those options, as those being absent can lead to very > hard to debug failures. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > arch/arm64/Kconfig.platforms | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 251ecf34cb02..bb0d78d1ca4d 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -146,6 +146,9 @@ config ARCH_MXC > bool "ARMv8 based NXP i.MX SoC family" > select ARM64_ERRATUM_843419 > select ARM64_ERRATUM_845719 > + select CONFIG_PM select PM > + select PM_GENERIC_DOMAINS > + select IMX_GPCV2_PM_DOMAINS We would like to keep the list alphabetically sorted. Shawn > help > This enables support for the ARMv8 based SoCs in the > NXP i.MX family. > -- > 2.20.1 >
> -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > Sent: Wednesday, January 16, 2019 11:17 AM ... > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > --- > > arch/arm64/Kconfig.platforms | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/Kconfig.platforms > > b/arch/arm64/Kconfig.platforms index 251ecf34cb02..bb0d78d1ca4d > 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -146,6 +146,9 @@ config ARCH_MXC > > bool "ARMv8 based NXP i.MX SoC family" > > select ARM64_ERRATUM_843419 > > select ARM64_ERRATUM_845719 > > + select CONFIG_PM > > select PM > > > + select PM_GENERIC_DOMAINS > > + select IMX_GPCV2_PM_DOMAINS > > We would like to keep the list alphabetically sorted. Should these two options to through defconfig according to the former suggestion From arm soc maintainer? Put them here also means there's no chance to disable it for other imx v8 socs. Regards Dong Aisheng > > Shawn > > > help > > This enables support for the ARMv8 based SoCs in the > > NXP i.MX family. > > -- > > 2.20.1 > >
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 251ecf34cb02..bb0d78d1ca4d 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -146,6 +146,9 @@ config ARCH_MXC bool "ARMv8 based NXP i.MX SoC family" select ARM64_ERRATUM_843419 select ARM64_ERRATUM_845719 + select CONFIG_PM + select PM_GENERIC_DOMAINS + select IMX_GPCV2_PM_DOMAINS help This enables support for the ARMv8 based SoCs in the NXP i.MX family.
The ATF on the i.MX8MQ device disables all non-essential power domains. For correct on-SoC peripheral operation we need both the power domain driver and generic domains, so device driver probe gets ordered behind the power domain controller driver. Select those options, as those being absent can lead to very hard to debug failures. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- arch/arm64/Kconfig.platforms | 3 +++ 1 file changed, 3 insertions(+)