From patchwork Thu Jan 24 16:58:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10779597 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AA464139A for ; Thu, 24 Jan 2019 16:59:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ECA1F30D9D for ; Thu, 24 Jan 2019 16:59:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E12EC30DD6; Thu, 24 Jan 2019 16:59:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 89CA130D9D for ; Thu, 24 Jan 2019 16:59:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3POvWCqYaapY7yu59RwaqyxVvdKwEnxvR7nOGEMzA+k=; b=EKzEFhlk7qAQaB cZZKnoCJyjlgdZVEsohI6+MWrsR0W5CmYOLzns4Gb/JJE7l4V6UtFed5jze54wJ0NBu9DiTcLlWwf f41bwTIhxsGYqH6BJ+LV0LPwyzss3Rh0jJRi11WA5cP8IwshsAanO1l/N3Pr6l5F9CaX8DtR47DpX uXtNpBVno+cYJJnP9Lbla/OVT2cafrrvuR3bY3pV/JZd2y+KVKzcPZw2xKru3GsOwYU5Za0ppuSol cF9cWU5mtHjnQwFAjizTVZ7t7AekFbgyMoiGloj0L9nmxyDsnyiJVaovV9Jr6y/hAeTsseaJIVxTL hfbkToI7KrJMd2RJzesw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmiLl-0001Nw-R6; Thu, 24 Jan 2019 16:59:33 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gmiLS-00016u-52 for linux-arm-kernel@lists.infradead.org; Thu, 24 Jan 2019 16:59:27 +0000 Received: by mail-ed1-x543.google.com with SMTP id y20so5146208edw.9 for ; Thu, 24 Jan 2019 08:59:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2vqXGdcBTElXpx8czNA3HuBOnAjGELcZxCvOFKHxtkg=; b=jYpkP8v8JScCko9UDYDq8LTLN/koJQMeUvxuelrwD2lzAxC/0EOydxFygEZgIRnpKC udT/XhyKwHbCPBsZ/ei+e4lS8m9kJLK3WLSQejxhUy2IBrWwFaA52nRyJFgW8K157OjY 5Gyn+knKL/6FBCPjhEqmw7+UBnbiZwgNfuGKA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2vqXGdcBTElXpx8czNA3HuBOnAjGELcZxCvOFKHxtkg=; b=IzGagcEsTNeAFcsRXrmIhgvnT6wSyqT1ee671qsAw99X+Wpd/O36KnfL+PtEdEHawQ GOdRAJjNj/V4dt5UPiLRkcrxMfCxiDUyqpe1ZOhDlAfRqfHNIpkYkutWVCDwwehhAQeW XYZeqvMsvG8CG7foWZjhNn0GKdg4Ig3uCeIzqDyF9HKhsEeptJERKCF39awU/pVF4iHZ TA8w6RQ7MF7gRd0805zT5/qAl3G49eFt1PoYOQzMk7lDcPvkAT4ugiIwX2/f9KI2/5V4 EnUU7PatS2xsuW+VeQymfalOiVuwfjAcx0dUwohg48unyiaucmhCX5t+uhl7mbmcaYDq a2ZA== X-Gm-Message-State: AJcUukfW+O3WT0zv8cib88o4O4QAFqeUqdXOqnGyIRYZ/8KuZk9yMtq4 oVsG4AMvJEoaTnSHFl2rK6/8rQ== X-Google-Smtp-Source: ALg8bN7cOL0YTkSOuQZjTVQOUZrzbYTzPVTRvraG0t2Eic45Tqm3ET1hI/oyywZ+01nx0xbi3JojUA== X-Received: by 2002:a17:906:c7d9:: with SMTP id dc25mr4956818ejb.204.1548349152448; Thu, 24 Jan 2019 08:59:12 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id w31sm11219233edw.82.2019.01.24.08.59.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:59:11 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 21/26] drm/rockchip: Use drm_fb_helper_fill_info Date: Thu, 24 Jan 2019 17:58:26 +0100 Message-Id: <20190124165831.16427-22-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124165831.16427-1-daniel.vetter@ffwll.ch> References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190124_085914_460705_C0DB24B5 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Heiko_St=C3=BCbner?= , Daniel Vetter , Intel Graphics Development , Sandy Huang , linux-rockchip@lists.infradead.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This will set an fb name for the first time! Signed-off-by: Daniel Vetter Cc: Sandy Huang Cc: "Heiko Stübner" Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Reviewed-by: Heiko Stuebner --- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c index 7bd3b89022be..d12164878e05 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c @@ -90,13 +90,11 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper, goto out; } - fbi->par = helper; fbi->flags = FBINFO_FLAG_DEFAULT; fbi->fbops = &rockchip_drm_fbdev_ops; fb = helper->fb; - drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->format->depth); - drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height); + drm_fb_helper_fill_info(fbi, helper); offset = fbi->var.xoffset * bytes_per_pixel; offset += fbi->var.yoffset * fb->pitches[0];