| Message ID | 20190208151014.CD48668DDC@newverein.lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: ftrace with regs | expand |
On Fri, Feb 08, 2019 at 04:10:14PM +0100, Torsten Duwe wrote: > In preparation for arm64 supporting ftrace built on other compiler > options, let's have makefiles remove the $(CC_FLAGS_FTRACE) > flags, whatever these may be, rather than assuming '-pg'. > > There should be no functional change as a result of this patch. > > Signed-off-by: Torsten Duwe <duwe@suse.de> With the indentation removed from the commit text: Reviewed-by: Mark Rutland <mark.rutland@arm.com> Mark. > > --- > mm/kasan/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > --- a/mm/kasan/Makefile > +++ b/mm/kasan/Makefile > @@ -5,8 +5,8 @@ UBSAN_SANITIZE_generic.o := n > UBSAN_SANITIZE_tags.o := n > KCOV_INSTRUMENT := n > > -CFLAGS_REMOVE_common.o = -pg > -CFLAGS_REMOVE_generic.o = -pg > +CFLAGS_REMOVE_common.o = $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_generic.o = $(CC_FLAGS_FTRACE) > # Function splitter causes unnecessary splits in __asan_load1/__asan_store1 > # see: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63533 >
On Fri, Feb 08, 2019 at 04:10:14PM +0100, Torsten Duwe wrote: > In preparation for arm64 supporting ftrace built on other compiler > options, let's have makefiles remove the $(CC_FLAGS_FTRACE) > flags, whatever these may be, rather than assuming '-pg'. > > There should be no functional change as a result of this patch. > > Signed-off-by: Torsten Duwe <duwe@suse.de> With the indentation removed from the commit text: Reviewed-by: Mark Rutland <mark.rutland@arm.com> Mark. > > --- > mm/kasan/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > --- a/mm/kasan/Makefile > +++ b/mm/kasan/Makefile > @@ -5,8 +5,8 @@ UBSAN_SANITIZE_generic.o := n > UBSAN_SANITIZE_tags.o := n > KCOV_INSTRUMENT := n > > -CFLAGS_REMOVE_common.o = -pg > -CFLAGS_REMOVE_generic.o = -pg > +CFLAGS_REMOVE_common.o = $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_generic.o = $(CC_FLAGS_FTRACE) > # Function splitter causes unnecessary splits in __asan_load1/__asan_store1 > # see: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63533 >
On Fri, Feb 08, 2019 at 04:10:14PM +0100, Torsten Duwe wrote: > In preparation for arm64 supporting ftrace built on other compiler > options, let's have makefiles remove the $(CC_FLAGS_FTRACE) > flags, whatever these may be, rather than assuming '-pg'. > > There should be no functional change as a result of this patch. > > Signed-off-by: Torsten Duwe <duwe@suse.de> Andrey, would you be happy if we were to take this via the arm64 tree? Assuming so, could we please have your ack? Thanks, Mark. > > --- > mm/kasan/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > --- a/mm/kasan/Makefile > +++ b/mm/kasan/Makefile > @@ -5,8 +5,8 @@ UBSAN_SANITIZE_generic.o := n > UBSAN_SANITIZE_tags.o := n > KCOV_INSTRUMENT := n > > -CFLAGS_REMOVE_common.o = -pg > -CFLAGS_REMOVE_generic.o = -pg > +CFLAGS_REMOVE_common.o = $(CC_FLAGS_FTRACE) > +CFLAGS_REMOVE_generic.o = $(CC_FLAGS_FTRACE) > # Function splitter causes unnecessary splits in __asan_load1/__asan_store1 > # see: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63533 >
On 2/8/19 6:10 PM, Torsten Duwe wrote: > In preparation for arm64 supporting ftrace built on other compiler > options, let's have makefiles remove the $(CC_FLAGS_FTRACE) > flags, whatever these may be, rather than assuming '-pg'. > > There should be no functional change as a result of this patch. > > Signed-off-by: Torsten Duwe <duwe@suse.de> > Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
--- a/mm/kasan/Makefile +++ b/mm/kasan/Makefile @@ -5,8 +5,8 @@ UBSAN_SANITIZE_generic.o := n UBSAN_SANITIZE_tags.o := n KCOV_INSTRUMENT := n -CFLAGS_REMOVE_common.o = -pg -CFLAGS_REMOVE_generic.o = -pg +CFLAGS_REMOVE_common.o = $(CC_FLAGS_FTRACE) +CFLAGS_REMOVE_generic.o = $(CC_FLAGS_FTRACE) # Function splitter causes unnecessary splits in __asan_load1/__asan_store1 # see: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63533
In preparation for arm64 supporting ftrace built on other compiler options, let's have makefiles remove the $(CC_FLAGS_FTRACE) flags, whatever these may be, rather than assuming '-pg'. There should be no functional change as a result of this patch. Signed-off-by: Torsten Duwe <duwe@suse.de> --- mm/kasan/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)