| Message ID | 20190220085607.31582-1-peng.ma@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v6,1/3] dt-bindings: ahci-fsl-qoriq: add lx2160a chip name to the list | expand |
On Wed, 20 Feb 2019 08:56:05 +0000, Peng Ma wrote: > Add lx2160a compatible to bindings documentation. > > Signed-off-by: Peng Ma <peng.ma@nxp.com> > --- > changed for V6: > - no changed > > .../devicetree/bindings/ata/ahci-fsl-qoriq.txt | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
Hi Rob, Thanks for your comments, I don't understand what you said. This patch is one of the series patchs(http://patchwork.ozlabs.org/project/linux-ide/list/?series=93099&archive=both&state=*) for review. There is not changed for 6th version of this patch. Best Regards, Peng >-----Original Message----- >From: Rob Herring <robh@kernel.org> >Sent: 2019年2月22日 22:40 >To: Peng Ma <peng.ma@nxp.com> >Cc: axboe@kernel.dk; robh+dt@kernel.org; mark.rutland@arm.com; >shawnguo@kernel.org; Leo Li <leoyang.li@nxp.com>; Andy Tang ><andy.tang@nxp.com>; linux-ide@vger.kernel.org; devicetree@vger.kernel.org; >linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Mian >Yousaf Kaukab <yousaf.kaukab@suse.com>; Peng Ma <peng.ma@nxp.com> >Subject: Re: [v6 1/3] dt-bindings: ahci-fsl-qoriq: add lx2160a chip name to the >list > >On Wed, 20 Feb 2019 08:56:05 +0000, Peng Ma wrote: >> Add lx2160a compatible to bindings documentation. >> >> Signed-off-by: Peng Ma <peng.ma@nxp.com> >> --- >> changed for V6: >> - no changed >> >> .../devicetree/bindings/ata/ahci-fsl-qoriq.txt | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> > >Please add Acked-by/Reviewed-by tags when posting new versions. However, >there's no need to repost patches *only* to add the tags. The upstream >maintainer will do that for acks received on the version they apply. > >If a tag was not added on purpose, please state why and what changed.
On Mon, Mar 11, 2019 at 1:57 AM Peng Ma <peng.ma@nxp.com> wrote: > > Hi Rob, Please don't top post to mail lists. A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? > > Thanks for your comments, I don't understand what you said. > This patch is one of the series patchs(http://patchwork.ozlabs.org/project/linux-ide/list/?series=93099&archive=both&state=*) for review. > There is not changed for 6th version of this patch. I reviewed v5 and gave my Reviewed-by. When you posted v6, you should have added the tag so the maintainer applying this series doesn't have to look at prior versions to collect tags and so I don't have to review this again and can ignore it. Rob
diff --git a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt index 7c3ca0e..9ecc019 100644 --- a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt +++ b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt @@ -3,7 +3,7 @@ Binding for Freescale QorIQ AHCI SATA Controller Required properties: - reg: Physical base address and size of the controller's register area. - compatible: Compatibility string. Must be 'fsl,<chip>-ahci', where - chip could be ls1021a, ls1043a, ls1046a, ls1088a, ls2080a etc. + chip could be ls1021a, ls1043a, ls1046a, ls1088a, ls2080a, lx2160a, etc. - clocks: Input clock specifier. Refer to common clock bindings. - interrupts: Interrupt specifier. Refer to interrupt binding.
Add lx2160a compatible to bindings documentation. Signed-off-by: Peng Ma <peng.ma@nxp.com> --- changed for V6: - no changed .../devicetree/bindings/ata/ahci-fsl-qoriq.txt | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)