| Message ID | 20190222122430.21180-20-vincenzo.frascino@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Unify vDSOs across more architectures | expand |
On Fri, Feb 22, 2019 at 12:24:26PM +0000, Vincenzo Frascino wrote: > Enable compat vDSO support in the arm64 defconfig. > > Note that the default compiler is set to arm-linux-gnueabihf-. > For this to take effect and for the compat vDSO to compile correctly, it > is required that this compiler is in the PATH. I do not have such a compiler in my path by default. I hope that we handle that gracefully, rather than causing a build failure. Can't we detect the presence of the compat compiler at config time, as happens for the native compiler? Thanks, Mark. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will.deacon@arm.com> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index c8432e24207e..3adebe5f3573 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -120,6 +120,7 @@ CONFIG_ACPI_APEI_MEMORY_FAILURE=y > CONFIG_ACPI_APEI_EINJ=y > CONFIG_VIRTUALIZATION=y > CONFIG_KVM=y > +CONFIG_CROSS_COMPILE_COMPAT_VDSO="arm-linux-gnueabihf-" > CONFIG_ARM64_CRYPTO=y > CONFIG_CRYPTO_SHA1_ARM64_CE=y > CONFIG_CRYPTO_SHA2_ARM64_CE=y > -- > 2.20.1 >
On Fri, Feb 22, 2019 at 02:39:58PM +0000, Mark Rutland wrote: > On Fri, Feb 22, 2019 at 12:24:26PM +0000, Vincenzo Frascino wrote: > > Enable compat vDSO support in the arm64 defconfig. > > > > Note that the default compiler is set to arm-linux-gnueabihf-. > > For this to take effect and for the compat vDSO to compile correctly, it > > is required that this compiler is in the PATH. > > I do not have such a compiler in my path by default. > > I hope that we handle that gracefully, rather than causing a build > failure. > > Can't we detect the presence of the compat compiler at config time, as > happens for the native compiler? > > Thanks, > Mark. > > > > > Cc: Catalin Marinas <catalin.marinas@arm.com> > > Cc: Will Deacon <will.deacon@arm.com> > > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index c8432e24207e..3adebe5f3573 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -120,6 +120,7 @@ CONFIG_ACPI_APEI_MEMORY_FAILURE=y > > CONFIG_ACPI_APEI_EINJ=y > > CONFIG_VIRTUALIZATION=y > > CONFIG_KVM=y > > +CONFIG_CROSS_COMPILE_COMPAT_VDSO="arm-linux-gnueabihf-" Also, the kernel.org crosstool compilers are arm-linux-gnueabi-. Could we please avoid having a default, in the same way that we don't have a default for CROSS_COMPILE? Otherwise, it's always gongi to be wrong for someone, and we'll never be able to change it anyway. Thanks, Mark. > > CONFIG_ARM64_CRYPTO=y > > CONFIG_CRYPTO_SHA1_ARM64_CE=y > > CONFIG_CRYPTO_SHA2_ARM64_CE=y > > -- > > 2.20.1 > >
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index c8432e24207e..3adebe5f3573 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -120,6 +120,7 @@ CONFIG_ACPI_APEI_MEMORY_FAILURE=y CONFIG_ACPI_APEI_EINJ=y CONFIG_VIRTUALIZATION=y CONFIG_KVM=y +CONFIG_CROSS_COMPILE_COMPAT_VDSO="arm-linux-gnueabihf-" CONFIG_ARM64_CRYPTO=y CONFIG_CRYPTO_SHA1_ARM64_CE=y CONFIG_CRYPTO_SHA2_ARM64_CE=y
Enable compat vDSO support in the arm64 defconfig. Note that the default compiler is set to arm-linux-gnueabihf-. For this to take effect and for the compat vDSO to compile correctly, it is required that this compiler is in the PATH. Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)