| Message ID | 20190301132809.24653-6-will.deacon@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Rework debug exception handling code | expand |
On Fri, Mar 01, 2019 at 01:28:04PM +0000, Will Deacon wrote: > The comment next to the definition of our 'break_hook' list head is > at best wrong but mainly just meaningless. Rip it out. > > Signed-off-by: Will Deacon <will.deacon@arm.com> Reviewed-by: Mark Rutland <mark.rutland@arm.com> Mark. > --- > arch/arm64/kernel/debug-monitors.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c > index c4c263d0cf0f..744229d10ca8 100644 > --- a/arch/arm64/kernel/debug-monitors.c > +++ b/arch/arm64/kernel/debug-monitors.c > @@ -264,11 +264,6 @@ static int single_step_handler(unsigned long unused, unsigned int esr, > } > NOKPROBE_SYMBOL(single_step_handler); > > -/* > - * Breakpoint handler is re-entrant as another breakpoint can > - * hit within breakpoint handler, especically in kprobes. > - * Use reader/writer locks instead of plain spinlock. > - */ > static LIST_HEAD(break_hook); > static DEFINE_SPINLOCK(break_hook_lock); > > -- > 2.11.0 >
diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c index c4c263d0cf0f..744229d10ca8 100644 --- a/arch/arm64/kernel/debug-monitors.c +++ b/arch/arm64/kernel/debug-monitors.c @@ -264,11 +264,6 @@ static int single_step_handler(unsigned long unused, unsigned int esr, } NOKPROBE_SYMBOL(single_step_handler); -/* - * Breakpoint handler is re-entrant as another breakpoint can - * hit within breakpoint handler, especically in kprobes. - * Use reader/writer locks instead of plain spinlock. - */ static LIST_HEAD(break_hook); static DEFINE_SPINLOCK(break_hook_lock);
The comment next to the definition of our 'break_hook' list head is at best wrong but mainly just meaningless. Rip it out. Signed-off-by: Will Deacon <will.deacon@arm.com> --- arch/arm64/kernel/debug-monitors.c | 5 ----- 1 file changed, 5 deletions(-)