diff mbox series

ARM: dts: bcm283x: Fix hdmi hpd gpio pull

Message ID 20190304214837.9045-1-helen.koike@collabora.com (mailing list archive)
State Mainlined, archived
Commit 544e784188f1dd7c797c70b213385e67d92005b6
Headers show
Series ARM: dts: bcm283x: Fix hdmi hpd gpio pull | expand

Commit Message

Helen Mae Koike Fornazier March 4, 2019, 9:48 p.m. UTC 
Raspberry pi board model B revison 2 have the hot plug detector gpio
active high (and not low as it was in the dts).

Signed-off-by: Helen Koike <helen.koike@collabora.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
---
 arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Wahren March 4, 2019, 10:10 p.m. UTC | #1 
Hi,

since this patch change only one board, the subject could be more specific:

ARM: dts: bcm2835-rpi-b-rev2: Fix hdmi hpd gpio pull

> Helen Koike <helen.koike@collabora.com> hat am 4. März 2019 um 22:48 geschrieben:
> 
> 
> Raspberry pi board model B revison 2 have the hot plug detector gpio
> active high (and not low as it was in the dts).
> 
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
> Reviewed-by: Eric Anholt <eric@anholt.net>

I think we should add a Fixes tag here, so it could be backported.

@Eric: Feel free to take V2

Thanks
Eric Anholt March 4, 2019, 11:26 p.m. UTC | #2 
Stefan Wahren <stefan.wahren@i2se.com> writes:

> Hi,
>
> since this patch change only one board, the subject could be more specific:
>
> ARM: dts: bcm2835-rpi-b-rev2: Fix hdmi hpd gpio pull
>
>> Helen Koike <helen.koike@collabora.com> hat am 4. März 2019 um 22:48 geschrieben:
>> 
>> 
>> Raspberry pi board model B revison 2 have the hot plug detector gpio
>> active high (and not low as it was in the dts).
>> 
>> Signed-off-by: Helen Koike <helen.koike@collabora.com>
>> Reviewed-by: Eric Anholt <eric@anholt.net>
>
> I think we should add a Fixes tag here, so it could be backported.
>
> @Eric: Feel free to take V2

Added a fixes tag, and I'll submit PRs for this and the PM fixes now.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
index 5641d162dfdb..28e7513ce617 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
@@ -93,7 +93,7 @@ 
 };
 
 &hdmi {
-	hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
+	hpd-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>;
 };
 
 &pwm {