From patchwork Sun Mar 10 18:58:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Van Asbroeck X-Patchwork-Id: 10846425 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F394F922 for ; Sun, 10 Mar 2019 18:58:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE72F28E8E for ; Sun, 10 Mar 2019 18:58:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D1CEC28F63; Sun, 10 Mar 2019 18:58:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 82EE128E8E for ; Sun, 10 Mar 2019 18:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=x0MOOcKkp/L44CGA89LaPDWA8rPtoagHpfmRysx+hiM=; b=Pta UGnCNeenOTq4QbCLEwOUB56c07/VDM2ej4TNckpcEA3uLdmRgck2ExytDY9LmgPbI554EZ7hLaPFc q211v2PYyQEPnk6xIraTOEmi4LZ/KaR0zZyebg7OoPxvBuWoXrAqu4La+yRAeMeRzRhO6+b+aHGfh phHHy3J/ECG/TeSc8bxjvmrMQqsl4122rhQ6XQS/IyoPKJEarAK0ZkspAs0pGr+5xk4n4esVvbU1W RmjnVSarJrh92iF2Hlw+LFcQQNTRttFG6rQf7kyDTpdlvBzZfjNWPcet4EX2bj2m6ecqros5iMllL iDRwNOoR1/fi7Dpi4/Fdsnos5o5do7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h33ei-0008IU-Fk; Sun, 10 Mar 2019 18:58:40 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h33ee-0008HP-Gz for linux-arm-kernel@lists.infradead.org; Sun, 10 Mar 2019 18:58:38 +0000 Received: by mail-io1-xd44.google.com with SMTP id f6so2140534iop.3 for ; Sun, 10 Mar 2019 11:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=yqC4zt3nEa3xfmEsElEgoM7DbcmfILE263nXYl1T67A=; b=HPiHBiOxqn5IGYqU7rMfGrZNDUDLK2g5yq67pEwgan135b0L8aTkEwaojqxNdF+OUz WvOG+2SdKbklBN9g/5WO+rHtxg7dbb2m+CZyciIWfXokjvpFKuube2AC3bqRyZJRUpoZ kXUi+IpHEZhli64iJqVdeH8oCxhyT/IAOb6wO8yfnrbJctkyTQlxAE0Xi2NcVXIe6wdo RbM7iqsbLzp5ODWLJVdn2FPkxYmDD4lknJrRj73iORFLbtyHPwQT5l+908SbcM1Uxyun jlrAhxVO0eXDvrIc94YiCGI8UAhw/pKvDAqbQb5Hcxy0R/FzB3iCbJ5HAhQ9Vm652EYP irHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=yqC4zt3nEa3xfmEsElEgoM7DbcmfILE263nXYl1T67A=; b=uazi6yhKalLHmBwFHmvVzStKeQIbQXlpTfS2WKXYADvLAxugB02wSBHQPID+QIl3Ga cDy+GVwjEbLxmljiZ/qiIW0XY6Gv9sO6bSn5I3RVebSlr6OBlBnu1oBfuxx7iAKN3ghH bgbIV5skLv+UyuX724NYQaC2abrA//NaTmkVSUa+j/oTUY1i/6uykxR/KCWU+8ZYs+J5 S9egYXp3wMOW8hTjjlMvCOK/w5BDADG54i1YX2DxE+cOO1e820MzoNEgk+MN8a8U9Xmt cwq3SC9y23PtPmh1WbIwRPMIWmtI5EEGTqxmUzLciXZjMIMJxvk/Ri9GojsJtRjluCPM lDDw== X-Gm-Message-State: APjAAAXNE5V7B+MS6XAeNHzwbUPFgbJlmEpCyzPMr8g3imGIlUTux8xt Pk3N0uMLJBKd00fKdaFBhUk= X-Google-Smtp-Source: APXvYqw24O91l34LCLCNpO32ZisLz+346P+TCpOrrUXbLgtobmlaeJQ4n2Pj1hviFvnJvAhox6e5IQ== X-Received: by 2002:a6b:7847:: with SMTP id h7mr14509934iop.83.1552244314370; Sun, 10 Mar 2019 11:58:34 -0700 (PDT) Received: from localhost.localdomain ([198.52.185.227]) by smtp.gmail.com with ESMTPSA id y18sm1359270ioa.56.2019.03.10.11.58.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Mar 2019 11:58:33 -0700 (PDT) From: Sven Van Asbroeck X-Google-Original-From: Sven Van Asbroeck To: Jonathan Cameron Subject: [PATCH 1/3] iio: adc: xilinx: fix potential use-after-free on remove Date: Sun, 10 Mar 2019 14:58:24 -0400 Message-Id: <20190310185826.25916-1-TheSven73@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190310_115836_588757_94CDDCC0 X-CRM114-Status: GOOD ( 12.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lars-Peter Clausen , linux-iio@vger.kernel.org, Michal Simek , linux-kernel@vger.kernel.org, Manish Narani , Peter Meerwald-Stadler , Hartmut Knaack , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When cancel_delayed_work() returns, the delayed work may still be running. This means that the core could potentially free the private structure (struct xadc) while the delayed work is still using it. This is a potential use-after-free. Fix by calling cancel_delayed_work_sync(), which waits for any residual work to finish before returning. Signed-off-by: Sven Van Asbroeck --- drivers/iio/adc/xilinx-xadc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c index 3f6be5ac049a..1960694e8007 100644 --- a/drivers/iio/adc/xilinx-xadc-core.c +++ b/drivers/iio/adc/xilinx-xadc-core.c @@ -1320,7 +1320,7 @@ static int xadc_remove(struct platform_device *pdev) } free_irq(xadc->irq, indio_dev); clk_disable_unprepare(xadc->clk); - cancel_delayed_work(&xadc->zynq_unmask_work); + cancel_delayed_work_sync(&xadc->zynq_unmask_work); kfree(xadc->data); kfree(indio_dev->channels);