From patchwork Mon Mar 25 05:01:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10867885 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 71595139A for ; Mon, 25 Mar 2019 05:01:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 534CA291DA for ; Mon, 25 Mar 2019 05:01:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 478C1291DC; Mon, 25 Mar 2019 05:01:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DFEDC291DA for ; Mon, 25 Mar 2019 05:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=TBhGUQqUM36nrz9Lb0ydCxm3Qx5+8ziesxNBoNA8bEM=; b=cvwd1Wn+O+yxLg 5gKM6r+ToSVpqMd4s2xeT1KE7BEEGnCkSSje2j/6Kmi7qB/FBBNmJSVBEQM7SwN2UzzMvaBJKALP4 qrzFSFa2v0tovIEVoM4Gv+UkGKCznhzyyDTWhGSvbSwauZcVbaK03j1oNXWvUAcyxjUj/ahVPCc6w EY5UE5ZpOEdihauWTF/gauO+vZ0Y14rvxqDJhPH6IaNz75DCa5g54/X3+vOAWVBfJwwYuzDKudBPW GvSg068HaHGUfhPFR6YgizgSVcbc9VpV2uQ3bYPZc9O/iXMia2dOhduVIwT34Y9amarMK1sFsONJ9 tJK55ejlcF4UDPd+myUg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8Hjf-00036m-4G; Mon, 25 Mar 2019 05:01:23 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8Hjb-00036R-8M for linux-arm-kernel@lists.infradead.org; Mon, 25 Mar 2019 05:01:20 +0000 Received: by mail-pg1-x543.google.com with SMTP id j26so3596027pgl.5 for ; Sun, 24 Mar 2019 22:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rdqiUqpCCqjlbO4cGUPp77lKkW7nNkFREk67Kdc/S4U=; b=GQbKn3wFQQPcgHY1liBFlSxrm+RX5+95eb87S5Rz0JEXOSzR9NxVUR/qslfwirDoGv ipN66LrEvnaQHuQgA+kl3/BxOGeorepy5ascwIdaGfg90TyjANrlzhWsjVdDQ8ntyYHE cyrxGqLfUJ+060ODVS2VwNfewlKEXDcY1QitoiRlfZ6nd3rmY6Geff4WrAKeBKUVPT/W /sbdaWCCMX/Yq9THONknsb4GJqVkJ0SCdu/dB4MRtr3NRqK2Ritaax5ZVHEp7IGBQ1V1 6aXYnnktxxmqBDaQl1SdE6lV3iLCCpsqcZeusIqvrsi+X72cJg1waHo7zkVXkXoFhG0x kQVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rdqiUqpCCqjlbO4cGUPp77lKkW7nNkFREk67Kdc/S4U=; b=rN3Lwu4SDKVDYT4TMUE+3FVjDg1vpduUdMr2g3OYyDa23SzjjOFgUJnWl4VOKzJXMj 8R6F9ZTz5Icm51W274tXwbVDwSHq0OKAYjiON4ZdiMMbAAOB2t5PulWLVCJWiKlE1yC5 1IgCUKS/l9iKZkvUIyJkHTJ6nQdOigDreszI5pI2MazOA2L8kpbdUMU8zx9I9VN3+kMP Q3m7LcAMvAFzrk3+fIs6VGDedm6OC1jorS90XcqvzAQxiWp0j9BituaAptniAbgB9kWi 654OQVFuWbBsQp25Qv/rQsvey9Toch7pA6T7233IbWsCodSwl2bJU6xDWHW2HZ6YiEYR EILA== X-Gm-Message-State: APjAAAUfD+tvfi7N3UEJA+B6TrTEXl8mdwPcqu8QhaT1Oqpo9yAlO4im mWeJ7+VpedSqmVC0HwfKcXQ= X-Google-Smtp-Source: APXvYqwj/L2DlBgQD7K1Lr6oTwVyn7NNHNwC4UtAuYE0TBEbj3pZadiM+3bIYzOGZZyx08gK7sMYbQ== X-Received: by 2002:a17:902:8692:: with SMTP id g18mr22613304plo.149.1553490076743; Sun, 24 Mar 2019 22:01:16 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id 17sm20238200pgt.0.2019.03.24.22.01.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 24 Mar 2019 22:01:15 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA Date: Sun, 24 Mar 2019 22:01:00 -0700 Message-Id: <20190325050100.29517-1-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190324_220119_333997_5310EE57 X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA functionality(this at least breaks RAVE SP serdev driver on RDU2). Fix the code to specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to the problem. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Reviewed-by: Lucas Stach --- This probably has been fixed already, so please ignore this patch if that is the case. Thanks, Andrey Smirnov arch/arm/boot/dts/imx6qdl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 9f9aa6e7ed0e..354feba077b2 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -949,7 +949,7 @@ compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks IMX6QDL_CLK_SDMA>, + clocks = <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>;