| Message ID | 20190325135300.6440-12-maxime.ripard@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/28] dt-bindings: arm: Remove the CPU compatible documentation | expand |
On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > The AHCI node was introduced with a typo in the reset-names property that > got written resets-name instead. > > This was working because the reset is optional for that driver, and the > controller was put out of reset by the bootloader. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Fixes tag? For the odd case that the bootloader didn't pull the controller out of reset. Otherwise, Acked-by: Chen-Yu Tsai <wens@csie.org>
On Tue, Mar 26, 2019 at 01:00:14AM +0800, Chen-Yu Tsai wrote: > On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > The AHCI node was introduced with a typo in the reset-names property that > > got written resets-name instead. > > > > This was working because the reset is optional for that driver, and the > > controller was put out of reset by the bootloader. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > > Fixes tag? For the odd case that the bootloader didn't pull the controller > out of reset. > > Otherwise, > > Acked-by: Chen-Yu Tsai <wens@csie.org> I added the fixes tag and applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/arch/arm/boot/dts/sun8i-r40.dtsi b/arch/arm/boot/dts/sun8i-r40.dtsi index 1061d46efafd..9784c23346a8 100644 --- a/arch/arm/boot/dts/sun8i-r40.dtsi +++ b/arch/arm/boot/dts/sun8i-r40.dtsi @@ -562,7 +562,7 @@ interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>; clocks = <&ccu CLK_BUS_SATA>, <&ccu CLK_SATA>; resets = <&ccu RST_BUS_SATA>; - resets-name = "ahci"; + reset-names = "ahci"; #address-cells = <1>; #size-cells = <0>; status = "disabled";
The AHCI node was introduced with a typo in the reset-names property that got written resets-name instead. This was working because the reset is optional for that driver, and the controller was put out of reset by the bootloader. Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> --- arch/arm/boot/dts/sun8i-r40.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)