diff mbox series

[24/28] ARM: dts: sun8i: a83t: Fix the SPDIF binding

Message ID 20190325135300.6440-24-maxime.ripard@bootlin.com (mailing list archive)
State New, archived
Headers show
Series [01/28] dt-bindings: arm: Remove the CPU compatible documentation | expand

Commit Message

Maxime Ripard March 25, 2019, 1:52 p.m. UTC 
The SPDIF binding mandates that we have two DMA channels, one for reception
and one in transmission. However, the device tree only specifies one.

This has gone un-noticed since the driver only has support for transmission
currently.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 arch/arm/boot/dts/sun8i-a83t.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chen-Yu Tsai March 26, 2019, 2:48 a.m. UTC | #1 
On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> The SPDIF binding mandates that we have two DMA channels, one for reception
> and one in transmission. However, the device tree only specifies one.
>
> This has gone un-noticed since the driver only has support for transmission
> currently.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index 883f039e9e71..09e7f74ab5f5 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -794,8 +794,8 @@ 
 			clocks = <&ccu CLK_BUS_SPDIF>, <&ccu CLK_SPDIF>;
 			resets = <&ccu RST_BUS_SPDIF>;
 			clock-names = "apb", "spdif";
-			dmas = <&dma 2>;
-			dma-names = "tx";
+			dmas = <&dma 2>, <&dma 2>;
+			dma-names = "rx", "tx";
 			pinctrl-names = "default";
 			pinctrl-0 = <&spdif_tx_pin>;
 			status = "disabled";