From patchwork Tue Mar 26 13:20:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10871095 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A45F2922 for ; Tue, 26 Mar 2019 13:21:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9087A28F89 for ; Tue, 26 Mar 2019 13:21:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 84E2B28FC5; Tue, 26 Mar 2019 13:21:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 32F8A290EB for ; Tue, 26 Mar 2019 13:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MbXgAbhxcS4yiogmgEMFL7fdFR+B9KQMvlBmHFkQekg=; b=lfHZTfdsSG0fCC WdgSrYIGWqC7xTUr3q1OwUB10C+nJANwjZlCMJYmHrZ4Gs0RI/3y0j8M5x2gb+EX2K7KjBwZ039gw Bz+zU+Cx7FIx2LpW23kb4ZaJBJysJ9XAUZ+AVZXqZEN/jItKFl7FKBR26z5RwEyA1kO73LSyHQ3UY cCiTlR+NtrHh82V5Xu4Lu/wQcwxySXGO0R4vUqy3t4Xv4olwOITjdFaE/fmbyxfQpHLxvGMTZJNIc HEgK1s2y0q+9FgpIvS9yXN6DPuYO7QXpz/PXLJL+zkxogJk7+yqLwpjiY5LuVkxqehqzLKEO37Vwm K9QM5bjOAaFYeTlCzVlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8m0j-0007XO-Pm; Tue, 26 Mar 2019 13:21:01 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8m0O-00074h-23 for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 13:20:45 +0000 Received: by mail-ed1-x544.google.com with SMTP id d26so10702365ede.10 for ; Tue, 26 Mar 2019 06:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yrfdge2Nqrh6arVhSdlo0upydE4epXNMjFt6CZLmtq8=; b=G/qE1OLKVRnKkf/6tUInIBkj/vDvi8hjkTDQ5Pygt1jEoNSlHWu7fdcG2V2qcsNeLu FT63ako0ib7zAD0KW0UVEphEI2k0V7UTVGwfZnjiteJERhcQSyOHzXlZeZCWBxE1kRKV yzgNraDsYCbykng3iTaxgfgnp4dWY1UKA/OUc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yrfdge2Nqrh6arVhSdlo0upydE4epXNMjFt6CZLmtq8=; b=KF0IXq/fsS5h1QL2uyYc7yWpI4k5U820c678CulHwWMj1mYgr5evfx+lJdndXN4/g2 JWyuJlfCAbHIfo+dx0zlug8TYWv4ziLkIcIZxVqoCiHaawNT0aM94iO77cB+pjLPideG bnzvGKNopIUx/ku+fID5ACCKWaP5lSw8/ZJ1p0O4ZugiRsJhUzjuJ/+FKoskLwXPhTHQ OoVA4fBrwHjXKn5LF6iyPywdPsAvFO0DiFLAV9cx8yWPeG/N6H+A9cu+KVsVp5OqEiKk bDVS8TBzpX0zLKvT+8ghCZvApo7Aws3F3MAvzJYPNmLGWmHKG+feLoNTpt+HYIYnvvMj N3UQ== X-Gm-Message-State: APjAAAWG+MHA+RZUEuMsd4nWCkuBKgY7m9SBB+1pEBupgsJBfveFqfZV t5AUpShJH76DVapjgo4g+6T7MA== X-Google-Smtp-Source: APXvYqwsEGQdstyZaWuRuY7rE2oYDTS2eM3vd6D2ZOv2iwIWYBqQlyTaA6h7IAVuzVvJOczFL3YQZA== X-Received: by 2002:a50:fe14:: with SMTP id f20mr19753643edt.187.1553606436024; Tue, 26 Mar 2019 06:20:36 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id d10sm3668547ejh.66.2019.03.26.06.20.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 06:20:35 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 17/21] drm/rockchip: Use drm_fb_helper_fill_info Date: Tue, 26 Mar 2019 14:20:04 +0100 Message-Id: <20190326132008.11781-17-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190326132008.11781-1-daniel.vetter@ffwll.ch> References: <20190326132008.11781-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_062040_840041_F77E761C X-CRM114-Status: GOOD ( 12.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Daniel Vetter , Intel Graphics Development , Sandy Huang , linux-rockchip@lists.infradead.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This will set an fb name for the first time! v2: Rebase Reviewed-by: Heiko Stuebner Signed-off-by: Daniel Vetter Cc: Sandy Huang Cc: "Heiko Stübner" Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Reviewed-by: Noralf Trønnes --- drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c index 0cbcef88d4d7..30459de66b67 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c @@ -90,12 +90,10 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper, goto out; } - fbi->par = helper; fbi->fbops = &rockchip_drm_fbdev_ops; fb = helper->fb; - drm_fb_helper_fill_fix(fbi, fb->pitches[0], fb->format->depth); - drm_fb_helper_fill_var(fbi, helper, sizes->fb_width, sizes->fb_height); + drm_fb_helper_fill_info(fbi, helper, sizes); offset = fbi->var.xoffset * bytes_per_pixel; offset += fbi->var.yoffset * fb->pitches[0];