From patchwork Wed Mar 27 06:34:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10872753 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8442117E0 for ; Wed, 27 Mar 2019 06:35:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C1DC28A29 for ; Wed, 27 Mar 2019 06:35:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4DC4728BF8; Wed, 27 Mar 2019 06:35:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DACB328A29 for ; Wed, 27 Mar 2019 06:35:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=maofwL5lyXx3KOKr3za8B+s/HF0JgJmZQQtS0u8W0L8=; b=tJeiIBPfwCMJxh 9zvp+Lw1aOquhGqHQc2crb0K6PC9d2g+xvRJAyzYNUG43ayrB7sMe06DKVT4na6nsmzdb3W+jaz5K ilzlU+tymgGTD/eiwPdGB9UpNYjDbIk07pLmKDdUlv2qPAw9L/9uQWPv+el8OWQ2vkjgU2F+aZnEA 40LDeVttWSbirEs7/2koAJzddb8W8ro3K5jk8xM4DLSd/5c04vkj+U6Tigq5X3GWFrEvWFcJ76kbn TFZSi4dwn4OlLsomeSOnf9JV9vXsT5dxtZg3HArVvj2EAC718oqcB1jL5swosqr8fk1u+nIbL37eH V+uaRs990KWUpYuR4Gqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h929U-0004p9-DV; Wed, 27 Mar 2019 06:35:08 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h929Q-0004G7-Us for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2019 06:35:06 +0000 Received: by mail-pf1-x442.google.com with SMTP id c207so9254540pfc.7 for ; Tue, 26 Mar 2019 23:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=isVyGu4L9+2S0FNKN5ZEi8kzQawHlgpIIQ13w9ZrByI=; b=OwmXc8RFOwbR84z8LBgKF6An2yApZn709Q/xuBqmcNZ7255Qpe/8TfCPhSgrJriFTc tG7GLoIlhKqqnUbArDhIQ62O79gk3mJ8Oo8dPnsR39VCg6oEeBgp8S1ZKU8z3bsw+hYe DJOlBFU7MVlFrLfzcaQz0xaFxf6dRRH1TgTBAJ5CNmwMIxM3N1lA15mSfNmPRcTIBde+ YqXgDSIxe+lwIfNc86Yp1xNwBIGbnDMywc2QbRwcRYohZutf/Cr3FT8sk7niduppUeB6 OU33gHtykQ1aI6KE3YJrtCns4hCrsOnWoTYKFVek3PLJ0qKlzja6gxM2SSGO4nM16aUi RROA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=isVyGu4L9+2S0FNKN5ZEi8kzQawHlgpIIQ13w9ZrByI=; b=MO2c7LzEuDiPXYvJJucOjtIx7XTSgFwTRWGDUnK2/PtafmaozXp/Uv+Apae2cAAwIu PVAjGNgF3A8rUnxwrB0E8qjg6zBqXoHxV/kZGZDx1TQ1dFQnDp1BTaNxRuHavW2Cp+hZ m3YZrOdVm1egX9yAwPsmzislBCFWhpTs08oWDFwWUY1H9lm2+Ls/Emm0yiM+g62SX3Bf APx236gkp/JnQxj1616NDS39VK6yPYTxcfXiYlTk8BfTtAwHBFAW/BYU7oEKlprp5Gpg S03w5Ckm2f/1SwFAQ1EXqRvLqwtDVFygBEQmTtGKb9Cpg5he9cpwdKihd/I/NvMZRVfD zgbQ== X-Gm-Message-State: APjAAAU4BmBHvfZPOiIpY1MBqAGZTFKJgS5lwH7Hj3l7WtlKRo/1plAy +qRDTjkoz2ZtM3qh9xe40Jg= X-Google-Smtp-Source: APXvYqzfvcGTW5dPqnlN/meZmb4Nyb1yCdbzoFpAnIh6kvUqFcFU9vRop5tEc3fXpb1ZOO07QLHQ1A== X-Received: by 2002:a63:cd47:: with SMTP id a7mr2969266pgj.434.1553668503628; Tue, 26 Mar 2019 23:35:03 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id k1sm19950258pfo.121.2019.03.26.23.35.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 23:35:02 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v2 1/3] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock to SDMA Date: Tue, 26 Mar 2019 23:34:49 -0700 Message-Id: <20190327063451.25629-1-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_233505_025992_65098E57 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6QDL_CLK_SDMA result in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA functionality(this at least breaks RAVE SP serdev driver on RDU2). Fix the code to specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6qdl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 9f9aa6e7ed0e..354feba077b2 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -949,7 +949,7 @@ compatible = "fsl,imx6q-sdma", "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = <0 2 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clks IMX6QDL_CLK_SDMA>, + clocks = <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>;