diff mbox series

[v2,1/2] ARM: dts: sun8i: a83t: Add missing cooling device properties for CPUs

Message ID 20190328113159.9668-2-megous@megous.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: sun8i: a83t: Add missing cooling device properties for CPUs | expand

Commit Message

Ondřej Jirman March 28, 2019, 11:31 a.m. UTC 
From: Ondrej Jirman <megous@megous.com>

Enable to use CPUs as cooling device in the future, by adding
"#cooling-cells" to each CPU node. This property should be present for
all the CPUs of a cluster. If these are present only for a subset of
CPUs of a cluster then things will start falling apart as soon as the
CPUs are brought online in a different order. For example, this will
happen because the operating system looks for such properties in the CPU
node it is trying to bring up, so that it can register a cooling device.

Signed-off-by: Ondrej Jirman <megous@megous.com>
---
 arch/arm/boot/dts/sun8i-a83t.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Maxime Ripard April 1, 2019, 8:20 a.m. UTC | #1 
On Thu, Mar 28, 2019 at 12:31:58PM +0100, megous@megous.com wrote:
> From: Ondrej Jirman <megous@megous.com>
>
> Enable to use CPUs as cooling device in the future, by adding
> "#cooling-cells" to each CPU node. This property should be present for
> all the CPUs of a cluster. If these are present only for a subset of
> CPUs of a cluster then things will start falling apart as soon as the
> CPUs are brought online in a different order. For example, this will
> happen because the operating system looks for such properties in the CPU
> node it is trying to bring up, so that it can register a cooling device.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>

Applied, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
index fcb7ef5ce2df..7a40b7d77ec0 100644
--- a/arch/arm/boot/dts/sun8i-a83t.dtsi
+++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
@@ -69,6 +69,7 @@ 
 			cci-control-port = <&cci_control0>;
 			enable-method = "allwinner,sun8i-a83t-smp";
 			reg = <0>;
+			#cooling-cells = <2>;
 		};
 
 		cpu@1 {
@@ -78,6 +79,7 @@ 
 			cci-control-port = <&cci_control0>;
 			enable-method = "allwinner,sun8i-a83t-smp";
 			reg = <1>;
+			#cooling-cells = <2>;
 		};
 
 		cpu@2 {
@@ -87,6 +89,7 @@ 
 			cci-control-port = <&cci_control0>;
 			enable-method = "allwinner,sun8i-a83t-smp";
 			reg = <2>;
+			#cooling-cells = <2>;
 		};
 
 		cpu@3 {
@@ -96,6 +99,7 @@ 
 			cci-control-port = <&cci_control0>;
 			enable-method = "allwinner,sun8i-a83t-smp";
 			reg = <3>;
+			#cooling-cells = <2>;
 		};
 
 		cpu100: cpu@100 {
@@ -107,6 +111,7 @@ 
 			cci-control-port = <&cci_control1>;
 			enable-method = "allwinner,sun8i-a83t-smp";
 			reg = <0x100>;
+			#cooling-cells = <2>;
 		};
 
 		cpu@101 {
@@ -116,6 +121,7 @@ 
 			cci-control-port = <&cci_control1>;
 			enable-method = "allwinner,sun8i-a83t-smp";
 			reg = <0x101>;
+			#cooling-cells = <2>;
 		};
 
 		cpu@102 {
@@ -125,6 +131,7 @@ 
 			cci-control-port = <&cci_control1>;
 			enable-method = "allwinner,sun8i-a83t-smp";
 			reg = <0x102>;
+			#cooling-cells = <2>;
 		};
 
 		cpu@103 {
@@ -134,6 +141,7 @@ 
 			cci-control-port = <&cci_control1>;
 			enable-method = "allwinner,sun8i-a83t-smp";
 			reg = <0x103>;
+			#cooling-cells = <2>;
 		};
 	};