From patchwork Fri Mar 29 06:49:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876459 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 134C01575 for ; Fri, 29 Mar 2019 06:50:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F30E628753 for ; Fri, 29 Mar 2019 06:50:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E773728E69; Fri, 29 Mar 2019 06:50:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 299CE28F6C for ; Fri, 29 Mar 2019 06:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X2qRMs+u5U8NuQucAzuUjy113kfaGX+wGjFQF2bZLGg=; b=iyHIBHJLZGVj0H KWPcBjJPISLqnJ7fL+ff0I0AHKxCvKVPZTcP5F0wnU3quSunxCLyaW+F8OPhE0FoT94mdX6TYMMTW FgfarK+IuOyzqz3qLWRt1aeDZeaQBmhltDmCIgqRePyhkdczy7bF5j+ZGlIzQ0qmlRm404hYiqHlX hwRjSEG0eAKYz8N87H4WE5RsZuTkShc9KbV+opyPd1Mru/dg7tlkSGVzHs4W1Mgb7WVzwPRCSIs9B rey6cB2O5IxwnktpyE7aAW/HIhlA2QUBxyF2M3ZJJm4nYLa+NuinO5A+/BhAqpM9MnONXhJoI5PoC cfC39K8RPa+737UuollQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lLJ-0005xX-MT; Fri, 29 Mar 2019 06:50:21 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKf-0003yp-5A for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:45 +0000 Received: by mail-pl1-x641.google.com with SMTP id b11so555879plr.7 for ; Thu, 28 Mar 2019 23:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=m4pOoTrjvfOyO3lHRQoZI3YMKtiCY3JviBbDnHNKrZw=; b=vbdKKoXViIM/SovhysLeQXfHIVYG/D4nV9xP5yW5NZ+wAfQ+AjPJujO7Jje835EFof 4tXzapRiS36ccIrdV+mLfOszyR+PHQ7keR5yfyjE0JueDZ+m2QTAD0PxbFDxHj+vqINh FOzsp1lXZtXSnP3vSweHCg0m10zC7gXsuSRw4NmIP6zOVwJl7Dzq+MErSBew2XMJ5hy3 3v0eaOWGaSlL+kdmQA/MrOv0dhwUX8WhNvwH8gbJcohL8sc/Dl0IoZ5AhaTVorYkQktB XWMNipRieOA3tmCnbwk5FXAe05ClKoGjGYrUsC6+qCCflkBQXmqtLtj/NsmZb5PBZZmO 7l+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m4pOoTrjvfOyO3lHRQoZI3YMKtiCY3JviBbDnHNKrZw=; b=b/KswKzD/50cl7AILtLprWc98OEhbHJIpAlWzIQDRL2DlznOr5M4cBJyUMzG3gaz2f M4D4QU0kxa1hyOBrTzACHDVvNGdYoXjMaXAIE2sYhYB7br7DcTMss63wvdGyA4nbPM2U 7os6XCNXaD0F5MuMCIx268kSCuWkoq8qlKDm68qU9Jph0VeMtKvKDc2rqRg15wfSBJHD VYAv6Ysq7E4DXQP+1gTThQHJgmxwQjq9hxQvQiw5qJwNd+BDUrruji89TSUW9IaVsEC0 7HnsSmjoiemVxEj2Q2s/Vst52JBUfHTqZDxoyZdOLrLjobdi/QzZJDyaL54I+P5Mow6H qn6Q== X-Gm-Message-State: APjAAAUVBBY73O7wBPz/EB/KFEdx6/lFJMAO5pFYEySIo6idk5Nmjj+h o5S8jRf8uVDOdFpBFD/FKTQe/GkS X-Google-Smtp-Source: APXvYqze/oP0qjRXMP8y7FGSppGFqi5zNAs7vi/n5aMY6ZrDInjtpFmXY971ohTMpMPSRFLOo0haGA== X-Received: by 2002:a17:902:2aca:: with SMTP id j68mr270129plb.233.1553842180433; Thu, 28 Mar 2019 23:49:40 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:39 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 4/9] ARM: dts: imx6ul: Specify IMX6UL_CLK_IPG as "ipg" clock to SDMA Date: Thu, 28 Mar 2019 23:49:19 -0700 Message-Id: <20190329064924.8728-4-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234941_363901_006B4681 X-CRM114-Status: GOOD ( 13.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6UL_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX6UL_CLK_IPG as "ipg" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx6ul.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index a77bbcae4571..bbf010c73336 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot/dts/imx6ul.dtsi @@ -708,7 +708,7 @@ "fsl,imx35-sdma"; reg = <0x020ec000 0x4000>; interrupts = ; - clocks = <&clks IMX6UL_CLK_SDMA>, + clocks = <&clks IMX6UL_CLK_IPG>, <&clks IMX6UL_CLK_SDMA>; clock-names = "ipg", "ahb"; #dma-cells = <3>;