From patchwork Fri Mar 29 06:49:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10876463 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80E5D139A for ; Fri, 29 Mar 2019 06:50:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E0B128EB8 for ; Fri, 29 Mar 2019 06:50:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6258328F45; Fri, 29 Mar 2019 06:50:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DEE93290CD for ; Fri, 29 Mar 2019 06:50:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=845rvnqvogq8VQPQN4gVzTKf8XkxVNSnAxDmGJxV0eg=; b=sYQmtpwiykp7bg Q/A2ZsgVHiWHmI/THa//0hWRsPwPfLqQN3RmolgypwYGrBvlK1/WBAaswNkeBlhU2c8H8bawK7J7i o14hLcpwVnK5lGE6X/t2mx6OvClXHEkPc6hGo65sCOEloyx7/Fp4P0FQDexx/gC9DbPDj4iP6P/yg JLI8XcZUGodIDjwuvQTL5F+tZ8Tj4iCklkkmxy2EDInQpHbikqEqKL8G08/uzPCjjak/GS49fgqTU QYcC702T80ls39aeoHLw4nVq4UADRtlz1RpgrQZIlM5LYWm9PWXxUNqhnuPhmEJpyYHWvTMvpuwka 9tRvQja9M4HRfkLiwYEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lLe-0006QG-Pv; Fri, 29 Mar 2019 06:50:42 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9lKj-00045C-1i for linux-arm-kernel@lists.infradead.org; Fri, 29 Mar 2019 06:49:49 +0000 Received: by mail-pl1-x642.google.com with SMTP id q6so565383pll.4 for ; Thu, 28 Mar 2019 23:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=14vBhqFf5cJryvoCa3IsFyVfRVbgmQyJmJY/JUXSOH8=; b=bzYiADF+z5x4y+NuS5hTb/LAfuQlw750wIfQ8yvJUY+ijj2Q9TuMAa2oSHZhNJqKpt m3XKhpZhynAlNtnjXpivMxZ2Cor8wwXK3H7VdgeNXJ6D9PMfVDjOLUpJ7GvFDhHf1oP5 HB9/L1nND9PYa4/Ytg0cxeOhclbAFK1z9rpU2A105YV3aga2FGCzfEKcsw7jRQsgPWLY ttuVg/EQmi5+HVkQw8RJPtzBSMyM0o3asep8jQv0+fceWq+Bjm1cWUhIVVEQ5FenJrkP 6nSPZXCHwvqrOKwQKfxLxkJrWhxd9E+Y30bZlOTRiVQ04yuOr0K/2jwWW8pCi81jp6sZ mBiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=14vBhqFf5cJryvoCa3IsFyVfRVbgmQyJmJY/JUXSOH8=; b=G0f4OA3y5Jtwf1CtGT8bCOOyZKzLLca0KbOgti4+Hu3ZtyjIY5zCePgcejdkL5yAy8 QlhjXYb4llsKVK0ytZR0NcOTiEBWQY/I0n5kNgek5a1uZ5c7iI4raV3lYG9rjrqXqiG4 Br6FRNktEZKjG9+n6OArkT+9hQIDiWwIpqxuXE/SaqtiTYAYv2lmVR2mkMuS/t9HZKep 9apGIQeaOGzj5RncgSOMCbT0BOyTs+ES2pAaY3aBVxcPFBGGyRi8ircUR4y6/dapq4nk 9opST78TtTHX7ouEMFCQv4TtAL0hcNrMUGYEVZYYzFIPxzZ646wbFBUYjKmH5DIWraFq rGrw== X-Gm-Message-State: APjAAAX3RY0TelvEtVZyyYIa1Il6bb/Si/RqxXMFt8RUWV0i+svEKCKb gdVz+mwJ3UrPjA7fWIBarh0= X-Google-Smtp-Source: APXvYqxvEvw/9gvcKhnyndKu5mOIK4ZeAoGtW9V1jSyslFFz3RZMUyzGoT7UD10MJVH9r1nYfkuahQ== X-Received: by 2002:a17:902:6907:: with SMTP id j7mr44998446plk.32.1553842184488; Thu, 28 Mar 2019 23:49:44 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id i5sm1602818pfd.16.2019.03.28.23.49.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Mar 2019 23:49:43 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v3 7/9] ARM: dts: imx53: Specify IMX5_CLK_IPG as "ahb" clock to SDMA Date: Thu, 28 Mar 2019 23:49:22 -0700 Message-Id: <20190329064924.8728-7-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329064924.8728-1-andrew.smirnov@gmail.com> References: <20190329064924.8728-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_234945_512491_8975B96D X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , Angus Ainslie , linux-kernel@vger.kernel.org, Chris Healy , Fabio Estevam , linux-arm-kernel@lists.infradead.org, Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX5_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which results in broken SDMA funtionality. Fix the code to specify IMX5_CLK_AHB as "ahb" clock for SDMA, to avoid detecting incorrect clock ratio. Fixes: 25aaa75df1e6 ("dmaengine: imx-sdma: add clock ratio 1:1 check") Signed-off-by: Andrey Smirnov Cc: Angus Ainslie (Purism) Cc: Chris Healy Cc: Lucas Stach Cc: Fabio Estevam Cc: Shawn Guo Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/imx53.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi index b3300300aabe..9b672ed2486d 100644 --- a/arch/arm/boot/dts/imx53.dtsi +++ b/arch/arm/boot/dts/imx53.dtsi @@ -702,7 +702,7 @@ reg = <0x63fb0000 0x4000>; interrupts = <6>; clocks = <&clks IMX5_CLK_SDMA_GATE>, - <&clks IMX5_CLK_SDMA_GATE>; + <&clks IMX5_CLK_AHB>; clock-names = "ipg", "ahb"; #dma-cells = <3>; fsl,sdma-ram-script-name = "imx/sdma/sdma-imx53.bin";