From patchwork Mon Apr 1 02:24:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Smirnov X-Patchwork-Id: 10878947 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C1968139A for ; Mon, 1 Apr 2019 02:25:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A3D0A28725 for ; Mon, 1 Apr 2019 02:25:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9299928807; Mon, 1 Apr 2019 02:25:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 696F528725 for ; Mon, 1 Apr 2019 02:25:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=64UGdqP4gZeOs8gRfF01Ey7ORGI1vY2MOUeKG70FPsQ=; b=cVGRMnZO3tbyQB Vfj43ezUrrCBoq/vI7b9lFNPnqSGgj6/nP07YMNS4RJ1I1d7tz5dnM0QNBj8QyeSbydX24Mu1DWGB kWTm66WHsOa6386oenWoEuS+BSiY0DvCFdBxO9M9kXMT8DoRqnqXYyYhXkkUzb4iuQHYDhgJIrTPL tih4HQ3Xf6FnHxVMjjXZSlII3kr3gfzs8KxmkqkHcGMldQNbtI1dinal+096scWb9wfEO/T7fC1UN Ah8B36mjoJiFBJRPHPUGNY6x5oV7cZSU32ViH95RF7j/i6RRpoafa3VmShtuKGMABb/ZH8Uz4YL5V rHBZH5SMA03z3F8qA+/Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAmdL-0008Ht-60; Mon, 01 Apr 2019 02:25:11 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAmcj-0006uH-7s for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 02:24:36 +0000 Received: by mail-pf1-x443.google.com with SMTP id c207so3747603pfc.7 for ; Sun, 31 Mar 2019 19:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dp+KAOig4MbV+uJnwASkViJP+U3MnsD8F6PLsh9jNDk=; b=Cfs4cUC57AzT6qfOgV5uyJwIhzXkHn1HpUJZ2oYsCNL0IxnDJ5CcvarcEQLoHG0iZ9 fxzocSPX+87tFRwgXIbL4f2LSPHXnsFBb8DDm9qgm+G8pGMAq8+fN47CwSlCp44SWObT aeHpjhUTC0IL5TucCvDhJ5gNi9OfxMHQYjzJEMOq02BFIvmXzAYNgCv4Ynlpgy6SgHit bT0wn/eBz03l8DOEBcMBsQbATVW/jeY8r2WTi6oSBhXc8D4Bf5HmNG+HtNX5hCd5yCqx 5xcKgvN4g/dE3ZpxT69ewdtE7JhgopVte9tgNDZzqg5cja9bMuO+Wu7qxO7C1pNWhq8U 6p1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dp+KAOig4MbV+uJnwASkViJP+U3MnsD8F6PLsh9jNDk=; b=QPE695Ae4GMXH66ZBiK8pSOIru8Q2KXwyk5AByrELLhpigqUAcJXk99jAfVpAxAhoS +iE0AWGB6JEcbNawa7pB1v+F6mbV7h6C1/ITWzGxS2uLyBWVMtlHDmv5sS4hZYLJoZhl 8EdXUE5C3ucLRrIkC3EoChgTlDoMN4EuCrOqm9KRZ/rxj+bTbzAo6xPZu+UWiyyv59GP peFiExWjiO2da/SmFMEj6Mz9oqBeppoO3DNnCv/XUrA7PsgzBWKDn+I87cQQzlC/zUWT QqBjqpOPNXEZiEeEA/0orQud1DXA2d6Vbw/CJlnHPm0+GgyDcfDXmCmGhlg7ttJUCq/w E8Aw== X-Gm-Message-State: APjAAAVZhW1AXZsaULDsfjGmF1CrMi4RlIGjPHydJzaZidWpgI+qLnHY Gi9cV1xJKdSbgKnRZBsfLqM= X-Google-Smtp-Source: APXvYqx/gJOTqXTew+v5QYd4wK3uMpnMTTNnjlDP9Tjx5sIrztjRYlPDjTBGwI9HS3ygaFEz/G6ikw== X-Received: by 2002:a63:945:: with SMTP id 66mr25690827pgj.128.1554085472375; Sun, 31 Mar 2019 19:24:32 -0700 (PDT) Received: from squirtle.lan (c-24-22-235-96.hsd1.wa.comcast.net. [24.22.235.96]) by smtp.gmail.com with ESMTPSA id n82sm13597289pfi.63.2019.03.31.19.24.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 31 Mar 2019 19:24:31 -0700 (PDT) From: Andrey Smirnov To: Shawn Guo Subject: [PATCH v4 3/5] arm64: dts: imx8mq: Combine PCIE power domains Date: Sun, 31 Mar 2019 19:24:11 -0700 Message-Id: <20190401022413.6682-4-andrew.smirnov@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190401022413.6682-1-andrew.smirnov@gmail.com> References: <20190401022413.6682-1-andrew.smirnov@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190331_192433_490920_878E4A25 X-CRM114-Status: GOOD ( 12.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "A.s. Dong" , Richard Zhu , linux-arm-kernel@lists.infradead.org, Andrey Smirnov , linux-kernel@vger.kernel.org, linux-imx@nxp.com, Fabio Estevam , Leonard Crestez , Chris Healy , Lucas Stach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP According to NXP's FAE feedback and a comment in ATF firmware, PCIE1 and PCIE2 power domains can't really be used independently. Due to shared reset line both power domains have to be turned on at the same time. Account for that quirk by combining PCIE power domains into a single 'pgc_pcie' power domain. Signed-off-by: Andrey Smirnov Reviewed-by: Lucas Stach Cc: Shawn Guo Cc: Fabio Estevam Cc: Chris Healy Cc: Lucas Stach Cc: Leonard Crestez Cc: "A.s. Dong" Cc: Richard Zhu Cc: linux-imx@nxp.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Reviewed-by: Fabio Estevam --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index 656f7cb97703..d7b564501fa4 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -472,9 +472,25 @@ reg = ; }; - pgc_pcie1: power-domain@1 { + /* + * As per comment in ATF source code: + * + * PCIE1 and PCIE2 share the + * same reset signal, if we + * power down PCIE2, PCIE1 + * will be held in reset too. + * + * So instead of creating two + * separate power domains for + * PCIE1 and PCIE2 we create a + * link between both and use + * it as a shared PCIE power + * domain. + */ + pgc_pcie: power-domain@1 { #power-domain-cells = <0>; reg = ; + power-domains = <&pgc_pcie2>; }; pgc_otg1: power-domain@2 {