From patchwork Fri Apr 5 11:34:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Saenz Julienne X-Patchwork-Id: 10887233 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9A3991390 for ; Fri, 5 Apr 2019 11:34:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F38528691 for ; Fri, 5 Apr 2019 11:34:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71359289CF; Fri, 5 Apr 2019 11:34:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F04A728691 for ; Fri, 5 Apr 2019 11:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QNPsdlyUzeig5SbahM8wcNud0kMgxJNkkdf4F1BwvNE=; b=EpU9PgwhusvcCI Nwvl7PBr2bKPHkIuKwPErGxL2JpYNKld9vvFIM/t31ccCMGVTPJ8Zu0Xh+n9kWO12nw9kM5US0qry r5O0wMuneZEvUPfty7SanWOHXITVE1ESanuH2sFRItd4BGIMZbaHRX6y4nafjQAAykn2TPsJALBlH xpd1dgez8uozdMWAFQz2abWTVGkb/MVPLz/h36ZPbj4vh9SKhRGMdgohuDo7ooDkcTcEWHQyWvNZ4 GUhFmG0HYRzEMDng50OXGZm0rFeJEtLAWXDbEZG7McUUCI2/y7fhPfxXgkMIO9HXqyYKmScJacV2j 3/975l/PrWyHmQM8DQ0g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCN7X-0005CL-7I; Fri, 05 Apr 2019 11:34:55 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hCN7M-00052a-TX; Fri, 05 Apr 2019 11:34:46 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id F0877AD7B; Fri, 5 Apr 2019 11:34:41 +0000 (UTC) From: Nicolas Saenz Julienne To: linux-kernel@vger.kernel.org Subject: [PATCH 3/3] staging: vchiq: make wait events interruptible Date: Fri, 5 Apr 2019 13:34:22 +0200 Message-Id: <20190405113423.14495-4-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190405113423.14495-1-nsaenzjulienne@suse.de> References: <20190405113423.14495-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190405_043445_097557_2F0C04B8 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefan.wahren@i2se.com, devel@driverdev.osuosl.org, Greg Kroah-Hartman , phil@raspberrypi.org, eric@anholt.net, linux-rpi-kernel@lists.infradead.org, Nicolas Saenz Julienne , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The killable version of wait_event() is meant to be used on situations where it's not meant to fail at all costs, but still have the convenience of being able to kill it if really necessary. For instance it's used while waiting on an page write on some file systems. Wait events in VCHIQ don't fit this criteria, as it's mainly used as an interface to V4L2 and ALSA devices. Signed-off-by: Nicolas Saenz Julienne --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 50189223f05b..41257a1df49d 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -431,7 +431,7 @@ remote_event_wait(wait_queue_head_t *wq, struct remote_event *event) if (!event->fired) { event->armed = 1; dsb(sy); - if (wait_event_killable(*wq, event->fired)) { + if (wait_event_interruptible(*wq, event->fired)) { event->armed = 0; return 0; }