From patchwork Fri Apr 19 22:18:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10909835 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8F5DE922 for ; Fri, 19 Apr 2019 22:19:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7F39C28DA9 for ; Fri, 19 Apr 2019 22:19:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 72E2B28DAB; Fri, 19 Apr 2019 22:19:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 184EA28DA9 for ; Fri, 19 Apr 2019 22:19:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C8CbzyXkHnmmSGFhIRlT7dOOIZGUUaGqKsaky7qij2Q=; b=dAHc2Ml3tq7+zm QrbZSQv054Wf2QNExgV8K0DtmCFwFbrKplra3YD0PoigbjJMgSk+Ip2FYMcZjWWBTv0e46gQcSscj km0wVJCfGjLdgSa9cc9vS2vugQfUBc6G/d7vMVuEHh5a1e6X7bloqT5J+Y6wzv0eS+SxuqTwx8bB5 5aYHQHySnnB5U3JMM+HB0dIlBCSdPRitNco/lK2CA+ybklBYImfsOxOoyhlQ/YPBfsgpcoVipOjbd X1b5hOne5XW7+ADHrROA8Ll0wEPOUE6TLsOD5k6WSkIWYC//96rJGtfoEEAwobY189kvmhTgKc1Qc RvPvpAiqON0do/BVjUKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHbqa-0000ER-Bf; Fri, 19 Apr 2019 22:19:04 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hHbqF-0008KS-5e for linux-arm-kernel@lists.infradead.org; Fri, 19 Apr 2019 22:18:46 +0000 Received: by mail-pl1-x642.google.com with SMTP id o7so888012pll.13 for ; Fri, 19 Apr 2019 15:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pmFy/F7Y+9nJ0AHy8XDviXaJUnstsHwng/faFGXf8Ko=; b=Aza8PDw+bba+FVBbZ5IcJt3QhHpEhdCJye0rT2ueBDpBTtObY8A7byyPpsF8IK+f21 l+5Yl+UKDVWSbu4vINlQCMt/ZMTmuy913V7JOu6BiydfNIlQ32WpidjWqgT/4uUVXDba /97k401A2Cy2Sg4mggDKBlUI9/GFr5Fv7kBrI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pmFy/F7Y+9nJ0AHy8XDviXaJUnstsHwng/faFGXf8Ko=; b=M3UOO+kVzzLXuQbIdIKPBmkTJ15uV74mvn2d+bfGkUfFz5H3OG6Muc8gtwOlNCv0Nf dy8iN3jQnR0p6AXx4iCpjJfsYx7vVq/zSaQmK4r3Io8YQmH4dPO1+zQ9G/asCSJwomF8 S0RXnIx8WzMMzIBoz+xlWE9eENXNfMaqaJ0iLEGuIwH1MN+0fRx4sG+tK3VUEVH1HADW iwLVgbbeAp9AWx1mQwQvRUv6TdwNZNgqINe1RRxzy7RdIPntsZKXKje1qoxe70dTxWCf T7t+o3WE0Y/3f0mq5RwqPdoWB6GPTxxKrV71hDxTM/u+v+ABCRNgIbBOkHjAiMa3IpJE bSQA== X-Gm-Message-State: APjAAAWNie2KcgmAiki6zJA6mAU33NStekVFMpo0tJdgLHBth2jkgiG/ TCm8brRfkl7VoMUydy9JoI/Vew== X-Google-Smtp-Source: APXvYqwD4Qo3e9qUi57ZVQh4GPpV+TC78quohbp4D0Vaxq2cmqU8sakD0iIm4mwYRaEvoGRpOT4Bfg== X-Received: by 2002:a17:902:b20f:: with SMTP id t15mr6301266plr.341.1555712322413; Fri, 19 Apr 2019 15:18:42 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id a3sm8162536pfn.182.2019.04.19.15.18.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Apr 2019 15:18:41 -0700 (PDT) From: Douglas Anderson To: Russell King Subject: [PATCH 2/2] ARM: errata: add support for A12/A17 errata CR711784 Date: Fri, 19 Apr 2019 15:18:03 -0700 Message-Id: <20190419221803.99322-2-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.593.g511ec345e18-goog In-Reply-To: <20190419221803.99322-1-dianders@chromium.org> References: <20190419221803.99322-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190419_151843_211281_96058F6E X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Florian Fainelli , Salva.Climent@arm.com, Arnd Bergmann , Masahiro Yamada , Marc Zyngier , robin.murphy@arm.com, Tony Lindgren , Palmer Dabbelt , will.deacon@arm.com, bbatacha@arm.com, Douglas Anderson , Ard Biesheuvel , linux-rockchip@lists.infradead.org, Paul Burton , mka@chromium.org, Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, sonnyrao@chromium.org, linux-kernel@vger.kernel.org, heiko@sntech.de Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This adds a code for turning on chicken bit 11, which appears to avoid a potential CPU deadlock that could occur. The exact set of instruction needed to trigger this errata is not totaly known but we have a high level of confidence that the problem is fixed by setting chicken bit 11. All details are in http://crbug.com/711784 This erratum has no known number and thus I have tagged it CR711784 (after the Chrome OS bug number). I have created separate A12 / A17 configs to match how the rest of the A12 / A17 errata is handled. Signed-off-by: Douglas Anderson --- arch/arm/Kconfig | 18 ++++++++++++++++++ arch/arm/mm/proc-v7.S | 10 ++++++++++ 2 files changed, 28 insertions(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 4376fe74f95e..34ec9039206b 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1181,6 +1181,13 @@ config ARM_ERRATA_857271 hang. The workaround is expected to have a negligible performance impact. +config ARM_ERRATA_CR711784_A12 + bool "ARM errata: A12: conditional instructions can lead to a CPU hang" + depends on CPU_V7 + help + This option enables the workaround for a Cortex-A12 erratum without a + number. The problems are best described in https://crbug.com/711784 + config ARM_ERRATA_852421 bool "ARM errata: A17: DMB ST might fail to create order between stores" depends on CPU_V7 @@ -1212,6 +1219,17 @@ config ARM_ERRATA_857272 config option from the A12 erratum due to the way errata are checked for and handled. +config ARM_ERRATA_CR711784_A17 + bool "ARM errata: A17: conditional instructions can lead to a CPU hang" + depends on CPU_V7 + help + This option enables the workaround for a Cortex-A17 erratum without a + number. The problems are best described in https://crbug.com/711784 + This erratum is not known to be fixed in any A17 revision. + This is identical to Cortex-A12 erratum CR711784. It is a separate + config option from the A12 erratum due to the way errata are checked + for and handled. + endmenu source "arch/arm/common/Kconfig" diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S index cd2accbab844..a5156ea734ee 100644 --- a/arch/arm/mm/proc-v7.S +++ b/arch/arm/mm/proc-v7.S @@ -396,6 +396,11 @@ __ca12_errata: mrc p15, 0, r10, c15, c0, 1 @ read diagnostic register orr r10, r10, #1 << 10 @ set bit #10 mcr p15, 0, r10, c15, c0, 1 @ write diagnostic register +#endif +#ifdef CONFIG_ARM_ERRATA_CR711784_A12 + mrc p15, 0, r10, c15, c0, 1 @ read diagnostic register + orr r10, r10, #1 << 11 @ set bit #11 + mcr p15, 0, r10, c15, c0, 1 @ write diagnostic register #endif b __errata_finish @@ -416,6 +421,11 @@ __ca17_errata: mrc p15, 0, r10, c15, c0, 1 @ read diagnostic register orr r10, r10, #1 << 10 @ set bit #10 mcr p15, 0, r10, c15, c0, 1 @ write diagnostic register +#endif +#ifdef CONFIG_ARM_ERRATA_CR711784_A17 + mrc p15, 0, r10, c15, c0, 1 @ read diagnostic register + orr r10, r10, #1 << 11 @ set bit #11 + mcr p15, 0, r10, c15, c0, 1 @ write diagnostic register #endif b __errata_finish