| Message ID | 20190509070657.18281-1-chuanhua.han@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: ls1028a: fix watchdog device node | expand |
On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote: > ls1028a platform uses sp805 watchdog, and use 1/16 platform clock as > timer clock, this patch fix device tree node. > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > --- > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index b04581249f0b..1510b1858246 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -285,13 +285,18 @@ > #interrupt-cells = <2>; > }; > > - wdog0: watchdog@23c0000 { > - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt"; > - reg = <0x0 0x23c0000 0x0 0x10000>; > - interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clockgen 4 1>; > - big-endian; > - status = "disabled"; > + cluster1_core0_watchdog: wdt@c000000 { Keep 'watchdog' as the node name, and keep nodes sort in unit-address. Shawn > + compatible = "arm,sp805", "arm,primecell"; > + reg = <0x0 0xc000000 0x0 0x1000>; > + clocks = <&clockgen 4 15>, <&clockgen 4 15>; > + clock-names = "apb_pclk", "wdog_clk"; > + }; > + > + cluster1_core1_watchdog: wdt@c010000 { > + compatible = "arm,sp805", "arm,primecell"; > + reg = <0x0 0xc010000 0x0 0x1000>; > + clocks = <&clockgen 4 15>, <&clockgen 4 15>; > + clock-names = "apb_pclk", "wdog_clk"; > }; > > sata: sata@3200000 { > -- > 2.17.1 >
> -----Original Message----- > From: Shawn Guo <shawnguo@kernel.org> > Sent: 2019年5月17日 10:38 > To: Chuanhua Han <chuanhua.han@nxp.com> > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com> > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node > > Caution: EXT Email > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote: > > ls1028a platform uses sp805 watchdog, and use 1/16 platform clock as > > timer clock, this patch fix device tree node. > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com> > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > > --- > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 > > ++++++++++++------- > > 1 file changed, 12 insertions(+), 7 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > index b04581249f0b..1510b1858246 100644 > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > @@ -285,13 +285,18 @@ > > #interrupt-cells = <2>; > > }; > > > > - wdog0: watchdog@23c0000 { > > - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt"; > > - reg = <0x0 0x23c0000 0x0 0x10000>; > > - interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>; > > - clocks = <&clockgen 4 1>; > > - big-endian; > > - status = "disabled"; > > + cluster1_core0_watchdog: wdt@c000000 { > > Keep 'watchdog' as the node name, Thanks for your replay Do you mean replace the ‘wdt’ with ‘watchdog’? and keep nodes sort in unit-address. What does this mean? > > Shawn > > > + compatible = "arm,sp805", "arm,primecell"; > > + reg = <0x0 0xc000000 0x0 0x1000>; > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>; > > + clock-names = "apb_pclk", "wdog_clk"; > > + }; > > + > > + cluster1_core1_watchdog: wdt@c010000 { > > + compatible = "arm,sp805", "arm,primecell"; > > + reg = <0x0 0xc010000 0x0 0x1000>; > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>; > > + clock-names = "apb_pclk", "wdog_clk"; > > }; > > > > sata: sata@3200000 { > > -- > > 2.17.1 > >
> -----Original Message----- > From: Chuanhua Han > Sent: Friday, May 17, 2019 1:11 AM > To: Shawn Guo <shawnguo@kernel.org> > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; linux-arm- > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node > > > > > -----Original Message----- > > From: Shawn Guo <shawnguo@kernel.org> > > Sent: 2019年5月17日 10:38 > > To: Chuanhua Han <chuanhua.han@nxp.com> > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; > > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > > linux-kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com> > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device > > node > > > > Caution: EXT Email > > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote: > > > ls1028a platform uses sp805 watchdog, and use 1/16 platform clock as > > > timer clock, this patch fix device tree node. > > > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com> > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > > > --- > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 > > > ++++++++++++------- > > > 1 file changed, 12 insertions(+), 7 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > index b04581249f0b..1510b1858246 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > @@ -285,13 +285,18 @@ > > > #interrupt-cells = <2>; > > > }; > > > > > > - wdog0: watchdog@23c0000 { > > > - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt"; > > > - reg = <0x0 0x23c0000 0x0 0x10000>; > > > - interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>; > > > - clocks = <&clockgen 4 1>; > > > - big-endian; > > > - status = "disabled"; > > > + cluster1_core0_watchdog: wdt@c000000 { > > > > Keep 'watchdog' as the node name, > Thanks for your replay > Do you mean replace the ‘wdt’ with ‘watchdog’? > and keep nodes sort in unit-address. > What does this mean? That means order the nodes by the addresses (e.g. c000000, c010000) > > > > Shawn > > > > > + compatible = "arm,sp805", "arm,primecell"; > > > + reg = <0x0 0xc000000 0x0 0x1000>; > > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>; > > > + clock-names = "apb_pclk", "wdog_clk"; > > > + }; > > > + > > > + cluster1_core1_watchdog: wdt@c010000 { > > > + compatible = "arm,sp805", "arm,primecell"; > > > + reg = <0x0 0xc010000 0x0 0x1000>; > > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>; > > > + clock-names = "apb_pclk", "wdog_clk"; > > > }; > > > > > > sata: sata@3200000 { > > > -- > > > 2.17.1 > > >
> -----Original Message----- > From: Leo Li > Sent: 2019年5月18日 6:01 > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo > <shawnguo@kernel.org> > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > <ying.zhang22455@nxp.com> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node > > > > > -----Original Message----- > > From: Chuanhua Han > > Sent: Friday, May 17, 2019 1:11 AM > > To: Shawn Guo <shawnguo@kernel.org> > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; linux-arm- > > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com> > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > device node > > > > > > > > > -----Original Message----- > > > From: Shawn Guo <shawnguo@kernel.org> > > > Sent: 2019年5月17日 10:38 > > > To: Chuanhua Han <chuanhua.han@nxp.com> > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; > > > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > > > linux-kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com> > > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device > > > node > > > > > > Caution: EXT Email > > > > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote: > > > > ls1028a platform uses sp805 watchdog, and use 1/16 platform clock > > > > as timer clock, this patch fix device tree node. > > > > > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com> > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > > > > --- > > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 > > > > ++++++++++++------- > > > > 1 file changed, 12 insertions(+), 7 deletions(-) > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > index b04581249f0b..1510b1858246 100644 > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > @@ -285,13 +285,18 @@ > > > > #interrupt-cells = <2>; > > > > }; > > > > > > > > - wdog0: watchdog@23c0000 { > > > > - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt"; > > > > - reg = <0x0 0x23c0000 0x0 0x10000>; > > > > - interrupts = <GIC_SPI 59 > IRQ_TYPE_LEVEL_HIGH>; > > > > - clocks = <&clockgen 4 1>; > > > > - big-endian; > > > > - status = "disabled"; > > > > + cluster1_core0_watchdog: wdt@c000000 { > > > > > > Keep 'watchdog' as the node name, > > Thanks for your replay > > Do you mean replace the ‘wdt’ with ‘watchdog’? > > and keep nodes sort in unit-address. > > What does this mean? > > That means order the nodes by the addresses (e.g. c000000, c010000) The current order is correct（The first is c000000, then c000000）. > > > > > > > Shawn > > > > > > > + compatible = "arm,sp805", "arm,primecell"; > > > > + reg = <0x0 0xc000000 0x0 0x1000>; > > > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>; > > > > + clock-names = "apb_pclk", "wdog_clk"; > > > > + }; > > > > + > > > > + cluster1_core1_watchdog: wdt@c010000 { > > > > + compatible = "arm,sp805", "arm,primecell"; > > > > + reg = <0x0 0xc010000 0x0 0x1000>; > > > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>; > > > > + clock-names = "apb_pclk", "wdog_clk"; > > > > }; > > > > > > > > sata: sata@3200000 { > > > > -- > > > > 2.17.1 > > > >
> -----Original Message----- > From: Chuanhua Han > Sent: Tuesday, May 21, 2019 8:00 AM > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org> > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > <ying.zhang22455@nxp.com> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node > > > > > -----Original Message----- > > From: Leo Li > > Sent: 2019年5月18日 6:01 > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo > > <shawnguo@kernel.org> > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > > <ying.zhang22455@nxp.com> > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > device node > > > > > > > > > -----Original Message----- > > > From: Chuanhua Han > > > Sent: Friday, May 17, 2019 1:11 AM > > > To: Shawn Guo <shawnguo@kernel.org> > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; linux-arm- > > > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- > > > kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com> > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > device node > > > > > > > > > > > > > -----Original Message----- > > > > From: Shawn Guo <shawnguo@kernel.org> > > > > Sent: 2019年5月17日 10:38 > > > > To: Chuanhua Han <chuanhua.han@nxp.com> > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; > > > > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org; > > > > linux-kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com> > > > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > > device node > > > > > > > > Caution: EXT Email > > > > > > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote: > > > > > ls1028a platform uses sp805 watchdog, and use 1/16 platform > > > > > clock as timer clock, this patch fix device tree node. > > > > > > > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com> > > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > > > > > --- > > > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 > > > > > ++++++++++++------- > > > > > 1 file changed, 12 insertions(+), 7 deletions(-) > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > index b04581249f0b..1510b1858246 100644 > > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > @@ -285,13 +285,18 @@ > > > > > #interrupt-cells = <2>; > > > > > }; > > > > > > > > > > - wdog0: watchdog@23c0000 { > > > > > - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt"; > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>; > > > > > - interrupts = <GIC_SPI 59 > > IRQ_TYPE_LEVEL_HIGH>; > > > > > - clocks = <&clockgen 4 1>; > > > > > - big-endian; > > > > > - status = "disabled"; > > > > > + cluster1_core0_watchdog: wdt@c000000 { > > > > > > > > Keep 'watchdog' as the node name, > > > Thanks for your replay > > > Do you mean replace the ‘wdt’ with ‘watchdog’? > > > and keep nodes sort in unit-address. > > > What does this mean? > > > > That means order the nodes by the addresses (e.g. c000000, c010000) > The current order is correct（The first is c000000, then c000000）. But they are added after gpio@2320000 and before sata@3200000. > > > > > > > > > > Shawn > > > > > > > > > + compatible = "arm,sp805", "arm,primecell"; > > > > > + reg = <0x0 0xc000000 0x0 0x1000>; > > > > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>; > > > > > + clock-names = "apb_pclk", "wdog_clk"; > > > > > + }; > > > > > + > > > > > + cluster1_core1_watchdog: wdt@c010000 { > > > > > + compatible = "arm,sp805", "arm,primecell"; > > > > > + reg = <0x0 0xc010000 0x0 0x1000>; > > > > > + clocks = <&clockgen 4 15>, <&clockgen 4 15>; > > > > > + clock-names = "apb_pclk", "wdog_clk"; > > > > > }; > > > > > > > > > > sata: sata@3200000 { > > > > > -- > > > > > 2.17.1 > > > > >
> -----Original Message----- > From: Leo Li > Sent: 2019年5月22日 4:15 > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo > <shawnguo@kernel.org> > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > <ying.zhang22455@nxp.com> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node > > > > > -----Original Message----- > > From: Chuanhua Han > > Sent: Tuesday, May 21, 2019 8:00 AM > > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org> > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > > <ying.zhang22455@nxp.com> > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > device node > > > > > > > > > -----Original Message----- > > > From: Leo Li > > > Sent: 2019年5月18日 6:01 > > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo > > > <shawnguo@kernel.org> > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > > > <ying.zhang22455@nxp.com> > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > device node > > > > > > > > > > > > > -----Original Message----- > > > > From: Chuanhua Han > > > > Sent: Friday, May 17, 2019 1:11 AM > > > > To: Shawn Guo <shawnguo@kernel.org> > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; linux-arm- > > > > kernel@lists.infradead.org; devicetree@vger.kernel.org; linux- > > > > kernel@vger.kernel.org; Ying Zhang <ying.zhang22455@nxp.com> > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > > device node > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Shawn Guo <shawnguo@kernel.org> > > > > > Sent: 2019年5月17日 10:38 > > > > > To: Chuanhua Han <chuanhua.han@nxp.com> > > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; > > > > > linux-arm-kernel@lists.infradead.org; > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying > > > > > Zhang <ying.zhang22455@nxp.com> > > > > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > > > device node > > > > > > > > > > Caution: EXT Email > > > > > > > > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote: > > > > > > ls1028a platform uses sp805 watchdog, and use 1/16 platform > > > > > > clock as timer clock, this patch fix device tree node. > > > > > > > > > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com> > > > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > > > > > > --- > > > > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 > > > > > > ++++++++++++------- > > > > > > 1 file changed, 12 insertions(+), 7 deletions(-) > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > index b04581249f0b..1510b1858246 100644 > > > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > @@ -285,13 +285,18 @@ > > > > > > #interrupt-cells = <2>; > > > > > > }; > > > > > > > > > > > > - wdog0: watchdog@23c0000 { > > > > > > - compatible = "fsl,ls1028a-wdt", > "fsl,imx21-wdt"; > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>; > > > > > > - interrupts = <GIC_SPI 59 > > > IRQ_TYPE_LEVEL_HIGH>; > > > > > > - clocks = <&clockgen 4 1>; > > > > > > - big-endian; > > > > > > - status = "disabled"; > > > > > > + cluster1_core0_watchdog: wdt@c000000 { > > > > > > > > > > Keep 'watchdog' as the node name, > > > > Thanks for your replay > > > > Do you mean replace the ‘wdt’ with ‘watchdog’? > > > > and keep nodes sort in unit-address. > > > > What does this mean? > > > > > > That means order the nodes by the addresses (e.g. c000000, c010000) > > The current order is correct（The first is c000000, then c000000）. > > But they are added after gpio@2320000 and before sata@3200000. I changed and made the second version of the patch, but I found the following error when I executed ./scripts/checkpatch.pl xxx.patch to check the patch: WARNING: DT compatible string vendor "arm" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351: + compatible = "arm,sp805", "arm,primecell"; However, there is no vendor-prefixes.txt file in the ./Documentation/devicetree/bindings/ directory, only vendor-prefixes.yaml. Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml. Request help，thanks > > > > > > > > > > > > > > Shawn > > > > > > > > > > > + compatible = "arm,sp805", "arm,primecell"; > > > > > > + reg = <0x0 0xc000000 0x0 0x1000>; > > > > > > + clocks = <&clockgen 4 15>, <&clockgen 4 > 15>; > > > > > > + clock-names = "apb_pclk", "wdog_clk"; > > > > > > + }; > > > > > > + > > > > > > + cluster1_core1_watchdog: wdt@c010000 { > > > > > > + compatible = "arm,sp805", "arm,primecell"; > > > > > > + reg = <0x0 0xc010000 0x0 0x1000>; > > > > > > + clocks = <&clockgen 4 15>, <&clockgen 4 > 15>; > > > > > > + clock-names = "apb_pclk", "wdog_clk"; > > > > > > }; > > > > > > > > > > > > sata: sata@3200000 { > > > > > > -- > > > > > > 2.17.1 > > > > > >
> -----Original Message----- > From: Chuanhua Han > Sent: Wednesday, May 22, 2019 1:26 AM > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org> > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > <ying.zhang22455@nxp.com> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node > > > > > -----Original Message----- > > From: Leo Li > > Sent: 2019年5月22日 4:15 > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo > > <shawnguo@kernel.org> > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > > <ying.zhang22455@nxp.com> > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > device node > > > > > > > > > -----Original Message----- > > > From: Chuanhua Han > > > Sent: Tuesday, May 21, 2019 8:00 AM > > > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org> > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > > > <ying.zhang22455@nxp.com> > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > device node > > > > > > > > > > > > > -----Original Message----- > > > > From: Leo Li > > > > Sent: 2019年5月18日 6:01 > > > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo > > > > <shawnguo@kernel.org> > > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying > > > > Zhang <ying.zhang22455@nxp.com> > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > > device node > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Chuanhua Han > > > > > Sent: Friday, May 17, 2019 1:11 AM > > > > > To: Shawn Guo <shawnguo@kernel.org> > > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; > > > > > linux-arm- kernel@lists.infradead.org; > > > > > devicetree@vger.kernel.org; linux- kernel@vger.kernel.org; Ying > > > > > Zhang <ying.zhang22455@nxp.com> > > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > > > device node > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Shawn Guo <shawnguo@kernel.org> > > > > > > Sent: 2019年5月17日 10:38 > > > > > > To: Chuanhua Han <chuanhua.han@nxp.com> > > > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying > > > > > > Zhang <ying.zhang22455@nxp.com> > > > > > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > > > > device node > > > > > > > > > > > > Caution: EXT Email > > > > > > > > > > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote: > > > > > > > ls1028a platform uses sp805 watchdog, and use 1/16 platform > > > > > > > clock as timer clock, this patch fix device tree node. > > > > > > > > > > > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com> > > > > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > > > > > > > --- > > > > > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 > > > > > > > ++++++++++++------- > > > > > > > 1 file changed, 12 insertions(+), 7 deletions(-) > > > > > > > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > > index b04581249f0b..1510b1858246 100644 > > > > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > > @@ -285,13 +285,18 @@ > > > > > > > #interrupt-cells = <2>; > > > > > > > }; > > > > > > > > > > > > > > - wdog0: watchdog@23c0000 { > > > > > > > - compatible = "fsl,ls1028a-wdt", > > "fsl,imx21-wdt"; > > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>; > > > > > > > - interrupts = <GIC_SPI 59 > > > > IRQ_TYPE_LEVEL_HIGH>; > > > > > > > - clocks = <&clockgen 4 1>; > > > > > > > - big-endian; > > > > > > > - status = "disabled"; > > > > > > > + cluster1_core0_watchdog: wdt@c000000 { > > > > > > > > > > > > Keep 'watchdog' as the node name, > > > > > Thanks for your replay > > > > > Do you mean replace the ‘wdt’ with ‘watchdog’? > > > > > and keep nodes sort in unit-address. > > > > > What does this mean? > > > > > > > > That means order the nodes by the addresses (e.g. c000000, > > > > c010000) > > > The current order is correct（The first is c000000, then c000000）. > > > > But they are added after gpio@2320000 and before sata@3200000. > I changed and made the second version of the patch, but I found the > following error when I executed ./scripts/checkpatch.pl xxx.patch to check > the patch: > > WARNING: DT compatible string vendor "arm" appears un-documented -- > check ./Documentation/devicetree/bindings/vendor-prefixes.txt > #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351: > + compatible = "arm,sp805", "arm,primecell"; > > However, there is no vendor-prefixes.txt file in > the ./Documentation/devicetree/bindings/ directory, only vendor- > prefixes.yaml. > Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml. Added Rob Herring to the thread. > Request help，thanks > > > > > > > > > > > > > > > > > > Shawn > > > > > > > > > > > > > + compatible = "arm,sp805", "arm,primecell"; > > > > > > > + reg = <0x0 0xc000000 0x0 0x1000>; > > > > > > > + clocks = <&clockgen 4 15>, <&clockgen > > > > > > > + 4 > > 15>; > > > > > > > + clock-names = "apb_pclk", "wdog_clk"; > > > > > > > + }; > > > > > > > + > > > > > > > + cluster1_core1_watchdog: wdt@c010000 { > > > > > > > + compatible = "arm,sp805", "arm,primecell"; > > > > > > > + reg = <0x0 0xc010000 0x0 0x1000>; > > > > > > > + clocks = <&clockgen 4 15>, <&clockgen > > > > > > > + 4 > > 15>; > > > > > > > + clock-names = "apb_pclk", "wdog_clk"; > > > > > > > }; > > > > > > > > > > > > > > sata: sata@3200000 { > > > > > > > -- > > > > > > > 2.17.1 > > > > > > >
Hi, Rob Herring > -----Original Message----- > From: Leo Li > Sent: 2019年5月22日 14:50 > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo > <shawnguo@kernel.org>; Rob Herring <robh@kernel.org> > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > <ying.zhang22455@nxp.com> > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node > > > > > -----Original Message----- > > From: Chuanhua Han > > Sent: Wednesday, May 22, 2019 1:26 AM > > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org> > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > > <ying.zhang22455@nxp.com> > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > device node > > > > > > > > > -----Original Message----- > > > From: Leo Li > > > Sent: 2019年5月22日 4:15 > > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo > > > <shawnguo@kernel.org> > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > > > <ying.zhang22455@nxp.com> > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > device node > > > > > > > > > > > > > -----Original Message----- > > > > From: Chuanhua Han > > > > Sent: Tuesday, May 21, 2019 8:00 AM > > > > To: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org> > > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying > > > > Zhang <ying.zhang22455@nxp.com> > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > > device node > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > From: Leo Li > > > > > Sent: 2019年5月18日 6:01 > > > > > To: Chuanhua Han <chuanhua.han@nxp.com>; Shawn Guo > > > > > <shawnguo@kernel.org> > > > > > Cc: mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying > > > > > Zhang <ying.zhang22455@nxp.com> > > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > > > device node > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Chuanhua Han > > > > > > Sent: Friday, May 17, 2019 1:11 AM > > > > > > To: Shawn Guo <shawnguo@kernel.org> > > > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; > > > > > > linux-arm- kernel@lists.infradead.org; > > > > > > devicetree@vger.kernel.org; linux- kernel@vger.kernel.org; > > > > > > Ying Zhang <ying.zhang22455@nxp.com> > > > > > > Subject: RE: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix > > > > > > watchdog device node > > > > > > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Shawn Guo <shawnguo@kernel.org> > > > > > > > Sent: 2019年5月17日 10:38 > > > > > > > To: Chuanhua Han <chuanhua.han@nxp.com> > > > > > > > Cc: Leo Li <leoyang.li@nxp.com>; mark.rutland@arm.com; > > > > > > > linux-arm-kernel@lists.infradead.org; > > > > > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > > > > Ying Zhang <ying.zhang22455@nxp.com> > > > > > > > Subject: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog > > > > > > > device node > > > > > > > > > > > > > > Caution: EXT Email > > > > > > > > > > > > > > On Thu, May 09, 2019 at 03:06:57PM +0800, Chuanhua Han wrote: > > > > > > > > ls1028a platform uses sp805 watchdog, and use 1/16 > > > > > > > > platform clock as timer clock, this patch fix device tree node. > > > > > > > > > > > > > > > > Signed-off-by: Zhang Ying-22455 <ying.zhang22455@nxp.com> > > > > > > > > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com> > > > > > > > > --- > > > > > > > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 19 > > > > > > > > ++++++++++++------- > > > > > > > > 1 file changed, 12 insertions(+), 7 deletions(-) > > > > > > > > > > > > > > > > diff --git > > > > > > > > a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > > > b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > > > index b04581249f0b..1510b1858246 100644 > > > > > > > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > > > > > > > > @@ -285,13 +285,18 @@ > > > > > > > > #interrupt-cells = <2>; > > > > > > > > }; > > > > > > > > > > > > > > > > - wdog0: watchdog@23c0000 { > > > > > > > > - compatible = "fsl,ls1028a-wdt", > > > "fsl,imx21-wdt"; > > > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>; > > > > > > > > - interrupts = <GIC_SPI 59 > > > > > IRQ_TYPE_LEVEL_HIGH>; > > > > > > > > - clocks = <&clockgen 4 1>; > > > > > > > > - big-endian; > > > > > > > > - status = "disabled"; > > > > > > > > + cluster1_core0_watchdog: wdt@c000000 { > > > > > > > > > > > > > > Keep 'watchdog' as the node name, > > > > > > Thanks for your replay > > > > > > Do you mean replace the ‘wdt’ with ‘watchdog’? > > > > > > and keep nodes sort in unit-address. > > > > > > What does this mean? > > > > > > > > > > That means order the nodes by the addresses (e.g. c000000, > > > > > c010000) > > > > The current order is correct（The first is c000000, then c000000）. > > > > > > But they are added after gpio@2320000 and before sata@3200000. > > I changed and made the second version of the patch, but I found the > > following error when I executed ./scripts/checkpatch.pl xxx.patch to > > check the patch: > > > > WARNING: DT compatible string vendor "arm" appears un-documented -- > > check ./Documentation/devicetree/bindings/vendor-prefixes.txt > > #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351: > > + compatible = "arm,sp805", "arm,primecell"; > > > > However, there is no vendor-prefixes.txt file in the > > ./Documentation/devicetree/bindings/ directory, only vendor- > > prefixes.yaml. > > Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml. > > Added Rob Herring to the thread. > > > Request help，thanks How can I solve this patch check error? Ask for help, thank you! > > > > > > > > > > > > > > > > > > > > > > Shawn > > > > > > > > > > > > > > > + compatible = "arm,sp805", > "arm,primecell"; > > > > > > > > + reg = <0x0 0xc000000 0x0 0x1000>; > > > > > > > > + clocks = <&clockgen 4 15>, > > > > > > > > + <&clockgen > > > > > > > > + 4 > > > 15>; > > > > > > > > + clock-names = "apb_pclk", "wdog_clk"; > > > > > > > > + }; > > > > > > > > + > > > > > > > > + cluster1_core1_watchdog: wdt@c010000 { > > > > > > > > + compatible = "arm,sp805", > "arm,primecell"; > > > > > > > > + reg = <0x0 0xc010000 0x0 0x1000>; > > > > > > > > + clocks = <&clockgen 4 15>, > > > > > > > > + <&clockgen > > > > > > > > + 4 > > > 15>; > > > > > > > > + clock-names = "apb_pclk", > > > > > > > > + "wdog_clk"; > > > > > > > > }; > > > > > > > > > > > > > > > > sata: sata@3200000 { > > > > > > > > -- > > > > > > > > 2.17.1 > > > > > > > >
On Fri, May 24, 2019 at 4:48 AM Chuanhua Han <chuanhua.han@nxp.com> wrote: > > Hi, Rob Herring > > > -----Original Message----- > > From: Leo Li > > Sent: 2019年5月22日 14:50 > > > > > > > > > - wdog0: watchdog@23c0000 { > > > > > > > > > - compatible = "fsl,ls1028a-wdt", > > > > "fsl,imx21-wdt"; > > > > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>; > > > > > > > > > - interrupts = <GIC_SPI 59 > > > > > > IRQ_TYPE_LEVEL_HIGH>; > > > > > > > > > - clocks = <&clockgen 4 1>; > > > > > > > > > - big-endian; > > > > > > > > > - status = "disabled"; > > > > > > > > > + cluster1_core0_watchdog: wdt@c000000 { > > > > > > > > > > > > > > > > Keep 'watchdog' as the node name, > > > > > > > Thanks for your replay > > > > > > > Do you mean replace the ‘wdt’ with ‘watchdog’? > > > > > > > and keep nodes sort in unit-address. > > > > > > > What does this mean? > > > > > > > > > > > > That means order the nodes by the addresses (e.g. c000000, > > > > > > c010000) > > > > > The current order is correct（The first is c000000, then c000000）. > > > > > > > > But they are added after gpio@2320000 and before sata@3200000. > > > I changed and made the second version of the patch, but I found the > > > following error when I executed ./scripts/checkpatch.pl xxx.patch to > > > check the patch: > > > > > > WARNING: DT compatible string vendor "arm" appears un-documented -- > > > check ./Documentation/devicetree/bindings/vendor-prefixes.txt > > > #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351: > > > + compatible = "arm,sp805", "arm,primecell"; > > > > > > However, there is no vendor-prefixes.txt file in the > > > ./Documentation/devicetree/bindings/ directory, only vendor- > > > prefixes.yaml. > > > Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml. > > > > Added Rob Herring to the thread. > > > > > Request help，thanks > How can I solve this patch check error? Ask for help, thank you! Ignore it. A fix to checkpatch.pl is pending. Rob
> -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 2019年5月24日 20:29 > To: Chuanhua Han <chuanhua.han@nxp.com> > Cc: Leo Li <leoyang.li@nxp.com>; Shawn Guo <shawnguo@kernel.org>; > mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Ying Zhang > <ying.zhang22455@nxp.com> > Subject: Re: [EXT] Re: [PATCH] arm64: dts: ls1028a: fix watchdog device node > > Caution: EXT Email > > On Fri, May 24, 2019 at 4:48 AM Chuanhua Han <chuanhua.han@nxp.com> > wrote: > > > > Hi, Rob Herring > > > > > -----Original Message----- > > > From: Leo Li > > > Sent: 2019年5月22日 14:50 > > > > > > > > > > > > - wdog0: watchdog@23c0000 { > > > > > > > > > > - compatible = "fsl,ls1028a-wdt", > > > > > "fsl,imx21-wdt"; > > > > > > > > > > - reg = <0x0 0x23c0000 0x0 0x10000>; > > > > > > > > > > - interrupts = <GIC_SPI 59 > > > > > > > IRQ_TYPE_LEVEL_HIGH>; > > > > > > > > > > - clocks = <&clockgen 4 1>; > > > > > > > > > > - big-endian; > > > > > > > > > > - status = "disabled"; > > > > > > > > > > + cluster1_core0_watchdog: wdt@c000000 { > > > > > > > > > > > > > > > > > > Keep 'watchdog' as the node name, > > > > > > > > Thanks for your replay > > > > > > > > Do you mean replace the ‘wdt’ with ‘watchdog’? > > > > > > > > and keep nodes sort in unit-address. > > > > > > > > What does this mean? > > > > > > > > > > > > > > That means order the nodes by the addresses (e.g. c000000, > > > > > > > c010000) > > > > > > The current order is correct（The first is c000000, then c000000）. > > > > > > > > > > But they are added after gpio@2320000 and before sata@3200000. > > > > I changed and made the second version of the patch, but I found > > > > the following error when I executed ./scripts/checkpatch.pl > > > > xxx.patch to check the patch: > > > > > > > > WARNING: DT compatible string vendor "arm" appears un-documented > > > > -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt > > > > #43: FILE: arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:351: > > > > + compatible = "arm,sp805", "arm,primecell"; > > > > > > > > However, there is no vendor-prefixes.txt file in the > > > > ./Documentation/devicetree/bindings/ directory, only vendor- > > > > prefixes.yaml. > > > > Moreover, there are ‘arm’ vendors in vendor-prefixes.yaml. > > > > > > Added Rob Herring to the thread. > > > > > > > Request help，thanks > > How can I solve this patch check error? Ask for help, thank you! > > Ignore it. A fix to checkpatch.pl is pending. OK, the second version has been sent. Checking with checkpatch.pl is no problem. > > Rob
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index b04581249f0b..1510b1858246 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -285,13 +285,18 @@ #interrupt-cells = <2>; }; - wdog0: watchdog@23c0000 { - compatible = "fsl,ls1028a-wdt", "fsl,imx21-wdt"; - reg = <0x0 0x23c0000 0x0 0x10000>; - interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clockgen 4 1>; - big-endian; - status = "disabled"; + cluster1_core0_watchdog: wdt@c000000 { + compatible = "arm,sp805", "arm,primecell"; + reg = <0x0 0xc000000 0x0 0x1000>; + clocks = <&clockgen 4 15>, <&clockgen 4 15>; + clock-names = "apb_pclk", "wdog_clk"; + }; + + cluster1_core1_watchdog: wdt@c010000 { + compatible = "arm,sp805", "arm,primecell"; + reg = <0x0 0xc010000 0x0 0x1000>; + clocks = <&clockgen 4 15>, <&clockgen 4 15>; + clock-names = "apb_pclk", "wdog_clk"; }; sata: sata@3200000 {