From patchwork Wed Jun 19 17:29:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 11004861 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3CB5013AF for ; Wed, 19 Jun 2019 17:32:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 296F828515 for ; Wed, 19 Jun 2019 17:32:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1E3D1285CB; Wed, 19 Jun 2019 17:32:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8D44E285BE for ; Wed, 19 Jun 2019 17:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=2F08bqIQEMFid/2m+3shHTt26fMMKWMxTmFDxQnd7Kk=; b=MjiStC0uEfxr88zzkXordiVUZB 1yAqptmUmSHIDbAfY/rS0D3a1GQ9iAyykDeF1u7U5LDZWTa3TIxiIE/QZcYcDS9Fj6oYc4X9fj/08 /q9LWyo4tDT7+qk4+fHS01TwuhteSITy+xXP92Za02cLATGeFtGDXzPE14iFb9eEGZldMtb3S/nbi GG3BdKTXEi1aiPA2enctIe0CiJVwwmUIdvqE0YdBNVDKs19epii/hcjTjEqnkXDRV52K8FROF4+9K GVnGaV8iYYjIhreH48cRsLhWjt1juK6BqMeYjrcxnlFEqHiQXQq7vxYQ4XNjuGYUrc5GU63Cv6m0F WtgYou/A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdeRF-0001E4-OM; Wed, 19 Jun 2019 17:32:01 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdePD-00072e-EI for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 17:29:57 +0000 Received: by mail-pl1-x641.google.com with SMTP id bh12so96572plb.4 for ; Wed, 19 Jun 2019 10:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DntHf6qmXjOCyFeWUksN07Ur/NuqwmdmF3FS5Sa+EJ0=; b=ovFVM3s48TGhF8GijshVlefEngqpAJFK7CnqJJwvS7KlyTi57OAaq8VzSW+I1OM4Ew e6R2fyrxS3aFTVRTTka0CXAHymjGhO3rrKR6VTd1b4MFYXHdT3w0oL9KATbvZ+/1Lnu3 /0qW07EhsKIcNVvF5+/W+3lx5enouHyvG1/UfGPRqWZFaNZwuVj+PibrUgm06TdZb5u3 hWd4p4aW+dTG64zhLheuxzMpKem4OxrkXKMBrKLajigbDHcfSxkfQmDU/Mkc1jMeR34V /Kg9i+S+qGmuQYq3XFg241PqrrGPZa24SdTg5DwILZC1LC3S2daZ3VyYZTJXITsXOCXF aBOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DntHf6qmXjOCyFeWUksN07Ur/NuqwmdmF3FS5Sa+EJ0=; b=RDT0iCOeNmXB4zRKAKO7HlVkz4vUZG70mAQCLgR1iHPK5g7Ba2XZnGGBG9rFtalDiu hkH7fXoWy8kztn70vhyycHk6WoeR/YDyoTnvAtZXIqSJyrYo7sp9LH6MTCXEqobXwJTk /a1KQcdwCKBBSoAC3vXba23TJdFcYLtTj+qHsNx7n02ry5g31H97/0hHDVNdZmWAQyBl JXftmAaiVoBGwyBB5Xam1kxznWhPksmukVHWz85ngxcvPiILoZ/2dhQSQydbkNoYxiYz yB3jVgMqRTGJWgj1i+o2QomOuzwkXxNPFuP+ZrSbw1qK1HDHoubYPC9Ti3TBTtExTYSa MaMA== X-Gm-Message-State: APjAAAW108Bj7nXDaOI1E+i+pIssoksudRXWcmKPY33pZWP80Pfbf495 naDi+MM2wJhoJWbMTME83xOzt7pVj/s+qg== X-Google-Smtp-Source: APXvYqzpPkaTpHgaLpXe48rxJ1cBMYvomI+njAAwpmnnf0U7iwfs8oOr5VPEkXP0soieDO4pj3LhYw== X-Received: by 2002:a17:902:23:: with SMTP id 32mr58900748pla.34.1560965394880; Wed, 19 Jun 2019 10:29:54 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id g2sm31348406pfb.95.2019.06.19.10.29.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jun 2019 10:29:54 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Subject: [PATCH 04/45] coresight: tmc-etf: Fix snapshot mode update function Date: Wed, 19 Jun 2019 11:29:08 -0600 Message-Id: <20190619172949.4522-5-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190619172949.4522-1-mathieu.poirier@linaro.org> References: <20190619172949.4522-1-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_102955_494141_B7EF65C0 X-CRM114-Status: GOOD ( 13.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When working in snapshot mode function perf_aux_output_begin() does not set the handle->size because the size is expected to be deduced by the placement of the "head" and "old" pointers in user space. As such there is no point in trying to adjust the amount of data to copy to the ring buffer. Signed-off-by: Mathieu Poirier Reviewed-by: Leo Yan Reviewed-by: Suzuki K Poulose Tested-by: Leo Yan --- drivers/hwtracing/coresight/coresight-tmc-etf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c index d026bd04a6af..31d41e2ad955 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c @@ -477,9 +477,11 @@ static unsigned long tmc_update_etf_buffer(struct coresight_device *csdev, /* * The TMC RAM buffer may be bigger than the space available in the * perf ring buffer (handle->size). If so advance the RRP so that we - * get the latest trace data. + * get the latest trace data. In snapshot mode none of that matters + * since we are expected to clobber stale data in favour of the latest + * traces. */ - if (to_read > handle->size) { + if (!buf->snapshot && to_read > handle->size) { u32 mask = 0; /*