From patchwork Wed Jun 19 19:53:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 11005165 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 091F6186E for ; Wed, 19 Jun 2019 20:01:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EAAA0286A1 for ; Wed, 19 Jun 2019 20:01:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DEF29286BF; Wed, 19 Jun 2019 20:01:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 882B7286A7 for ; Wed, 19 Jun 2019 20:01:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=o0Gf3YtzLBi3PKWcCxDb+wNfUkrquMhEWej+RvZmURg=; b=JIawT2XoTATpR3eyGX/geaDpkU ogOPQ+7n1Iddq8bLm6lkJUM9HUl/Ol+DCsIcE0ch15Xx/CHjl+2Op5DVmi9bRsQdpRxX/7MLsz5iJ RjdZ9VsY1g1+ZuFIf1LbY+wPHmHcNa9SUYYjha5IOayf74qM5iOL0N29ymIZT3874zwKsoXoY3+m8 iaz+4xlqZXZ0zN00TYSwFbEouNnqQY/C11vc9AVLEdtT34WjiHb1jxVhu/Syd/wwFtHep79Y+t61l jQrxHJCmb13cMn+y2+3XAxyBx6Djg7PFOvMu7G/+NpqMDEZ87NN2oMCPxMiBN4SSmQj7m1cfubMBc QShCmBpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdgmH-0007Ry-1G; Wed, 19 Jun 2019 20:01:53 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdgeO-0006fz-Cd for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 19:53:48 +0000 Received: by mail-pl1-x643.google.com with SMTP id cl9so249632plb.10 for ; Wed, 19 Jun 2019 12:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=R0Wh2bB4q/aIbgHc3QWovDYztq8qq4nwX/0TMGUqdNo=; b=NUIGt5KMieg3H21BEE1iAA/viwD8copPqA9hJVJz2lxz1O5X+yPhJSiIIMI3rNeJBC CRg1Px9idgeSEOmNRB2pjFKEwu0MLgjNyeJuUhCCIu6IkMgS0aHnNcmKCmvMm87cCat9 h9Gt2fK/ntwDPdNy15PoVvE7frICZMRzgCAol6gQdZNI/tKkwDtoqxeVD2g54TqfBZVh lE20F1GxVkqnKewsngY7Pjt776qV8uIaOKqdYtHF+WdDWEY6Fg4bJrhWCqmgWSCxhc5C C/H9OwzI28+FZyH0KO0UQOkX65Z33ZozEwBUePvMM0mBUXKv4EvyO9KbCkEQ+wYrnTyl kz5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=R0Wh2bB4q/aIbgHc3QWovDYztq8qq4nwX/0TMGUqdNo=; b=BkuYaXw3AhlX7S2yyZUxq/aAvWmze53Ppfc25AzXRfbqhghzNxfKQiqSiTlICbyHkC 8b+NPRYidsc2wpsBBXBtOrTQ2pNclfQ3fqtvhyugdtoCizZ6MV8nRU6vHHYa3JneYZN1 QzXqeioM71q8YP7V99HzO6dapWUGFoi6QuW85cEJNSVh6N1+SV91rUxlNoRqXS/+dGyf il6PGkZUtzo3QItfZlDMuN+nNCiRfGkr6tf+QHaOuvUNMSFsFL+AEosDwY8/oDSxAr1u xU8phW8tQQcCNTaQ58FZ+0o02oGDoBwDzRNjdhWoZLL5MguPhbQfZO6WBqy/c4fi97LV 3fEg== X-Gm-Message-State: APjAAAUvhibJlQvOnYW2AXiwOH3+bO0oCRaMoHWgSfWZ7HLDwu11ZtDC 7pNSdOCxC3xJWgzJ4EH45aanVQ== X-Google-Smtp-Source: APXvYqyswiCxY093Bhnp9HhynnIqXjOS4ktAD7R9vscNNzlqbI/P+iSUhh7qfadOArB2BWFww/UCfg== X-Received: by 2002:a17:902:aa03:: with SMTP id be3mr43306075plb.240.1560974022934; Wed, 19 Jun 2019 12:53:42 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id j14sm21615993pfn.120.2019.06.19.12.53.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jun 2019 12:53:42 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Subject: [PATCH 23/28] coresight: etb10: Do not call smp_processor_id from preemptible Date: Wed, 19 Jun 2019 13:53:13 -0600 Message-Id: <20190619195318.19254-24-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190619195318.19254-1-mathieu.poirier@linaro.org> References: <20190619195318.19254-1-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_125344_545425_D5F325FA X-CRM114-Status: GOOD ( 13.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Suzuki K Poulose During a perf session we try to allocate buffers on the "node" associated with the CPU the event is bound to. If it is not bound to a CPU, we use the current CPU node, using smp_processor_id(). However this is unsafe in a pre-emptible context and could generate the splats as below : BUG: using smp_processor_id() in preemptible [00000000] code: perf/2544 Use NUMA_NO_NODE hint instead of using the current node for events not bound to CPUs. Fixes: 2997aa4063d97fdb39 ("coresight: etb10: implementing AUX API") Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etb10.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index d5b9edecf76e..3810290e6d07 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c @@ -374,12 +374,10 @@ static void *etb_alloc_buffer(struct coresight_device *csdev, struct perf_event *event, void **pages, int nr_pages, bool overwrite) { - int node, cpu = event->cpu; + int node; struct cs_buffers *buf; - if (cpu == -1) - cpu = smp_processor_id(); - node = cpu_to_node(cpu); + node = (event->cpu == -1) ? NUMA_NO_NODE : cpu_to_node(event->cpu); buf = kzalloc_node(sizeof(struct cs_buffers), GFP_KERNEL, node); if (!buf)