From patchwork Wed Jun 19 19:53:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Poirier X-Patchwork-Id: 11005169 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5A4B176 for ; Wed, 19 Jun 2019 20:02:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 480E2286A1 for ; Wed, 19 Jun 2019 20:02:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3BA4F286BF; Wed, 19 Jun 2019 20:02:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D2B86286A1 for ; Wed, 19 Jun 2019 20:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4TFkK9QcVxFd3XuH9JarhYL+Hm2tRHyR8eF6s1kPa+k=; b=JCDOBKjVOJYUsI651JJ3MNwGAW 6d8ytb/nkO9s3Rkq6CD5YhIkWHRkPXmx5+xvSmkDhsteDWp1EWW1dDVn5hKLvWYqITOY7xSEIeMFq Qbl6fJioFVO0tnFx0FWldShxJouTsO72vH/5z95UMb/5c7NBNTdx4Oeq+C5VdsdjJtJgj2hcPmXR9 W3+eq8Gfg/b9WETFhiaBq5addO+NmmX2QoEsu4mVr6UQENkzloUVo6Mx6mad3BUlmvT2m2rqHTmdi Rt63dnUWzK8oXsaM0qele9sqr0/djNsqbkMWSIuPSKND+FwfTgHk0SW6kEgd14aSZxJsvF5aCsFvC rQyGTZRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdgmt-00080N-Uw; Wed, 19 Jun 2019 20:02:31 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdgeQ-0006hm-66 for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 19:53:50 +0000 Received: by mail-pf1-x441.google.com with SMTP id q10so199323pff.9 for ; Wed, 19 Jun 2019 12:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZB/QEA/K3clWkDbM4qhRU5KEkoHlA3Iglne8yOGj5AU=; b=oxz8QNlNYpu14xP9SeCJNn/S/raL5b10AEjEFQ6To6DHmMBPrqxHndGOEkmQTtTNwt vUR0b4ZZ/gNdCUY9JP7CPwWbA/hjGCANWVExDbwezN2B6FEinBzFcvvgUA2AA84bIvVe VJ2G6L2Nn3aVPYgDexi2wEPOAMv9EHTAiBs+zDYmzdaO1rd+E+M8fSOIZ7A8xqRA8YqI YcY4ToTMoPVN+ej1tnoMJ+17Y/5GNAFbClrCWeij2V9rNrAglCxlSZtFhtOHW5mI36GX oaEx9iQreoUroEFQV6vHEPALHj9d/EXUueq84RtXLfoWjxWYQBBV4066hStpcNhQojLX +Deg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZB/QEA/K3clWkDbM4qhRU5KEkoHlA3Iglne8yOGj5AU=; b=SQWddODMFdX8HV2ocA2Lc4TF+Bd1ogvOlqhdf4uYZTMsIprDJITN7z+OYddHUJX4+R 9UNbVXbJxdXH/H45hfr0NkU8FLZBxfTkpbSoe6gM90anUTsLmFjSYFQ30X8i/FGCFl07 KZ39nqm0NYjT6+xBdsyES8fyvEBegnL9/6pDLJnXzv7i2IAxTuw6+vrO3bj+PfTAunfS Yu1xaVZZz2E83McbG+J99NGv85vXeD8U6gkW4qvDspC4ZPgJ3lUaGbvdg0HoK33Y+Sd6 tuIBMsAddI+ved7DFprrVAGoXNPwkVhQcstAYnn+3poD0oIdNyUJy8qaBNUSJlpp00hH WCFg== X-Gm-Message-State: APjAAAWzfw/zNSFs43A17qhJVGjzXWLZvO/4UzuhBjPv2+cQsS2+guvo IgJsKHdm+Kn4/1vJbUdhJfI2ucq45hrPFg== X-Google-Smtp-Source: APXvYqyQl/rSTWw+sEz+Dr4fSV5h01XvuVJZXuMzFVzg5eyxn1h7DimTkvRMWgJ5G1VQgXe+5h1tsA== X-Received: by 2002:a17:90a:d814:: with SMTP id a20mr13059065pjv.48.1560974024684; Wed, 19 Jun 2019 12:53:44 -0700 (PDT) Received: from xps15.cg.shawcable.net (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id j14sm21615993pfn.120.2019.06.19.12.53.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jun 2019 12:53:44 -0700 (PDT) From: Mathieu Poirier To: gregkh@linuxfoundation.org Subject: [PATCH 25/28] coresight: etm3x: Smatch: Fix potential NULL pointer dereference Date: Wed, 19 Jun 2019 13:53:15 -0600 Message-Id: <20190619195318.19254-26-mathieu.poirier@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190619195318.19254-1-mathieu.poirier@linaro.org> References: <20190619195318.19254-1-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_125346_374432_97C3FE2A X-CRM114-Status: GOOD ( 12.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Suzuki K Poulose Based on the following report from Smatch tool, make sure we have a valid drvdata before we dereference it to find the real dev. The patch 21d26b905c05: "coresight: etm: Clean up device specific data" from May 22, 2019, leads to the following Smatch complaint: ./drivers/hwtracing/coresight/coresight-etm3x.c:460 etm_get_trace_id() warn: variable dereferenced before check 'drvdata' (see line 458) ./drivers/hwtracing/coresight/coresight-etm3x.c 457 int trace_id = -1; 458 struct device *etm_dev = drvdata->csdev->dev.parent; ^^^^^^^^^ New dereference 459 460 if (!drvdata) ^^^^^^^^ Checked too late. Delete the check? 461 goto out; 462 Cc: Mathieu Poirier Cc: Dan Carpenter Signed-off-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm3x.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c index bed729140718..225c2982e4fe 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x.c +++ b/drivers/hwtracing/coresight/coresight-etm3x.c @@ -455,11 +455,12 @@ int etm_get_trace_id(struct etm_drvdata *drvdata) { unsigned long flags; int trace_id = -1; - struct device *etm_dev = drvdata->csdev->dev.parent; + struct device *etm_dev; if (!drvdata) goto out; + etm_dev = drvdata->csdev->dev.parent; if (!local_read(&drvdata->mode)) return drvdata->traceid;