diff mbox series

dt-bindings: hwmon: Add binding for pxe1610

Message ID 20190722192451.1947348-2-vijaykhemka@fb.com (mailing list archive)
State New, archived
Headers show
Series dt-bindings: hwmon: Add binding for pxe1610 | expand

Commit Message

Vijay Khemka July 22, 2019, 7:24 p.m. UTC 
Added new DT binding document for Infineon PXE1610 devices.

Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
---
 .../devicetree/bindings/hwmon/pxe1610.txt         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pxe1610.txt

Comments

Guenter Roeck July 22, 2019, 8:06 p.m. UTC | #1 
On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote:
> Added new DT binding document for Infineon PXE1610 devices.
> 
> Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
> ---
>  .../devicetree/bindings/hwmon/pxe1610.txt         | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pxe1610.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pxe1610.txt b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
> new file mode 100644
> index 000000000000..635daf4955db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
> @@ -0,0 +1,15 @@
> +pxe1610 properties
> +
> +Required properties:
> +- compatible: Must be one of the following:
> +	- "infineon,pxe1610" for pxe1610
> +	- "infineon,pxe1110" for pxe1610
> +	- "infineon,pxm1310" for pxm1310
> +- reg: I2C address
> +
> +Example:
> +
> +vr@48 {
> +	compatible = "infineon,pxe1610";
> +	reg = <0x48>;
> +};

Wouldn't it be better to add this to
./Documentation/devicetree/bindings/trivial-devices.txt ?

Thanks,
Guenter
Vijay Khemka July 23, 2019, 12:12 a.m. UTC | #2 
On 7/22/19, 1:06 PM, "Guenter Roeck" <groeck7@gmail.com on behalf of linux@roeck-us.net> wrote:

    On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote:
    > Added new DT binding document for Infineon PXE1610 devices.
    > 
    > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
    > ---
    >  .../devicetree/bindings/hwmon/pxe1610.txt         | 15 +++++++++++++++
    >  1 file changed, 15 insertions(+)
    >  create mode 100644 Documentation/devicetree/bindings/hwmon/pxe1610.txt
    > 
    > diff --git a/Documentation/devicetree/bindings/hwmon/pxe1610.txt b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
    > new file mode 100644
    > index 000000000000..635daf4955db
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
    > @@ -0,0 +1,15 @@
    > +pxe1610 properties
    > +
    > +Required properties:
    > +- compatible: Must be one of the following:
    > +	- "infineon,pxe1610" for pxe1610
    > +	- "infineon,pxe1110" for pxe1610
    > +	- "infineon,pxm1310" for pxm1310
    > +- reg: I2C address
    > +
    > +Example:
    > +
    > +vr@48 {
    > +	compatible = "infineon,pxe1610";
    > +	reg = <0x48>;
    > +};
    
    Wouldn't it be better to add this to
    ./Documentation/devicetree/bindings/trivial-devices.txt ?
Sure, I didn't know about this file. I will add and send another patch. It is 
Documentation/devicetree/bindings/trivial-devices.yaml. How do I abandon 
this patch or just leave it.
    
    Thanks,
    Guenter
Guenter Roeck July 23, 2019, 1:56 a.m. UTC | #3 
On 7/22/19 5:12 PM, Vijay Khemka wrote:
> 
> 
> On 7/22/19, 1:06 PM, "Guenter Roeck" <groeck7@gmail.com on behalf of linux@roeck-us.net> wrote:
> 
>      On Mon, Jul 22, 2019 at 12:24:48PM -0700, Vijay Khemka wrote:
>      > Added new DT binding document for Infineon PXE1610 devices.
>      >
>      > Signed-off-by: Vijay Khemka <vijaykhemka@fb.com>
>      > ---
>      >  .../devicetree/bindings/hwmon/pxe1610.txt         | 15 +++++++++++++++
>      >  1 file changed, 15 insertions(+)
>      >  create mode 100644 Documentation/devicetree/bindings/hwmon/pxe1610.txt
>      >
>      > diff --git a/Documentation/devicetree/bindings/hwmon/pxe1610.txt b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
>      > new file mode 100644
>      > index 000000000000..635daf4955db
>      > --- /dev/null
>      > +++ b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
>      > @@ -0,0 +1,15 @@
>      > +pxe1610 properties
>      > +
>      > +Required properties:
>      > +- compatible: Must be one of the following:
>      > +	- "infineon,pxe1610" for pxe1610
>      > +	- "infineon,pxe1110" for pxe1610
>      > +	- "infineon,pxm1310" for pxm1310
>      > +- reg: I2C address
>      > +
>      > +Example:
>      > +
>      > +vr@48 {
>      > +	compatible = "infineon,pxe1610";
>      > +	reg = <0x48>;
>      > +};
>      
>      Wouldn't it be better to add this to
>      ./Documentation/devicetree/bindings/trivial-devices.txt ?
> Sure, I didn't know about this file. I will add and send another patch. It is
> Documentation/devicetree/bindings/trivial-devices.yaml. How do I abandon
> this patch or just leave it.
>      

When you send v2, just add the device to the trivial-devices file instead
and describe the differences to v1 (ie this patch).

Guenter
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/hwmon/pxe1610.txt b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
new file mode 100644
index 000000000000..635daf4955db
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pxe1610.txt
@@ -0,0 +1,15 @@ 
+pxe1610 properties
+
+Required properties:
+- compatible: Must be one of the following:
+	- "infineon,pxe1610" for pxe1610
+	- "infineon,pxe1110" for pxe1610
+	- "infineon,pxm1310" for pxm1310
+- reg: I2C address
+
+Example:
+
+vr@48 {
+	compatible = "infineon,pxe1610";
+	reg = <0x48>;
+};