| Message ID | 20190722202024.14867-4-s-anna@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Mailbox nodes for TI K3 AM65x & J721E SoCs | expand |
On 15:20-20190722, Suman Anna wrote: > The J721E Main NavSS block contains a Mailbox IP instance with > multiple clusters. Each cluster is equivalent to an Mailbox IP > instance on OMAP platforms. > > Add all the Mailbox clusters as their own nodes under the MAIN > NavSS cbass_main_navss interconnect node instead of creating an > almost empty parent node for the new K3 mailbox IP and the clusters > as its child nodes. All these nodes are marked as disabled, and > they need to be enabled along with the appropriate child nodes > on a need basis. > > NOTE: > The NavSS only has a limited number of interrupts, so all the > interrupts generated by a Mailbox IP are not added by default. > Only the needed interrupts that are targeted towards the A72 > GIC will need to be be added later on when some sub-mailbox > child nodes are added. > > Signed-off-by: Suman Anna <s-anna@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 108 ++++++++++++++++++++++ > 1 file changed, 108 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > index a2e031f7d88e..319d423b3440 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > @@ -95,6 +95,114 @@ > reg = <0x00 0x30e00000 0x00 0x1000>; > #hwlock-cells = <1>; > }; > + > + mailbox0_cluster0: mailbox@31f80000 { > + compatible = "ti,am654-mailbox"; > + reg = <0x00 0x31f80000 0x00 0x200>; > + #mbox-cells = <1>; > + ti,mbox-num-users = <4>; > + ti,mbox-num-fifos = <16>; > + status = "disabled"; Please drop disabled.
On 7/23/19 6:37 AM, Nishanth Menon wrote: > On 15:20-20190722, Suman Anna wrote: >> The J721E Main NavSS block contains a Mailbox IP instance with >> multiple clusters. Each cluster is equivalent to an Mailbox IP >> instance on OMAP platforms. >> >> Add all the Mailbox clusters as their own nodes under the MAIN >> NavSS cbass_main_navss interconnect node instead of creating an >> almost empty parent node for the new K3 mailbox IP and the clusters >> as its child nodes. All these nodes are marked as disabled, and >> they need to be enabled along with the appropriate child nodes >> on a need basis. >> >> NOTE: >> The NavSS only has a limited number of interrupts, so all the >> interrupts generated by a Mailbox IP are not added by default. >> Only the needed interrupts that are targeted towards the A72 >> GIC will need to be be added later on when some sub-mailbox >> child nodes are added. >> >> Signed-off-by: Suman Anna <s-anna@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 108 ++++++++++++++++++++++ >> 1 file changed, 108 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> index a2e031f7d88e..319d423b3440 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi >> @@ -95,6 +95,114 @@ >> reg = <0x00 0x30e00000 0x00 0x1000>; >> #hwlock-cells = <1>; >> }; >> + >> + mailbox0_cluster0: mailbox@31f80000 { >> + compatible = "ti,am654-mailbox"; >> + reg = <0x00 0x31f80000 0x00 0x200>; >> + #mbox-cells = <1>; >> + ti,mbox-num-users = <4>; >> + ti,mbox-num-fifos = <16>; >> + status = "disabled"; > > Please drop disabled. Same comment as on the AM65x patch (patch 1). regards Suman
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi index a2e031f7d88e..319d423b3440 100644 --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi @@ -95,6 +95,114 @@ reg = <0x00 0x30e00000 0x00 0x1000>; #hwlock-cells = <1>; }; + + mailbox0_cluster0: mailbox@31f80000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f80000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster1: mailbox@31f81000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f81000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster2: mailbox@31f82000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f82000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster3: mailbox@31f83000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f83000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster4: mailbox@31f84000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f84000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster5: mailbox@31f85000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f85000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster6: mailbox@31f86000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f86000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster7: mailbox@31f87000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f87000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster8: mailbox@31f88000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f88000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster9: mailbox@31f89000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f89000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster10: mailbox@31f8a000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f8a000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; + + mailbox0_cluster11: mailbox@31f8b000 { + compatible = "ti,am654-mailbox"; + reg = <0x00 0x31f8b000 0x00 0x200>; + #mbox-cells = <1>; + ti,mbox-num-users = <4>; + ti,mbox-num-fifos = <16>; + status = "disabled"; + }; }; secure_proxy_main: mailbox@32c00000 {
The J721E Main NavSS block contains a Mailbox IP instance with multiple clusters. Each cluster is equivalent to an Mailbox IP instance on OMAP platforms. Add all the Mailbox clusters as their own nodes under the MAIN NavSS cbass_main_navss interconnect node instead of creating an almost empty parent node for the new K3 mailbox IP and the clusters as its child nodes. All these nodes are marked as disabled, and they need to be enabled along with the appropriate child nodes on a need basis. NOTE: The NavSS only has a limited number of interrupts, so all the interrupts generated by a Mailbox IP are not added by default. Only the needed interrupts that are targeted towards the A72 GIC will need to be be added later on when some sub-mailbox child nodes are added. Signed-off-by: Suman Anna <s-anna@ti.com> --- arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 108 ++++++++++++++++++++++ 1 file changed, 108 insertions(+)