From patchwork Fri Jul 26 11:28:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 11060831 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 33F6913AC for ; Fri, 26 Jul 2019 11:30:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2372628868 for ; Fri, 26 Jul 2019 11:30:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 163B928928; Fri, 26 Jul 2019 11:30:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B25E4288F7 for ; Fri, 26 Jul 2019 11:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ysllWeF/2tpoxfkTmnJmiQSi1j/YVhECt2I2eNmUOs4=; b=rbh6ysY9asNThL yG9+kQ4pzSebgvtIiuKB4QTc2/32eCQKKomxChCUQOIwUn6R8W5whv6ltX+DCWvMRrgfvLWofxEw9 eO0zlQhj8hkO7jFsRRGi4hrB55RkpmLS452ySZm1DqmFYzUnsj6f0RHoPXR70LnzJpjSe8F4auG1l cy07yuZkzhZHy7KBaLpZlgOasM4jfWcAGzOa2ismByEWUFMni18ah0uUQnr4kmTgyaZjyakywv5k7 CKT1tPTLtmJKHlA7V/7LpDdC2M72jdSWTsk1Pg2KWPFO8J98BV+H+18IFUv+QS/b0LL5rAinywj/w 68ZBIF40nTxd5l0oUAAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqyQm-0005I2-RK; Fri, 26 Jul 2019 11:30:37 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqyOY-0002LR-K1 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2019 11:28:20 +0000 Received: by mail-lf1-x141.google.com with SMTP id s19so36845060lfb.9 for ; Fri, 26 Jul 2019 04:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yms7A0Dj/ss/bfob7fvSwoSoaN3YOnXapMDkDt2JkGk=; b=dI3W3+aYZkRhr2cVhzUptcUM2pwVVATteZ4VZ3NtR71AqBqGIYfrf8yrxzStuM+3nE tya5Wiu6pzLKkBX88Pc9jxDP11Kp2Nb7gJvFfjHY3wHbyJTa9MjgkhXMMSLglyktzkm3 rtfP0GDsu4nDfg7oDxj6j5NfrKRKG9nFa1yKVgkG+vm4TleEGCA4h4MB8cJEZeWnFrVx 66ajVkJqxzTBxoq8QcMEGK7KzPudl9gdTSkKZ9JTKZKCDGv4Ao7DdYIPa5uPBiKKxwIV QUSwtaEwhzZ9sq1FGfEOxB2hVT7HFBdpqVMA8nbZVRahng8T1uE6i7OUfifFilHWGBbe be7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yms7A0Dj/ss/bfob7fvSwoSoaN3YOnXapMDkDt2JkGk=; b=b4gX84W/A2Ldn51aJhKedf0QlW4Ma56f0EfBErh9gjO5Oy9zDQLvWOmq+lpTWDUVrM SQJoHNHzWc1ZVjtgqoQ0mHpMZs5gDbwXB+Wurjm9+GbWthhSMw9XUX/Ii9KGk3dJAVlY NbXnwEImP2kcLCI9AdQrMwB2nA2nbG6grGimLTZDfHIrqA/1UWXfQwWNa6M4k+j92dmW bp7sdqt3aMmnkNdIxIhH1pHFX0gCdweTUBRgK4lvobezi6O55h9//qSNqc4hk7bHfq6+ pZZn0qoUt7yb2hYPuLHJYHmprqpsoQ5qHaN13HzXZWa09QX10CPM7ubZrdb3UhZlsCgI Wkfw== X-Gm-Message-State: APjAAAUDJBwzTiiOFj8367AB10qsfxRm+bHG4FgbnZCP9K94GpCX0oRb cfZtdK5BZPf3YjnwnqKfQ95IeA== X-Google-Smtp-Source: APXvYqx05CPqPaf24TqfXHUET5OwIsXvhc0hYDuun6wEBRgaKaaGpBp1xs/Z6Ozl1ehbTYYA+0UBew== X-Received: by 2002:a19:be03:: with SMTP id o3mr43992429lff.88.1564140496719; Fri, 26 Jul 2019 04:28:16 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id b27sm10020400ljb.11.2019.07.26.04.28.15 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:28:16 -0700 (PDT) From: Anders Roxell To: linus.walleij@linaro.org, heiko@sntech.de Subject: [PATCH 1/2] pinctrl: rockchip: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:28:12 +0200 Message-Id: <20190726112812.19665-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190726_042818_848122_9913D4B7 X-CRM114-Status: UNSURE ( 9.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anders Roxell , linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, linux-gpio@vger.kernel.org, agross@kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/pinctrl/pinctrl-rockchip.c: In function ‘rockchip_gpio_set_config’: ../drivers/pinctrl/pinctrl-rockchip.c:2783:3: warning: this statement may fall through [-Wimplicit-fallthrough=] rockchip_gpio_set_debounce(gc, offset, true); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/pinctrl/pinctrl-rockchip.c:2795:2: note: here default: ^~~~~~~ Rework so that the compiler doesn't warn about fall-through. Add 'return -ENOTSUPP;' to match the comment. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/pinctrl/pinctrl-rockchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 62a622159006..dc0bbf198cbc 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -2792,6 +2792,7 @@ static int rockchip_gpio_set_config(struct gpio_chip *gc, unsigned int offset, * still return -ENOTSUPP as before, to make sure the caller * of gpiod_set_debounce won't change its behaviour. */ + return -ENOTSUPP; default: return -ENOTSUPP; }