| Message ID | 20190729142316.21900-1-martin@kaiser.cx (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 2c1a3f4dc4b927d182f725c83e31bb055c9eb881 |
| Headers | show |
| Series | ARM: dts: imx25-pdk: native-mode is part of display-timings | expand |
On Mon, Jul 29, 2019 at 11:23 AM Martin Kaiser <martin@kaiser.cx> wrote: > > Move the native-mode property inside the display-timings node. > > According to > Documentation/devicetree/bindings/display/panel/display-timing.txt. > native-mode is a property of the display-timings node. > > If it's located outside of display-timings, the native-mode setting is > ignored and the first display timing is used (which is a problem only if > someone adds another display timing). > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Reviewed-by: Fabio Estevam <festevam@gmail.com>
On Mon, Jul 29, 2019 at 04:23:16PM +0200, Martin Kaiser wrote: > Move the native-mode property inside the display-timings node. > > According to > Documentation/devicetree/bindings/display/panel/display-timing.txt. > native-mode is a property of the display-timings node. > > If it's located outside of display-timings, the native-mode setting is > ignored and the first display timing is used (which is a problem only if > someone adds another display timing). > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> Applied, thanks.
diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-pdk.dts index f8544a9e4633..05cccd12624c 100644 --- a/arch/arm/boot/dts/imx25-pdk.dts +++ b/arch/arm/boot/dts/imx25-pdk.dts @@ -76,8 +76,8 @@ bits-per-pixel = <16>; fsl,pcr = <0xfa208b80>; bus-width = <18>; - native-mode = <&wvga_timings>; display-timings { + native-mode = <&wvga_timings>; wvga_timings: 640x480 { hactive = <640>; vactive = <480>;
Move the native-mode property inside the display-timings node. According to Documentation/devicetree/bindings/display/panel/display-timing.txt. native-mode is a property of the display-timings node. If it's located outside of display-timings, the native-mode setting is ignored and the first display timing is used (which is a problem only if someone adds another display timing). Signed-off-by: Martin Kaiser <martin@kaiser.cx> --- Dear all, I found this issue on a similar board when I tried to define two variants that use different displays. I had two display timings and ended up using the wrong one because native-mode was ignored outside of display-timings. Thanks for reviewing the patch, Martin arch/arm/boot/dts/imx25-pdk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)