From patchwork Mon Jul 29 14:23:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 11063883 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 45F6C1398 for ; Mon, 29 Jul 2019 14:23:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 344A0274D0 for ; Mon, 29 Jul 2019 14:23:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 285A928711; Mon, 29 Jul 2019 14:23:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8529A274D0 for ; Mon, 29 Jul 2019 14:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Aoyq05H39sGMYhw0PHjhDzDEYU1pOJGk1CQuzVB/eD4=; b=dwu GKMCUMaJh7UX5rJmjdmzcl3vnTpZPJnPS6Ut2qKOjrapF4BkJ+2QSuf7hUKBa8xgFBKEXxDmSCIlm VVZVY1TP7rEvKV/sM3pzOrsb9sX7iSxsKOr7+4zULKdF585fYObRna5pVYcCyHn1UlvnWL12bEpHX wE/jsRjImKO3mFjaMpW63ZMHhhtCD4PPTdZC5We1mPYkIMnAoU9BbfwdMFxdVISaJcgg8iSd/ophy Ajse4bxnmn6IUGG4at+uYZeZHHi/RuAiwBXMPPdwr4rcbGv5ny/Om2BzVXsB6hRbsVjBFMRbldTkB zQWYK2le8TqW9SNkd+YiY9UmRm0Pb+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs6Z8-0002oD-58; Mon, 29 Jul 2019 14:23:54 +0000 Received: from viti.kaiser.cx ([2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hs6Z4-0002nI-6y for linux-arm-kernel@lists.infradead.org; Mon, 29 Jul 2019 14:23:51 +0000 Received: from [46.114.3.104] (helo=martin-debian-1.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1hs6Yw-0005cy-4j; Mon, 29 Jul 2019 16:23:42 +0200 From: Martin Kaiser To: Fabio Estevam , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Rob Herring Subject: [PATCH] ARM: dts: imx25-pdk: native-mode is part of display-timings Date: Mon, 29 Jul 2019 16:23:16 +0200 Message-Id: <20190729142316.21900-1-martin@kaiser.cx> X-Mailer: git-send-email 2.11.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_072350_404138_6F34E5EE X-CRM114-Status: GOOD ( 11.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Martin Kaiser , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Move the native-mode property inside the display-timings node. According to Documentation/devicetree/bindings/display/panel/display-timing.txt. native-mode is a property of the display-timings node. If it's located outside of display-timings, the native-mode setting is ignored and the first display timing is used (which is a problem only if someone adds another display timing). Signed-off-by: Martin Kaiser Reviewed-by: Fabio Estevam --- Dear all, I found this issue on a similar board when I tried to define two variants that use different displays. I had two display timings and ended up using the wrong one because native-mode was ignored outside of display-timings. Thanks for reviewing the patch, Martin arch/arm/boot/dts/imx25-pdk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-pdk.dts index f8544a9e4633..05cccd12624c 100644 --- a/arch/arm/boot/dts/imx25-pdk.dts +++ b/arch/arm/boot/dts/imx25-pdk.dts @@ -76,8 +76,8 @@ bits-per-pixel = <16>; fsl,pcr = <0xfa208b80>; bus-width = <18>; - native-mode = <&wvga_timings>; display-timings { + native-mode = <&wvga_timings>; wvga_timings: 640x480 { hactive = <640>; vactive = <480>;