| Message ID | 20190820155745.20593-1-raphael.gault@arm.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | d91cc2f46ad5bd8020902093385fedf7e9e9d755 |
| Headers | show |
| Series | arm64: perf_event: Add missing header needed for smp_processor_id() | expand |
On Tue, Aug 20, 2019 at 04:57:45PM +0100, Raphael Gault wrote: It would be worth having a body for the commit message like: | in perf_event.c we use smp_processor_id(), but we haven't included | <linux/smp.h> where it is defined, and rely on this being pulled in | via a transitive include. Let's make this more robust by including | <linux.smp.h> explciitly. ... and with that, my Acked-by stands. Thanks, Mark. > Acked-by: Mark Rutland <mark.rutland@arm.com> > Signed-off-by: Raphael Gault <raphael.gault@arm.com> > --- > arch/arm64/kernel/perf_event.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c > index 96e90e270042..24575c0a0065 100644 > --- a/arch/arm64/kernel/perf_event.c > +++ b/arch/arm64/kernel/perf_event.c > @@ -19,6 +19,7 @@ > #include <linux/of.h> > #include <linux/perf/arm_pmu.h> > #include <linux/platform_device.h> > +#include <linux/smp.h> > > /* ARMv8 Cortex-A53 specific event types. */ > #define ARMV8_A53_PERFCTR_PREF_LINEFILL 0xC2 > -- > 2.17.1 >
On Tue, Aug 20, 2019 at 05:06:29PM +0100, Mark Rutland wrote: > On Tue, Aug 20, 2019 at 04:57:45PM +0100, Raphael Gault wrote: > > It would be worth having a body for the commit message like: > > | in perf_event.c we use smp_processor_id(), but we haven't included > | <linux/smp.h> where it is defined, and rely on this being pulled in > | via a transitive include. Let's make this more robust by including > | <linux.smp.h> explciitly. > > ... and with that, my Acked-by stands. Queued for 5.4. with typo fixed above. Will
diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c index 96e90e270042..24575c0a0065 100644 --- a/arch/arm64/kernel/perf_event.c +++ b/arch/arm64/kernel/perf_event.c @@ -19,6 +19,7 @@ #include <linux/of.h> #include <linux/perf/arm_pmu.h> #include <linux/platform_device.h> +#include <linux/smp.h> /* ARMv8 Cortex-A53 specific event types. */ #define ARMV8_A53_PERFCTR_PREF_LINEFILL 0xC2