From patchwork Sun Sep 15 19:34:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 11146095 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C2EF51800 for ; Sun, 15 Sep 2019 19:34:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0AF520830 for ; Sun, 15 Sep 2019 19:34:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TxJijTRq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0AF520830 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wanadoo.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Y0ZKJxyXJUjyo2FpbyhB7hkk5TIXrC/A9bCapQPOf2c=; b=TxJijTRq52dx27 6zx9zW4xY4AV6hBgC2g53ZfgKyEaL2dHeNnfaoiHhRr+EBzOOUSmxLVxEIqJ5gsA4g4Gpmnqw9Bpe jCZ00WaZVLf26SpVe19GdXUcf2851mPkVKP4XW9DRJq6LbpF63/AYDmoVzgjQT1RilRHpPqFd2yq9 DgvNxPDaTkaRtPTQ9NOG2/1VHTwkZzWxKWnpTMosHzKvVF7yRuYGICZAD8K0fQkkshFGhVBaLgTwR EqU3huqkJd8V+909khWGbmBkXqZ9lS+gd0aBE3/9rfvlEUEjtx+MhLzSTkOsMuUjFzQyDbhJu5vaa kqmKc4sWuHx7Xd76k2NQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9aHp-0004D0-RE; Sun, 15 Sep 2019 19:34:17 +0000 Received: from smtp02.smtpout.orange.fr ([80.12.242.124] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9aHm-0004Bz-Gz for linux-arm-kernel@lists.infradead.org; Sun, 15 Sep 2019 19:34:16 +0000 Received: from localhost.localdomain ([93.23.196.41]) by mwinf5d03 with ME id 1va5210090u43at03va5ta; Sun, 15 Sep 2019 21:34:07 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 15 Sep 2019 21:34:07 +0200 X-ME-IP: 93.23.196.41 From: Christophe JAILLET To: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org Subject: [PATCH] iommu/arm-smmu: Axe a useless test in 'arm_smmu_master_alloc_smes()' Date: Sun, 15 Sep 2019 21:34:01 +0200 Message-Id: <20190915193401.27426-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190915_123414_853873_6175B9A4 X-CRM114-Status: GOOD ( 15.58 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [80.12.242.124 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [80.12.242.124 listed in wl.mailspike.net] 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe JAILLET , iommu@lists.linux-foundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'ommu_group_get_for_dev()' never returns NULL, so this test can be removed. Signed-off-by: Christophe JAILLET Reviewed-by: Robin Murphy --- drivers/iommu/arm-smmu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index c3ef0cc8f764..6fae8cdbe985 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -1038,8 +1038,6 @@ static int arm_smmu_master_alloc_smes(struct device *dev) } group = iommu_group_get_for_dev(dev); - if (!group) - group = ERR_PTR(-ENOMEM); if (IS_ERR(group)) { ret = PTR_ERR(group); goto out_err;