diff mbox series

[1/1] ARM: dts: imx28: add poweroff support

Message ID 20190923091700.22517-1-sebastien.szymanski@armadeus.com (mailing list archive)
State Changes Requested
Headers show
Series [1/1] ARM: dts: imx28: add poweroff support | expand

Commit Message

Sébastien Szymanski Sept. 23, 2019, 9:17 a.m. UTC
This add poweroff support using the generic syscon-poweroff driver.

Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
---
 arch/arm/boot/dts/imx28.dtsi | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Shawn Guo Oct. 14, 2019, 6:38 a.m. UTC | #1
On Mon, Sep 23, 2019 at 11:17:00AM +0200, Sébastien Szymanski wrote:
> This add poweroff support using the generic syscon-poweroff driver.
> 
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
> ---
>  arch/arm/boot/dts/imx28.dtsi | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index e14d8ef0158b..37fa8131a022 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -1114,8 +1114,16 @@
>  			};
>  
>  			power: power@80044000 {
> +				compatible = "syscon", "simple-mfd";
>  				reg = <0x80044000 0x2000>;
> -				status = "disabled";
> +
> +				mxs_poweroff: mxs-poweroff {

Node name should be generic.  So 'poweroff' might be better.

> +					compatible = "syscon-poweroff";
> +					regmap = <&power>;
> +					offset = <0x104>;
> +					value = <0x3E770001>;

Use lowercase for hex value.

> +					status = "disabled";

Why need to disable it by default?

Shawn

> +				};
>  			};
>  
>  			saif1: saif@80046000 {
> -- 
> 2.21.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index e14d8ef0158b..37fa8131a022 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -1114,8 +1114,16 @@ 
 			};
 
 			power: power@80044000 {
+				compatible = "syscon", "simple-mfd";
 				reg = <0x80044000 0x2000>;
-				status = "disabled";
+
+				mxs_poweroff: mxs-poweroff {
+					compatible = "syscon-poweroff";
+					regmap = <&power>;
+					offset = <0x104>;
+					value = <0x3E770001>;
+					status = "disabled";
+				};
 			};
 
 			saif1: saif@80046000 {