| Message ID | 20191010083334.7037-1-andy.tang@nxp.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7eb3894b2fac978f811684e3ccb3cb0ad7820bef |
| Headers | show |
| Series | [v2] arm64: dts: ls1028a: fix a compatible issue | expand |
> -----Original Message----- > From: Yuantian Tang <andy.tang@nxp.com> > Sent: Thursday, October 10, 2019 3:34 AM > To: shawnguo@kernel.org > Cc: Leo Li <leoyang.li@nxp.com>; robh+dt@kernel.org; > mark.rutland@arm.com; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Andy Tang > <andy.tang@nxp.com> > Subject: [PATCH v2] arm64: dts: ls1028a: fix a compatible issue > > The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847. > If the wrong compatible was used, this chip will not be able to be probed > correctly and hence fail to work. > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com> Acked-by: Li Yang <leoyang.li@nxp.com> > --- > v2: > - refine the description > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index 5e14e5a19744..f5da9e8b0d9d 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -107,7 +107,7 @@ > status = "okay"; > > i2c-mux@77 { > - compatible = "nxp,pca9847"; > + compatible = "nxp,pca9547"; > reg = <0x77>; > #address-cells = <1>; > #size-cells = <0>; > -- > 2.17.1
On Thu, Oct 10, 2019 at 04:33:34PM +0800, Yuantian Tang wrote: > The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847. > If the wrong compatible was used, this chip will not be able to > be probed correctly and hence fail to work. > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com> Fixes: 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC") I added the tag and applied the patch. Please take care of adding Fixes tag for fixes in the future. Shawn > --- > v2: > - refine the description > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > index 5e14e5a19744..f5da9e8b0d9d 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts > @@ -107,7 +107,7 @@ > status = "okay"; > > i2c-mux@77 { > - compatible = "nxp,pca9847"; > + compatible = "nxp,pca9547"; > reg = <0x77>; > #address-cells = <1>; > #size-cells = <0>; > -- > 2.17.1 >
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts index 5e14e5a19744..f5da9e8b0d9d 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts @@ -107,7 +107,7 @@ status = "okay"; i2c-mux@77 { - compatible = "nxp,pca9847"; + compatible = "nxp,pca9547"; reg = <0x77>; #address-cells = <1>; #size-cells = <0>;
The I2C multiplexer used on ls1028aqds is PCA9547, not PCA9847. If the wrong compatible was used, this chip will not be able to be probed correctly and hence fail to work. Signed-off-by: Yuantian Tang <andy.tang@nxp.com> --- v2: - refine the description arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)